bug#10515: 23.3; vc-rcs-create-tag

bug#10515: 23.3; vc-rcs-create-tag

[Risto Mononen]

[-- Attachment #1: Type: text/plain, Size: 5230 bytes --]

 Hi,
Creating tag with *C-v s* fails since vc-rcs-create-tag gets the
forbidden branchp parameter. My quick fix was to be liberal on
 what is received and just give the notification message rather
than error. Please see the diff below.

BR, Risto Mononen


*** vc-rcs.el 2012/01/15 16:56:35 1.1
--- vc-rcs.el 2012/01/15 17:05:08 1.2
***************
*** 813,819 ****

  (defun vc-rcs-create-tag (backend dir name branchp)
    (when branchp
!     (error "RCS backend %s does not support module branches" backend))
    (let ((result (vc-tag-precondition dir)))
      (if (stringp result)
  (error "File %s is not up-to-date" result)
--- 813,819 ----

  (defun vc-rcs-create-tag (backend dir name branchp)
    (when branchp
!     (message "RCS backend %s does not support module branches" backend))
    (let ((result (vc-tag-precondition dir)))
      (if (stringp result)
  (error "File %s is not up-to-date" result)



In GNU Emacs 23.3.1 (i686-pc-linux-gnu, GTK+ Version 2.24.5)
 of 2011-08-14 on rothera, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.11004000
configured using `configure  '--build' 'i686-linux-gnu' '--build'
'i686-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib'
'--libexecdir=/usr/lib' '--localstatedir=/var/lib'
'--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes'
'--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.3/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.3/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.3/leim'
'--with-crt-dir=/usr/lib/i386-linux-gnu' '--with-x=yes'
'--with-x-toolkit=gtk' '--with-toolkit-scroll-bars'
'build_alias=i686-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g'
'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: en_US.UTF-8
  value of $LC_CTYPE: en_US.UTF-8
  value of $LC_MESSAGES: en_US.UTF-8
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  diff-auto-refine-mode: t
  show-paren-mode: t
  recentf-mode: t
  dynamic-completion-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t

Recent input:
C-x C-v C-k <return> C-x 1 s <C-home> n n n n Z y f
y e s <return> C-x v = C-x h M-w C-x o C-x o C-s m
e s C-w C-w C-w C-w C-x o C-s C-s C-s C-p C-x o M-b
M-b C-s C-w C-w C-w C-x o C-s C-s C-x v l n f C-s C-s
C-x k RET p f C-s C-s C-x o C-x v + C-x v = C-u C-x
v = <return> <return> C-x h M-w C-x 0 <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <menu-bar> <help-menu> <se
nd-emacs-bug-report>

Recent messages:
Checking out /usr/share/emacs/23.3/lisp/vc-rcs.el.~1.2~...done
Mark saved where search started
(No files need saving)
Checking out /usr/share/emacs/23.3/lisp/vc-rcs.el...done
Finding changes in /usr/share/emacs/23.3/lisp/vc-rcs.el...
No changes between working revision and workfile
Finding changes in /usr/share/emacs/23.3/lisp/vc-rcs.el...done
Mark set [2 times]
Saved text until "ror "File %s is not up-to-date" result)
"

Load-path shadows:
/usr/share/emacs/23.3/site-lisp/debian-startup hides
/usr/share/emacs/site-lisp/debian-startup
/usr/share/emacs23/site-lisp/dictionaries-common/flyspell hides
/usr/share/emacs/23.3/lisp/textmodes/flyspell
/usr/share/emacs23/site-lisp/dictionaries-common/ispell hides
/usr/share/emacs/23.3/lisp/textmodes/ispell

Features:
(shadow sort mail-extr message sendmail ecomplete rfc822 mml mml-sec
password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231
rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc
time-date mm-util mail-prsvr gmm-utils mailheader canlock sha1 hex-util
hashcash mail-utils emacsbug log-view pcvs-util multi-isearch diff-mode
easy-mmode vc dired-aux dired regexp-opt vc-dispatcher vc-rcs advice
help-fns advice-preload saveplace paren recentf tree-widget wid-edit
easymenu completion cus-start cus-load tooltip ediff-hook vc-hooks
lisp-float-type mwheel x-win x-dnd font-setting tool-bar dnd fontset
image fringe lisp-mode register page menu-bar rfn-eshadow timer select
scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core
frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help
simple abbrev loaddefs button minibuffer faces cus-face files
text-properties overlay md5 base64 format env code-pages mule custom
widget hashtable-print-readable backquote make-network-process dbusbind
system-font-setting font-render-setting gtk x-toolkit x multi-tty emacs)

[-- Attachment #2: Type: text/html, Size: 7778 bytes --]

bug#10515: 23.3; vc-rcs-create-tag

[Glenn Morris]

Version: 24.0.93

Risto Mononen wrote:

> Creating tag with *C-v s* fails

Thanks for the report. This is simply an error in the argument
specification of vc-rcs-create-tag (and vc-sccs-create-tag):

*** lisp/vc/vc-rcs.el	2012-01-19 07:21:25 +0000
--- lisp/vc/vc-rcs.el	2012-01-24 08:19:28 +0000
***************
*** 809,817 ****
  ;;; Tag system
  ;;;
  
! (defun vc-rcs-create-tag (backend dir name branchp)
    (when branchp
!     (error "RCS backend %s does not support module branches" backend))
    (let ((result (vc-tag-precondition dir)))
      (if (stringp result)
  	(error "File %s is not up-to-date" result)
--- 809,817 ----
  ;;; Tag system
  ;;;
  
! (defun vc-rcs-create-tag (dir name branchp)
    (when branchp
!     (error "RCS backend does not support module branches"))
    (let ((result (vc-tag-precondition dir)))
      (if (stringp result)
  	(error "File %s is not up-to-date" result)