bug#36897: 27.0.50; [CC Mode] c-after-change may signal error in narrowed buffer

bug#36897: 27.0.50; [CC Mode] c-after-change may signal error in narrowed buffer

[Noam Postavsky]

[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]

Package: emacs, cc-mode

From 'emacs -Q', eval the following:

(with-current-buffer (get-buffer-create "*test*")
  (erase-buffer)
  (insert "int main()\n{\n  \n}\n")
  (search-backward "\n}")
  (c-mode)
  (save-restriction
    (narrow-to-region (point) (point))
    (insert "foo")))

Gives the backtrace:

Debugger entered--Lisp error: (args-out-of-range 1 1)
  get-text-property(1 c-fl-syn-tab)
  c-clear-string-fences()
  #f(compiled-function () #<bytecode 0xbb39fd>)()
  c-after-change(16 19 0)
  insert("foo")
  (save-restriction (narrow-to-region (point) (point)) (insert "foo"))
  (save-current-buffer (set-buffer (get-buffer-create "*test*")) (erase-buffer) (insert "int main()\n{\n  \n}\n") (search-backward "\n}") (c-mode) (save-restriction (narrow-to-region (point) (point)) (insert "foo")))

This is a reduced test case from
https://github.com/joaotavora/eglot/issues/291.

I think the obvious fix is to extend the save-restriction just a bit
further to cover c-clear-string-fences, patch attached.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1544 bytes --]

From 2865541594f18898c234a2ed076879ce2f887693 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Thu, 1 Aug 2019 20:14:32 -0400
Subject: [PATCH] Fix c-after-change in narrowed buffer

* lisp/progmodes/cc-mode.el (c-after-change): Include the
c-clear-string-fences call in the save-restriction, so that it has
access to the widened buffer.
---
 lisp/progmodes/cc-mode.el | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/lisp/progmodes/cc-mode.el b/lisp/progmodes/cc-mode.el
index a5e158933b..9df4224448 100644
--- a/lisp/progmodes/cc-mode.el
+++ b/lisp/progmodes/cc-mode.el
@@ -1989,10 +1989,10 @@ c-after-change
       ;; When `combine-after-change-calls' is used we might get calls
       ;; with regions outside the current narrowing.  This has been
       ;; observed in Emacs 20.7.
-      (unwind-protect
-	  (progn
-	    (c-restore-string-fences (point-min) (point-max))
-	    (save-restriction
+      (save-restriction
+	(unwind-protect
+	    (progn
+	      (c-restore-string-fences (point-min) (point-max))
 	      (save-match-data ; c-recognize-<>-arglists changes match-data
 		(widen)
 
@@ -2032,8 +2032,8 @@ c-after-change
 		(save-excursion
 		  (mapc (lambda (fn)
 			  (funcall fn beg end old-len))
-			c-before-font-lock-functions)))))
-	(c-clear-string-fences))))
+			c-before-font-lock-functions))))
+	  (c-clear-string-fences)))))
   ;; A workaround for syntax-ppss's failure to notice syntax-table text
   ;; property changes.
   (when (fboundp 'syntax-ppss)
-- 
2.11.0


[-- Attachment #3: Type: text/plain, Size: 483 bytes --]



In GNU Emacs 27.0.50 (build 23, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars)
 of 2019-07-30 built on minid
Repository revision: 3a59cc84069376802ba8fd731b524d78db58262c
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.11902000
System Description: Debian GNU/Linux 9 (stretch)

Recent messages:
Error during redisplay: (jit-lock-function 18) signaled (args-out-of-range 1 1)
Continuing.
c-clear-string-fences: Args out of range: 1, 1

bug#36897: 27.0.50; [CC Mode] c-after-change may signal error in narrowed buffer

[Alan Mackenzie]

Hello, Noam.

In article <mailman.507.1564705872.1985.bug-gnu-emacs@gnu.org> you wrote:
> [-- text/plain, encoding 7bit, charset: US-ASCII, 31 lines --]

> Package: emacs, cc-mode

>>From 'emacs -Q', eval the following:

> (with-current-buffer (get-buffer-create "*test*")
>   (erase-buffer)
>   (insert "int main()\n{\n  \n}\n")
>   (search-backward "\n}")
>   (c-mode)
>   (save-restriction
>     (narrow-to-region (point) (point))
>     (insert "foo")))

> Gives the backtrace:

> Debugger entered--Lisp error: (args-out-of-range 1 1)
>   get-text-property(1 c-fl-syn-tab)
>   c-clear-string-fences()
>   #f(compiled-function () #<bytecode 0xbb39fd>)()
>   c-after-change(16 19 0)
>   insert("foo")
>   (save-restriction (narrow-to-region (point) (point)) (insert "foo"))
>   (save-current-buffer (set-buffer (get-buffer-create "*test*")) (erase-buffer) (insert "int main()\n{\n  \n}\n") (search-backward "\n}") (c-mode) (save-restriction (narrow-to-region (point) (point)) (insert "foo")))

Yes, thanks.  I've known about this for around a week, and I have a patch
for it prepared.  I was just giving the OP who reported it to me an extra
day or two to comment on it.

> This is a reduced test case from
> https://github.com/joaotavora/eglot/issues/291.

> I think the obvious fix is to extend the save-restriction just a bit
> further to cover c-clear-string-fences, patch attached.

Yes.  The "same" problem also happened in c-before-change, and my patch
fixes that, too.  (Otherwise, it's pretty much the same as your patch, as
far as c-after-change is concerned.)

I'll commit my patch soon, hopefully today.

[ .... ]

-- 
Alan Mackenzie (Nuremberg, Germany).

bug#36897: 27.0.50; [CC Mode] c-after-change may signal error in narrowed buffer

[Alan Mackenzie]

In article <mailman.530.1564738445.1985.bug-gnu-emacs@gnu.org> I wrote:

[ .... ]

> I'll commit my patch soon, hopefully today.

I've done this, and I'm closing the bug.

[ .... ]

-- 
Alan Mackenzie (Nuremberg, Germany).

bug#36897: 27.0.50; [CC Mode] c-after-change may signal error in narrowed buffer

[Noam Postavsky]

On Fri, 2 Aug 2019 at 07:34, Alan Mackenzie <acm@muc.de> wrote:

> > I'll commit my patch soon, hopefully today.
>
> I've done this, and I'm closing the bug.

Thanks, works here.