unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#15430: 24.3; ido-completing-read is not a replacement for completing-read
@ 2013-09-21  4:44 Noam Postavsky
  2013-09-21  7:19 ` Leo Liu
  2014-12-07 16:21 ` Noam Postavsky
  0 siblings, 2 replies; 3+ messages in thread
From: Noam Postavsky @ 2013-09-21  4:44 UTC (permalink / raw)
  To: 15430

Starting from emacs -Q -nw --eval "(setq completing-read-function
#'ido-completing-read)"

Then M-x gives
ido-set-matches: Wrong type argument: listp, [gnus-put-display-table
message-check-news-body-syntax gnus-make-overlay ido-save-history
message-check-element qp-or-base64 message-insert-wide-reply
help-xref-url-regexp ido-word-matching-substring gnus-set-file-modes
...]

I gather from http://thread.gmane.org/gmane.emacs.devel/134000 that
ido-completing-read is supposed to be wrapped, but there should at
least be some indication of this in the docstring. It certainly
shouldn't claim to be the "Ido replacement for the built-in
`completing-read'."


In GNU Emacs 24.3.1 (x86_64-unknown-linux-gnu, X toolkit)
 of 2013-08-23 on localhost
Configured using:
 `configure '-C' '--with-x-toolkit=lucid'
 '--without-toolkit-scroll-bars' '--with-gif=no' 'CFLAGS=-O2
 -march=native''





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#15430: 24.3; ido-completing-read is not a replacement for completing-read
  2013-09-21  4:44 bug#15430: 24.3; ido-completing-read is not a replacement for completing-read Noam Postavsky
@ 2013-09-21  7:19 ` Leo Liu
  2014-12-07 16:21 ` Noam Postavsky
  1 sibling, 0 replies; 3+ messages in thread
From: Leo Liu @ 2013-09-21  7:19 UTC (permalink / raw)
  To: Noam Postavsky; +Cc: 15430

On 2013-09-21 12:44 +0800, Noam Postavsky wrote:
> Starting from emacs -Q -nw --eval "(setq completing-read-function
> #'ido-completing-read)"
>
> Then M-x gives
> ido-set-matches: Wrong type argument: listp, [gnus-put-display-table
> message-check-news-body-syntax gnus-make-overlay ido-save-history
> message-check-element qp-or-base64 message-insert-wide-reply
> help-xref-url-regexp ido-word-matching-substring gnus-set-file-modes
> ...]

ido-completing-read only accepts a list of strings. At the moment you
have to do the conversion yourself.

Leo





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#15430: 24.3; ido-completing-read is not a replacement for completing-read
  2013-09-21  4:44 bug#15430: 24.3; ido-completing-read is not a replacement for completing-read Noam Postavsky
  2013-09-21  7:19 ` Leo Liu
@ 2014-12-07 16:21 ` Noam Postavsky
  1 sibling, 0 replies; 3+ messages in thread
From: Noam Postavsky @ 2014-12-07 16:21 UTC (permalink / raw)
  To: 15430-done

I probably shouldn't have read "replacement for" as "perfect
replacement for". The docstrings do explain the different type
requirements, so there is no need to keep this open.

Note: for an actual ido completing-read-function see ido-ubiquitous.





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-12-07 16:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-21  4:44 bug#15430: 24.3; ido-completing-read is not a replacement for completing-read Noam Postavsky
2013-09-21  7:19 ` Leo Liu
2014-12-07 16:21 ` Noam Postavsky

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).