unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Thuna <thuna.cing@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 53375@debbugs.gnu.org
Subject: bug#53375: [PATCH] Account for padding and content length in, tabulated-list-widen-current-column
Date: Thu, 20 Jan 2022 21:42:20 +0300	[thread overview]
Message-ID: <CALUXaJhkU1y2rVXk9OrZXwSAvShbfBrAb-e-rSTuBNLTe-D9Tg@mail.gmail.com> (raw)
In-Reply-To: <87r192xz8f.fsf@gnus.org>

[-- Attachment #1: Type: text/plain, Size: 1931 bytes --]

  >> This patch should solve the issue however it relies on
 >> `tabulated-list-get-entry' which means it fails to work if the
 >> `tabulated-list-entry' property is not set properly.  I am unsure if
 >> this should be considered a bug on the tabulated-list end or not.
 >
 > That function is supposed to give reliable results, so if there are
 > modes it doesn't work in, that sounds like a bug.

In that case debbugs itself needs a fix.  It is possible that other
tabulated-list derived modes will fail in a similar way so maybe a
checkup is needed?

 > This change was small enough to apply without assigning copyright to the
 > FSF, but for future patches you want to submit, it might make sense to
 > get the paperwork started now, so that subsequent patches can be applied
 > speedily. Would you be willing to sign such paperwork?

I am willing to sign the paperwork although I know neither how nor what
it entails so some help would be appreciated.

On Thu, Jan 20, 2022 at 5:23 PM Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Thuna <thuna.cing@gmail.com> writes:
>
> > This patch should solve the issue however it relies on
> > `tabulated-list-get-entry' which means it fails to work if the
> > `tabulated-list-entry' property is not set properly.  I am unsure if
> > this should be considered a bug on the tabulated-list end or not.
>
> That function is supposed to give reliable results, so if there are
> modes it doesn't work in, that sounds like a bug.
>
> Anyway, the patch looks good to me, so I've pushed it to Emacs 29.
>
> This change was small enough to apply without assigning copyright to the
> FSF, but for future patches you want to submit, it might make sense to
> get the paperwork started now, so that subsequent patches can be applied
> speedily. Would you be willing to sign such paperwork?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no
>

[-- Attachment #2: Type: text/html, Size: 2864 bytes --]

  reply	other threads:[~2022-01-20 18:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-19 21:40 bug#53375: [PATCH] Account for padding and content length in, tabulated-list-widen-current-column Thuna
2022-01-20 14:23 ` Lars Ingebrigtsen
2022-01-20 18:42   ` Thuna [this message]
2022-01-21  9:27     ` Lars Ingebrigtsen
2022-01-23 14:42 ` bug#53375: [PATCH] Correct wrong comparison operation in previous patch Thuna
2022-01-23 14:47   ` Lars Ingebrigtsen
2022-01-23 14:52     ` Thuna
2022-01-23 14:56       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALUXaJhkU1y2rVXk9OrZXwSAvShbfBrAb-e-rSTuBNLTe-D9Tg@mail.gmail.com \
    --to=thuna.cing@gmail.com \
    --cc=53375@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).