From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thuna Newsgroups: gmane.emacs.bugs Subject: bug#53375: [PATCH] Account for padding and content length in, tabulated-list-widen-current-column Date: Thu, 20 Jan 2022 21:42:20 +0300 Message-ID: References: <87r192xz8f.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000079224505d607dd89" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13592"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53375@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 20 23:42:05 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAg85-0003PB-4u for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Jan 2022 23:42:05 +0100 Original-Received: from localhost ([::1]:35030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nAg83-0002xm-V2 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Jan 2022 17:42:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51046) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAcOt-0008P0-Dg for bug-gnu-emacs@gnu.org; Thu, 20 Jan 2022 13:43:11 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38043) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAcOk-0007VA-Bc for bug-gnu-emacs@gnu.org; Thu, 20 Jan 2022 13:43:10 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nAcOk-0002nb-Aj for bug-gnu-emacs@gnu.org; Thu, 20 Jan 2022 13:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thuna Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jan 2022 18:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53375 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch moreinfo Original-Received: via spool by 53375-submit@debbugs.gnu.org id=B53375.164270416110719 (code B ref 53375); Thu, 20 Jan 2022 18:43:02 +0000 Original-Received: (at 53375) by debbugs.gnu.org; 20 Jan 2022 18:42:41 +0000 Original-Received: from localhost ([127.0.0.1]:59179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAcOO-0002mo-Kl for submit@debbugs.gnu.org; Thu, 20 Jan 2022 13:42:40 -0500 Original-Received: from mail-lf1-f49.google.com ([209.85.167.49]:34381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAcOM-0002mc-OW for 53375@debbugs.gnu.org; Thu, 20 Jan 2022 13:42:39 -0500 Original-Received: by mail-lf1-f49.google.com with SMTP id p27so25185724lfa.1 for <53375@debbugs.gnu.org>; Thu, 20 Jan 2022 10:42:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KZiK0z4e/oYqBHefAXZJhGSQucwvvkZhNp6i3O19PsQ=; b=OmhJu5OXkRusKCyL/ywDOB2uGWcP3Zof2LSYCZjLMtZtA+9OWBW33/Zmg476MX3i7T //QvyVYPkvgscW2AkhlpnZYOEKdMJhRG5DnbTQocgqwWt0xqQUhYFrgKZHneFa4AA1wo hBPATSiNMrlWtNJnrsa/FiyCRGksi5qufkc2DzVQ3kk69zorjq+xsJLYoaMbzP0HNFtZ gs7xH77/tBleN18VuYefdNU89VJ7GTItUmbRdHS5KQYur0L5qJeE3lJ4bAwEJT+OJ1vS U8i1gJ9t5sOhldlotGFO8em8Z3hX94MEgDQ5rjojNZX9OTLgcr/2eu0v/kaVbK4ytUs+ s3TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KZiK0z4e/oYqBHefAXZJhGSQucwvvkZhNp6i3O19PsQ=; b=EbXyxyb4139hBPJ0fWwqZRDMIh6FO9x1jWfIYiJ6CSG89QcM9Kf3QhTeWR4g3wnXBq pD8MNTi4Y+u0V7aDkM1obc1+GM76uTv/HwM8+J/PfFDT+ZMlrgYxBbEvGF3ovkzy/MoN Z+tTu9N2GG5XrjqhxzzpiYsdrFFr6NZyGTpI1rbHT757iEbr/uMrwp/FqzTbdnQLGTvi mXPyaDKmBqEIMlB5VDY7U2fjZgBqsHVtlK3C3eANEMphiXtxshNTPHYqYpQZF2GRbp86 9FhYl+6sd3A9THLbeP6CbrP38XJ7C270n8QBR+sZ3qGG+PA0GE0RjneftsFPTO9Eh4b0 poVA== X-Gm-Message-State: AOAM533Ua11E76tAWPuXETW2EEdXWrLq64S95xYesU4iQD16joSZ4V3q DM+Xfwyos0BTbCODgf03hCEoHbeewLcrW9uHrLE= X-Google-Smtp-Source: ABdhPJxFTHuyl7JjTHo4yzr+pYaVH+kLzSPfF9KQmX9adJJITJEUqyGVq3osKNN5f06mr1t8inTGdrzxcbTQ5sMnH+o= X-Received: by 2002:a05:6512:3c85:: with SMTP id h5mr338824lfv.273.1642704152370; Thu, 20 Jan 2022 10:42:32 -0800 (PST) In-Reply-To: <87r192xz8f.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224702 Archived-At: --00000000000079224505d607dd89 Content-Type: text/plain; charset="UTF-8" >> This patch should solve the issue however it relies on >> `tabulated-list-get-entry' which means it fails to work if the >> `tabulated-list-entry' property is not set properly. I am unsure if >> this should be considered a bug on the tabulated-list end or not. > > That function is supposed to give reliable results, so if there are > modes it doesn't work in, that sounds like a bug. In that case debbugs itself needs a fix. It is possible that other tabulated-list derived modes will fail in a similar way so maybe a checkup is needed? > This change was small enough to apply without assigning copyright to the > FSF, but for future patches you want to submit, it might make sense to > get the paperwork started now, so that subsequent patches can be applied > speedily. Would you be willing to sign such paperwork? I am willing to sign the paperwork although I know neither how nor what it entails so some help would be appreciated. On Thu, Jan 20, 2022 at 5:23 PM Lars Ingebrigtsen wrote: > Thuna writes: > > > This patch should solve the issue however it relies on > > `tabulated-list-get-entry' which means it fails to work if the > > `tabulated-list-entry' property is not set properly. I am unsure if > > this should be considered a bug on the tabulated-list end or not. > > That function is supposed to give reliable results, so if there are > modes it doesn't work in, that sounds like a bug. > > Anyway, the patch looks good to me, so I've pushed it to Emacs 29. > > This change was small enough to apply without assigning copyright to the > FSF, but for future patches you want to submit, it might make sense to > get the paperwork started now, so that subsequent patches can be applied > speedily. Would you be willing to sign such paperwork? > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no > --00000000000079224505d607dd89 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

=C2=A0 >> This patch sho= uld solve the issue however it relies on
=C2=A0>> `tabulated-list-get-entry' which means it fails to work = if the
=C2=A0>> `tabulated-list-entry' property is not set properly.=C2= =A0 I am unsure if
=C2=A0>> this should be considered a bug on the tabulated-list end or= not.
=C2=A0>
=C2=A0> That function is supposed to give reliable results, so if there = are
=C2=A0> modes it doesn't work in, that sounds like a bug.

In that case debbugs itself needs a fix.=C2=A0 It is possible that other tabulated-list derived modes will fail in a similar way so maybe a
checkup is needed?

=C2=A0> This change was small enough to apply without assigning copyrigh= t to the
=C2=A0> FSF, but for future patches you want to submit, it might make se= nse to
=C2=A0> get the paperwork started now, so that subsequent patches can be= applied
=C2=A0> speedily. Would you be willing to sign such paperwork?

I am willing to sign the paperwork although I know neither how nor what
it entails so some help would be appreciated.

On Thu, Jan 20, 20= 22 at 5:23 PM Lars Ingebrigtsen <larsi= @gnus.org> wrote:
Thuna <thuna.cing@gmail.com> writes:

> This patch should solve the issue however it relies on
> `tabulated-list-get-entry' which means it fails to work if the
> `tabulated-list-entry' property is not set properly.=C2=A0 I am un= sure if
> this should be considered a bug on the tabulated-list end or not.

That function is supposed to give reliable results, so if there are
modes it doesn't work in, that sounds like a bug.

Anyway, the patch looks good to me, so I've pushed it to Emacs 29.

This change was small enough to apply without assigning copyright to the FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied speedily. Would you be willing to sign such paperwork?

--
(domestic pets only, the antidote for overdose, milk.)
=C2=A0 =C2=A0bloggy blog: http://lars.ingebrigtsen.no
--00000000000079224505d607dd89--