unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Max Brieiev <max.brieiev@gmail.com>, 48452@debbugs.gnu.org
Subject: bug#48452: 28.0.50; flymake for elisp does not respect `load-path`
Date: Fri, 22 Jul 2022 22:09:32 +0100	[thread overview]
Message-ID: <CALDnm53Lf7UWKddTEC61+ey-hU-M7RVBbCtu-Ncc-TU9TXqCzQ@mail.gmail.com> (raw)
In-Reply-To: <87r12d9b8f.fsf@gnus.org>

[-- Attachment #1: Type: text/plain, Size: 1753 bytes --]

On Fri, Jul 22, 2022, 20:52 Lars Ingebrigtsen <larsi@gnus.org> wrote:

> João Távora <joaotavora@gmail.com> writes:
>
> > Right.  Adding anything to the load path is "dangerous".  The default
> > "./" is a good compromise, as it enables developing packages with
> > multiple .el files that require each other in the same dir, which is a
> > very common thing IME.
>
> I'm not sure that's a good compromise at all -- the user has surely set
> up the correct load path to use, and overriding that with "./" sounds
> like a recipe for disaster.
>

We seem to be regressing. I thought we had established that the subprocess
elisp load path has no useful relation to the load path of the session.
This is how one achieves consistency  of diagnostics in the same file, but
across sessions.

I've never had disaster struck because of load paths. What disaster are you
thinking about?

> Here's a very minimally tested patch:
>
> [...]
>
> > +(defcustom elisp-flymake-byte-compile-use-elpa-dirs nil
> > +  "If non-nil, add ELPA package dirs to elisp Flymake load path."
> > +  :type 'boolean
> > +  :group 'lisp)
>
> I think it would make more sense to have an option to use the load path
> from the current Emacs incantation also in the flymake Emacsen.
>

For reasons already explained, i completely disagree. My proposal would fix
exactly this bug report. But you can add other options, as long as you
don't break the current default. Do you use Flymake mode for elisp? I've
been using it for many years, and the current default is very good. I don't
use ELPA or develop against it, though, as the bug reporter fired. We could
also see what Flycheck does in this regard. It also has an elisp checker.

João

>

[-- Attachment #2: Type: text/html, Size: 2775 bytes --]

  reply	other threads:[~2022-07-22 21:09 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-15 20:46 bug#48452: 28.0.50; flymake for elisp does not respect `load-path` Max Brieiev
2022-07-13 11:47 ` Lars Ingebrigtsen
2022-07-13 13:47   ` Max Brieiev
2022-07-13 13:57     ` Lars Ingebrigtsen
2022-07-13 16:24       ` Max Brieiev
2022-07-14 17:15         ` Lars Ingebrigtsen
2022-07-14 20:29           ` João Távora
2022-07-15  9:46             ` Lars Ingebrigtsen
2022-07-15 10:03               ` João Távora
2022-07-16 10:12                 ` Lars Ingebrigtsen
2022-07-18 19:17                   ` João Távora
2022-07-22 19:52                     ` Lars Ingebrigtsen
2022-07-22 21:09                       ` João Távora [this message]
2022-07-22 21:12                         ` Lars Ingebrigtsen
2022-07-22 21:46                           ` João Távora
2022-07-23  5:50                             ` Lars Ingebrigtsen
2022-07-23  9:24                               ` João Távora
2022-07-23 14:26                                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-23 17:45                                   ` João Távora
2022-07-23 17:55                                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-24  9:18                                     ` Lars Ingebrigtsen
2022-07-24  9:57                                       ` João Távora
2022-07-23 15:05                                 ` Max Brieiev
2022-07-23 17:16                                   ` João Távora
2022-07-15 11:53             ` Max Brieiev
2022-07-14  9:22       ` Max Brieiev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALDnm53Lf7UWKddTEC61+ey-hU-M7RVBbCtu-Ncc-TU9TXqCzQ@mail.gmail.com \
    --to=joaotavora@gmail.com \
    --cc=48452@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=max.brieiev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).