From: "João Távora" <joaotavora@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Max Brieiev <max.brieiev@gmail.com>, 48452@debbugs.gnu.org
Subject: bug#48452: 28.0.50; flymake for elisp does not respect `load-path`
Date: Mon, 18 Jul 2022 20:17:26 +0100 [thread overview]
Message-ID: <87sfmy1b95.fsf@gmail.com> (raw)
In-Reply-To: <87fsj1tlgn.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 16 Jul 2022 12:12:40 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> João Távora <joaotavora@gmail.com> writes:
> Speaking of which, I was surprised that flymake adds "./" to the load
> path -- we never use that in real Emacsen exactly because of security
> considerations (we don't want to pick up stray files when working under
> /tmp/, for instance).
Right. Adding anything to the load path is "dangerous". The default
"./" is a good compromise, as it enables developing packages with
multiple .el files that require each other in the same dir, which is a
very common thing IME.
>> Anyway, because the directories under ~/.emacs.d/elpa are somewhat special
>> and/or security-vetted it _could_ make sense to add them to the default
>> value of the variable. This would amount to more or less the same as
>> calling the underlying process with `-f package-initialize` I think.
>>
>> But I'm still not sure this should be the default, or merely an option to
>> the flymake-elisp-byte-compile backend. I think the second is safer.
>
> An option here would be nice, yes.
Here's a very minimally tested patch:
diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el
index 0c4a9bfdbe..7e1141acf1 100644
--- a/lisp/progmodes/elisp-mode.el
+++ b/lisp/progmodes/elisp-mode.el
@@ -2119,6 +2119,11 @@ elisp-flymake-byte-compile-load-path
(dolist (path x t) (unless (stringp path)
(throw 'tag nil)))))))
+(defcustom elisp-flymake-byte-compile-use-elpa-dirs nil
+ "If non-nil, add ELPA package dirs to elisp Flymake load path."
+ :type 'boolean
+ :group 'lisp)
+
;;;###autoload
(defun elisp-flymake-byte-compile (report-fn &rest _args)
"A Flymake backend for elisp byte compilation.
@@ -2146,6 +2151,8 @@ elisp-flymake-byte-compile
;; "--eval" "(setq load-prefer-newer t)" ; for testing
,@(mapcan (lambda (path) (list "-L" path))
elisp-flymake-byte-compile-load-path)
+ ,@(when elisp-flymake-byte-compile-use-elpa-dirs
+ `("-f" "package-initialize"))
"-f" "elisp-flymake--batch-compile-for-flymake"
,temp-file)
:connection-type 'pipe
next prev parent reply other threads:[~2022-07-18 19:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 20:46 bug#48452: 28.0.50; flymake for elisp does not respect `load-path` Max Brieiev
2022-07-13 11:47 ` Lars Ingebrigtsen
2022-07-13 13:47 ` Max Brieiev
2022-07-13 13:57 ` Lars Ingebrigtsen
2022-07-13 16:24 ` Max Brieiev
2022-07-14 17:15 ` Lars Ingebrigtsen
2022-07-14 20:29 ` João Távora
2022-07-15 9:46 ` Lars Ingebrigtsen
2022-07-15 10:03 ` João Távora
2022-07-16 10:12 ` Lars Ingebrigtsen
2022-07-18 19:17 ` João Távora [this message]
2022-07-22 19:52 ` Lars Ingebrigtsen
2022-07-22 21:09 ` João Távora
2022-07-22 21:12 ` Lars Ingebrigtsen
2022-07-22 21:46 ` João Távora
2022-07-23 5:50 ` Lars Ingebrigtsen
2022-07-23 9:24 ` João Távora
2022-07-23 14:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-23 17:45 ` João Távora
2022-07-23 17:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-24 9:18 ` Lars Ingebrigtsen
2022-07-24 9:57 ` João Távora
2022-07-23 15:05 ` Max Brieiev
2022-07-23 17:16 ` João Távora
2022-07-15 11:53 ` Max Brieiev
2022-07-14 9:22 ` Max Brieiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfmy1b95.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=48452@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=max.brieiev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).