unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Philip K." <philipk@posteo.net>, 62417@debbugs.gnu.org
Subject: bug#62417: ; Regression: 59ecf25fc860 is the first bad commit
Date: Sat, 25 Mar 2023 13:56:40 +0000	[thread overview]
Message-ID: <CALDnm52sEAiHBJEH6bp8MeeaPMkXRFuL4A7wNES5PokmWXdMUg@mail.gmail.com> (raw)
In-Reply-To: <83cz4xc6hg.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]

On Sat, Mar 25, 2023, 13:20 Eli Zaretskii <eliz@gnu.org> wrote:

> > From: João Távora <joaotavora@gmail.com>
> > Date: Sat, 25 Mar 2023 13:04:24 +0000
> > Cc: "Philip K." <philipk@posteo.net>, 62417@debbugs.gnu.org
> >
> > On Sat, Mar 25, 2023, 12:55 Eli Zaretskii <eliz@gnu.org> wrote:.
> >
> >  >
> >  > So it is most clearly a regression.
> >
> >  There's something missing in the above description, since
> >  buffer-match-p accepts a function as its CONDITION argument, and calls
> >  that function with the buffer and ACTION.  So it sounds like code
> >  written for Emacs 28 should still work.  What is missing here that
> >  explains the breakage?
> >
> > As I highlighted, Emacs used to call such functions with a buffer _name_
> and an action. Now it calls them
> > with a buffer _object_ and an action.
>
> No, buffer-match-p accepts a buffer object _or_ a buffer name as its
> first argument.
>

Second argument.

>
But you're confused: this is not about buffer-match-p's arguments. It's
about the arguments to the function that you may also pass to
buffer-match-p in it's first CONDITION argument. Use my simple recipe in
both Emacs 28 and 29.

João

[-- Attachment #2: Type: text/html, Size: 2421 bytes --]

  reply	other threads:[~2023-03-25 13:56 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24 13:16 bug#62417: 30.0.50; Regression: 59ecf25fc860 is the first bad commit João Távora
2023-03-24 15:22 ` João Távora
2023-03-24 16:05   ` Philip Kaludercic
2023-03-24 16:07     ` João Távora
2023-03-24 19:48       ` bug#62417: ; " João Távora
2023-03-25 12:55         ` Eli Zaretskii
2023-03-25 13:04           ` João Távora
2023-03-25 13:20             ` Eli Zaretskii
2023-03-25 13:56               ` João Távora [this message]
2023-03-25 14:13                 ` Eli Zaretskii
2023-03-25 14:15                   ` João Távora
2023-03-26 20:22                   ` João Távora
2023-03-26 21:23                     ` Philip Kaludercic
2023-03-27  2:24                     ` Eli Zaretskii
2023-03-27 12:06                       ` João Távora
2023-03-27 13:49                         ` Eli Zaretskii
2023-03-27 14:08                           ` João Távora
2023-03-27 15:20                             ` Eli Zaretskii
2023-03-27 16:33                               ` Eli Zaretskii
2023-03-27 16:42                                 ` João Távora
2023-03-27 17:09                                   ` Eli Zaretskii
2023-03-27 19:26                                     ` Philip Kaludercic
2023-03-28 11:11                                       ` Eli Zaretskii
2023-03-27 16:38                               ` João Távora
2023-03-25 13:17           ` Philip Kaludercic
2023-03-25 13:29             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALDnm52sEAiHBJEH6bp8MeeaPMkXRFuL4A7wNES5PokmWXdMUg@mail.gmail.com \
    --to=joaotavora@gmail.com \
    --cc=62417@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).