From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62417: ; Regression: 59ecf25fc860 is the first bad commit Date: Sat, 25 Mar 2023 13:56:40 +0000 Message-ID: References: <87sfducmrc.fsf@gmail.com> <87o7oicgy4.fsf@gmail.com> <87wn365e3t.fsf@posteo.net> <87pm8yaq24.fsf_-_@gmail.com> <83fs9tc7o9.fsf@gnu.org> <83cz4xc6hg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000be1ea805f7b9e14f" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17801"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Philip K." , 62417@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 25 14:58:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pg4PU-0004LE-3Q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Mar 2023 14:58:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pg4PF-0003MB-Pt; Sat, 25 Mar 2023 09:58:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg4PE-0003Ls-CL for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 09:58:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pg4PD-0003hK-N8 for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 09:58:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pg4PC-0007fh-Hr for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 09:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 13:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62417 X-GNU-PR-Package: emacs Original-Received: via spool by 62417-submit@debbugs.gnu.org id=B62417.167975262429420 (code B ref 62417); Sat, 25 Mar 2023 13:58:02 +0000 Original-Received: (at 62417) by debbugs.gnu.org; 25 Mar 2023 13:57:04 +0000 Original-Received: from localhost ([127.0.0.1]:43116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg4OG-0007eS-6U for submit@debbugs.gnu.org; Sat, 25 Mar 2023 09:57:04 -0400 Original-Received: from mail-oa1-f53.google.com ([209.85.160.53]:36387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg4OE-0007dy-AE for 62417@debbugs.gnu.org; Sat, 25 Mar 2023 09:57:02 -0400 Original-Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-17ebba88c60so4674106fac.3 for <62417@debbugs.gnu.org>; Sat, 25 Mar 2023 06:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679752617; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WuWjCWY5NSmEhIUWTDHJfDTVdcX6N+hojX3xr7FlO0c=; b=aBnhrwDSttSAUtbpEXKiY/GGQzLcXQcHP5gY46sYSvczz/DLYyEkMXhaIjKpBB5ox5 8BksvXfmSVdyP1QF3gRbUUNuEAIocVn5+FBQQc0U9xPdZNryXHs10OmB7bhOl9S34T6Y i+Tqr+2Pw1vDNggMOTSJj4mkJs2vAJeWDYTUOZjaX2sSL54g47q7fjh8dj+93xImPYH5 N0zbkTGmNtJ3sTscSUKFnaH1pc0kRCrURwhZgbZDPYlmVcPg51qvXKd3uEXXwiEFwGiM L454OfEBwM5BaNA2Y8IpltGHwsSWxAk+plAps+iBJT3yeQu1kVGyu+y5UZi4o8ieYhWL YTKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679752617; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WuWjCWY5NSmEhIUWTDHJfDTVdcX6N+hojX3xr7FlO0c=; b=Is3yLv5JXPFOysU5+YsprU2MEmkPvzyYfiDXR+mFv12ZBUt0pmbrSISKjriXUa3hTN fLLG74YaTMkavp5fPWfwTFncA+tNyuL21WLJxVM8ud61DSZR696VrSXpslhRhuoz4P6O hzQkG28bDY/6vvbuGEDdJgI5iwuSUmKh39VsivndxnuZyaBZm8++X0DXevK6VLjdAEvf d5XKFNgYxRsK5PrQ9dNc7hRxkYarHoqPjmyvh24D2bxjnwkE0ivqogTvb8Bazs872QId BiZKZtrhNPRB5cNOx3C5gfp2l8iXFy2QCh5T+5ux7vNafiHSacIN+Ll4cKeevb2zt4dU 7csQ== X-Gm-Message-State: AO0yUKUoKG8IAXnyzm6pMVqOiRg2XAI79bcoL6d4jWO0Cwm4gvFRLiar 8kahI7cTT/wAmrpBCr4DSTNrrUjWLLtQGqjTRa0= X-Google-Smtp-Source: AK7set/Zw8YVzVMOFNvwi7ZrUW9SyDh6/sVLWbbdUyoByA3XZ7WfrxtkcyOmfMO5edGr2WRX3hUkyWGea/25jx+SuqY= X-Received: by 2002:a05:687c:198:b0:17e:3201:41b0 with SMTP id yo24-20020a05687c019800b0017e320141b0mr2014454oab.5.1679752611895; Sat, 25 Mar 2023 06:56:51 -0700 (PDT) In-Reply-To: <83cz4xc6hg.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258572 Archived-At: --000000000000be1ea805f7b9e14f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Mar 25, 2023, 13:20 Eli Zaretskii wrote: > > From: Jo=C3=A3o T=C3=A1vora > > Date: Sat, 25 Mar 2023 13:04:24 +0000 > > Cc: "Philip K." , 62417@debbugs.gnu.org > > > > On Sat, Mar 25, 2023, 12:55 Eli Zaretskii wrote:. > > > > > > > > So it is most clearly a regression. > > > > There's something missing in the above description, since > > buffer-match-p accepts a function as its CONDITION argument, and calls > > that function with the buffer and ACTION. So it sounds like code > > written for Emacs 28 should still work. What is missing here that > > explains the breakage? > > > > As I highlighted, Emacs used to call such functions with a buffer _name= _ > and an action. Now it calls them > > with a buffer _object_ and an action. > > No, buffer-match-p accepts a buffer object _or_ a buffer name as its > first argument. > Second argument. > But you're confused: this is not about buffer-match-p's arguments. It's about the arguments to the function that you may also pass to buffer-match-p in it's first CONDITION argument. Use my simple recipe in both Emacs 28 and 29. Jo=C3=A3o --000000000000be1ea805f7b9e14f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Mar 25, 2023, 13:20 Eli Zaretskii <eliz@gnu.org> wrote:
> From: Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com>= ;
> Date: Sat, 25 Mar 2023 13:04:24 +0000
> Cc: "Philip K." <philipk@posteo.net>, 62417@deb= bugs.gnu.org
>
> On Sat, Mar 25, 2023, 12:55 Eli Zaretskii <eliz@gnu.org> wrote:. >
>=C2=A0 >
>=C2=A0 > So it is most clearly a regression.
>
>=C2=A0 There's something missing in the above description, since >=C2=A0 buffer-match-p accepts a function as its CONDITION argument, and= calls
>=C2=A0 that function with the buffer and ACTION.=C2=A0 So it sounds lik= e code
>=C2=A0 written for Emacs 28 should still work.=C2=A0 What is missing he= re that
>=C2=A0 explains the breakage?
>
> As I highlighted, Emacs used to call such functions with a buffer _nam= e_ and an action. Now it calls them
> with a buffer _object_ and an action.

No, buffer-match-p accepts a buffer object _or_ a buffer name as its
first argument.

Second argument.

But you're confused: this is not abou= t buffer-match-p's arguments. It's about the arguments to the funct= ion that you may also pass to buffer-match-p in it's first CONDITION ar= gument. Use my simple recipe in both Emacs 28 and 29.

Jo=C3=A3o


--000000000000be1ea805f7b9e14f--