* bug#38131: 27.0.50; [PATCH] lisp/icomplete.el: put text property when text is not nil
@ 2019-11-08 13:17 Andrii Kolomoiets
2019-11-08 18:03 ` Pankaj Jangid
0 siblings, 1 reply; 6+ messages in thread
From: Andrii Kolomoiets @ 2019-11-08 13:17 UTC (permalink / raw)
To: 38131
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
With commit 5761a1a3939e23d8e8c725241dd9398a12f191b0
1. emacs -Q
2. M-x icomplete-mode RET
3. M-x icomplete-mode
After typing last "e" there are error:
Error in post-command-hook (icomplete-post-command-hook):
(args-out-of-range -1 1)
[-- Attachment #2: 0001-lisp-icomplete.el-put-text-property-when-text-is-not.patch --]
[-- Type: application/octet-stream, Size: 1021 bytes --]
From 36d0ac2a7d8cbeedc22bf584f630498bb1f92a94 Mon Sep 17 00:00:00 2001
From: Andrii Kolomoiets <andreyk.mad@gmail.com>
Date: Fri, 8 Nov 2019 15:08:13 +0200
Subject: [PATCH] * lisp/icomplete.el: put text property when text is not nil
* lisp/icomplete.el (icomplete-completions): Don't highlight the center
part of determ if determ is nil.
diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index a7f9086d82..e71f8e58dd 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -673,8 +673,9 @@ icomplete-completions
(mapconcat 'identity prospects icomplete-separator)
(and limit (concat icomplete-separator ellipsis))
"}")
- (put-text-property 1 (1- (length determ))
- 'face 'icomplete-first-match determ)
+ (when determ
+ (put-text-property 1 (1- (length determ))
+ 'face 'icomplete-first-match determ))
(concat determ " [Matched]"))))))
;;; Iswitchb compatibility
--
2.15.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#38131: 27.0.50; [PATCH] lisp/icomplete.el: put text property when text is not nil
2019-11-08 13:17 bug#38131: 27.0.50; [PATCH] lisp/icomplete.el: put text property when text is not nil Andrii Kolomoiets
@ 2019-11-08 18:03 ` Pankaj Jangid
2019-11-09 1:42 ` Juanma Barranquero
0 siblings, 1 reply; 6+ messages in thread
From: Pankaj Jangid @ 2019-11-08 18:03 UTC (permalink / raw)
To: Andrii Kolomoiets; +Cc: 38131
Andrii Kolomoiets <andreyk.mad@gmail.com> writes:
> With commit 5761a1a3939e23d8e8c725241dd9398a12f191b0
> 1. emacs -Q
> 2. M-x icomplete-mode RET
> 3. M-x icomplete-mode
>
> After typing last "e" there are error:
>
> Error in post-command-hook (icomplete-post-command-hook):
> (args-out-of-range -1 1)
I just verified it. The error is occurring in my build as well. Commit
0a51c7012268d764ac4282b5969e4901ebeabfdb.
Regards,
--
Pankaj Jangid
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#38131: 27.0.50; [PATCH] lisp/icomplete.el: put text property when text is not nil
2019-11-08 18:03 ` Pankaj Jangid
@ 2019-11-09 1:42 ` Juanma Barranquero
2019-11-09 11:51 ` João Távora
0 siblings, 1 reply; 6+ messages in thread
From: Juanma Barranquero @ 2019-11-09 1:42 UTC (permalink / raw)
To: Pankaj Jangid; +Cc: 38131, João Távora, Andrii Kolomoiets
[-- Attachment #1: Type: text/plain, Size: 412 bytes --]
Apparently caused by this patch:
commit 5761a1a3939e23d8e8c725241dd9398a12f191b0
Author: João Távora <joaotavora@gmail.com>
Date: 2019-11-08 00:11:34 +0000
Nudge icomplete-mode a little closer to fido-mode
* lisp/icomplete.el (icomplete-completions): Don't use ellipsis when
truncating determ in fido-mode. Highlight the center part of
determ with icomplete-first-match.
[-- Attachment #2: Type: text/html, Size: 525 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#38131: 27.0.50; [PATCH] lisp/icomplete.el: put text property when text is not nil
2019-11-09 1:42 ` Juanma Barranquero
@ 2019-11-09 11:51 ` João Távora
2019-11-09 14:58 ` João Távora
0 siblings, 1 reply; 6+ messages in thread
From: João Távora @ 2019-11-09 11:51 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: Pankaj Jangid, 38131, Andrii Kolomoiets
Sorry about that, will fix it ASAP.
Thanks for the stable reproduction recipe (I thought I saw
it but it was elusive).
João
On Sat, Nov 9, 2019 at 1:43 AM Juanma Barranquero <lekktu@gmail.com> wrote:
>
> Apparently caused by this patch:
>
> commit 5761a1a3939e23d8e8c725241dd9398a12f191b0
> Author: João Távora <joaotavora@gmail.com>
> Date: 2019-11-08 00:11:34 +0000
>
> Nudge icomplete-mode a little closer to fido-mode
>
> * lisp/icomplete.el (icomplete-completions): Don't use ellipsis when
> truncating determ in fido-mode. Highlight the center part of
> determ with icomplete-first-match.
--
João Távora
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#38131: 27.0.50; [PATCH] lisp/icomplete.el: put text property when text is not nil
2019-11-09 11:51 ` João Távora
@ 2019-11-09 14:58 ` João Távora
2019-11-09 15:31 ` Juanma Barranquero
0 siblings, 1 reply; 6+ messages in thread
From: João Távora @ 2019-11-09 14:58 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: Pankaj Jangid, 38131, Andrii Kolomoiets
I've reverted that commit. It had other problems. I will try again
soon to find some other way to make fido-mode behave closer to
ido-mode. This can be closed, I think.
João
On Sat, Nov 9, 2019 at 11:51 AM João Távora <joaotavora@gmail.com> wrote:
>
> Sorry about that, will fix it ASAP.
>
> Thanks for the stable reproduction recipe (I thought I saw
> it but it was elusive).
>
> João
>
> On Sat, Nov 9, 2019 at 1:43 AM Juanma Barranquero <lekktu@gmail.com> wrote:
> >
> > Apparently caused by this patch:
> >
> > commit 5761a1a3939e23d8e8c725241dd9398a12f191b0
> > Author: João Távora <joaotavora@gmail.com>
> > Date: 2019-11-08 00:11:34 +0000
> >
> > Nudge icomplete-mode a little closer to fido-mode
> >
> > * lisp/icomplete.el (icomplete-completions): Don't use ellipsis when
> > truncating determ in fido-mode. Highlight the center part of
> > determ with icomplete-first-match.
>
>
>
> --
> João Távora
--
João Távora
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-09 15:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-08 13:17 bug#38131: 27.0.50; [PATCH] lisp/icomplete.el: put text property when text is not nil Andrii Kolomoiets
2019-11-08 18:03 ` Pankaj Jangid
2019-11-09 1:42 ` Juanma Barranquero
2019-11-09 11:51 ` João Távora
2019-11-09 14:58 ` João Távora
2019-11-09 15:31 ` Juanma Barranquero
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).