From: "João Távora" <joaotavora@gmail.com>
To: "Rudolf Adamkovič" <salutis@me.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 51437@debbugs.gnu.org
Subject: bug#51437: 29.0.50; The annotated example of a complete working Flymake backend does not work with narrowed buffers
Date: Sun, 31 Oct 2021 09:26:16 +0000 [thread overview]
Message-ID: <CALDnm52hqwZPPpZRPcEs3L+brDF=nj+qs2iKunWD9nrOr6sLCg@mail.gmail.com> (raw)
In-Reply-To: <m25yteqknx.fsf@me.com>
[-- Attachment #1: Type: text/plain, Size: 1826 bytes --]
This is starting to sound like a more generic Flymake limitation/bug than a
documentation bug. I'll have a look when I get home.
Have you experimented with the 'region' arg when reporting back
diagnostics? Also you can have a look at how the Elisp backend does it? I
think, though I am not sure, that it works with narrowed buffers.
By the way, Flymake for spell checking is a great idea. Is your backend
available somewhere?
João
On Sat, Oct 30, 2021, 22:15 Rudolf Adamkovič <salutis@me.com> wrote:
> João Távora <joaotavora@gmail.com> writes:
>
> > I can't test right now, but maybe Rudolf can. If it works then
> > I'd say commit it.
>
> The patch fixes the errors, but it also causes troubles. Say I use Flymake
> to check on my English grammar, and say I have 10 errors in my text. I
> narrow down to a part with 5 errors, fix them, write some new text, and
> after a while, I widen the buffer. I look through my final text, see that
> Flymake reports 0 errors, and submit my work to someone. Well, I submitted
> 5 errors, because Flymake did not re-check when I widened the buffer.
> Further, Flymake might report incorrect data on narrow. In the example
> above, it would have said 10 errors after narrowing and then 5 for the same
> narrowed content on the next re-check. Thus, we should either always check
> the entire content of the buffer, or we should recheck on narrow and widen,
> potentially wasting bandwidth for online checks and the like.
>
> Rudy
>
> --
> "'Contrariwise,' continued Tweedledee, 'if it was so, it might be; and if
> it were so, it would be; but as it isn't, it ain't. That's logic.'" --
> Lewis Carroll, Through the Looking Glass
>
> Rudolf Adamkovič <salutis@me.com>
> Studenohorská 25
> 84103 Bratislava
> Slovakia
>
> [he/him]
>
[-- Attachment #2: Type: text/html, Size: 2433 bytes --]
next prev parent reply other threads:[~2021-10-31 9:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 13:01 bug#51437: 29.0.50; The annotated example of a complete working Flymake backend does not work with narrowed buffers Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-29 13:35 ` Lars Ingebrigtsen
2021-10-29 18:07 ` João Távora
2021-10-30 21:15 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-31 9:26 ` João Távora [this message]
2021-11-04 22:41 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-10 4:53 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm52hqwZPPpZRPcEs3L+brDF=nj+qs2iKunWD9nrOr6sLCg@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=51437@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=salutis@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).