From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#51437: 29.0.50; The annotated example of a complete working Flymake backend does not work with narrowed buffers Date: Sun, 31 Oct 2021 09:26:16 +0000 Message-ID: References: <871r44ymw6.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a0108e05cfa2a709" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2943"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 51437@debbugs.gnu.org To: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 31 10:27:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mh77M-0000Vv-Vq for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Oct 2021 10:27:09 +0100 Original-Received: from localhost ([::1]:51224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mh77L-0000HE-BV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Oct 2021 05:27:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mh77G-0000H6-AN for bug-gnu-emacs@gnu.org; Sun, 31 Oct 2021 05:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47442) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mh77G-00017q-2B for bug-gnu-emacs@gnu.org; Sun, 31 Oct 2021 05:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mh77F-0000DF-T5 for bug-gnu-emacs@gnu.org; Sun, 31 Oct 2021 05:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Oct 2021 09:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51437 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51437-submit@debbugs.gnu.org id=B51437.1635672395778 (code B ref 51437); Sun, 31 Oct 2021 09:27:01 +0000 Original-Received: (at 51437) by debbugs.gnu.org; 31 Oct 2021 09:26:35 +0000 Original-Received: from localhost ([127.0.0.1]:58988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mh76o-0000CT-VN for submit@debbugs.gnu.org; Sun, 31 Oct 2021 05:26:35 -0400 Original-Received: from mail-pf1-f178.google.com ([209.85.210.178]:33640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mh76n-0000CG-BC for 51437@debbugs.gnu.org; Sun, 31 Oct 2021 05:26:33 -0400 Original-Received: by mail-pf1-f178.google.com with SMTP id t184so13625373pfd.0 for <51437@debbugs.gnu.org>; Sun, 31 Oct 2021 02:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hSihxBS5B2s6ul+yv0lObuWDS5rlBVTEY8bLWCxkVE4=; b=RyGIPOiX3uY/9K1GIZP9hDfQ76gDYVH2uEiSBVgJf8caMOc1Cms0xMUoERye6W3Teb 243B9Lo6CAyzuj/WxRaeKACHOsaVhvTuVdWt2kI16o0/fozmtYrF0f2YAWf/5fxjdleX 0i6xity0nPC1NH1/aDo1CjtSzuaaS8TdE3rc2mNYFz6C5WDOOEKotZdK+ZK2mHNgdvI9 phV+uUNKIO5u+anzELJdLYV6ZjRuPXPUF7UWSKxkvOg8+TPq+4vftDbl8n5+9ZBdkRLu BXdyiOBQQ/DrzErfCyJQxF3kyFYPhR9yxL327wPEqR8JKqvSayxdauWpgRmqECnePJUq /J0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hSihxBS5B2s6ul+yv0lObuWDS5rlBVTEY8bLWCxkVE4=; b=CdpFNgDUKIuApuZNUoKbDOEFS9/H5ykrDVc+txu1Edhxg8cGyUcmIoQESPwUWiOH8S 2fF0Xt/GqU4/Ds+Dsj5JFpI6l9dY4utGUOWyuY7an/nTeUm/3BI9rBL61gO+bxB7sKKj Wh0cwk4TmVfz7U+JlYab00FfPPG3tLAHrMYlLDSkE3nHdJnQmlskhdGRuPUr01SR/18o ke2Mz0AfRH4rAOLYcilgf5U+8XCMAIPSPJib2B5La0d3nduXT1EGUZTDK/nIxjb8INSC A6/Qbm3GJl/RzSJk2hLsfp13/bWZ3jbqwyv8y8jsNTIKI2iFLPtmWnCm3MsQLjTospom rPwQ== X-Gm-Message-State: AOAM5326qlINmJHD7eXVzUQ99l6dtBVsYnxJi27pHOVAQzySH6eek0NG dM5coqST5tVGmEk/ca7erZeSRM4winAfHr/1aFk= X-Google-Smtp-Source: ABdhPJyjztqujnKjgsuLyv1LV/g9siGUmlHx7tbn1U8CmPx6C917R/r/HIjYSQbDUt7WOwjWCUK1PLDKKvlp6DMJMlo= X-Received: by 2002:a63:7e19:: with SMTP id z25mr16287610pgc.295.1635672387488; Sun, 31 Oct 2021 02:26:27 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218664 Archived-At: --000000000000a0108e05cfa2a709 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This is starting to sound like a more generic Flymake limitation/bug than a documentation bug. I'll have a look when I get home. Have you experimented with the 'region' arg when reporting back diagnostics? Also you can have a look at how the Elisp backend does it? I think, though I am not sure, that it works with narrowed buffers. By the way, Flymake for spell checking is a great idea. Is your backend available somewhere? Jo=C3=A3o On Sat, Oct 30, 2021, 22:15 Rudolf Adamkovi=C4=8D wrote: > Jo=C3=A3o T=C3=A1vora writes: > > > I can't test right now, but maybe Rudolf can. If it works then > > I'd say commit it. > > The patch fixes the errors, but it also causes troubles. Say I use Flymak= e > to check on my English grammar, and say I have 10 errors in my text. I > narrow down to a part with 5 errors, fix them, write some new text, and > after a while, I widen the buffer. I look through my final text, see that > Flymake reports 0 errors, and submit my work to someone. Well, I submitte= d > 5 errors, because Flymake did not re-check when I widened the buffer. > Further, Flymake might report incorrect data on narrow. In the example > above, it would have said 10 errors after narrowing and then 5 for the sa= me > narrowed content on the next re-check. Thus, we should either always chec= k > the entire content of the buffer, or we should recheck on narrow and wide= n, > potentially wasting bandwidth for online checks and the like. > > Rudy > > -- > "'Contrariwise,' continued Tweedledee, 'if it was so, it might be; and if > it were so, it would be; but as it isn't, it ain't. That's logic.'" -- > Lewis Carroll, Through the Looking Glass > > Rudolf Adamkovi=C4=8D > Studenohorsk=C3=A1 25 > 84103 Bratislava > Slovakia > > [he/him] > --000000000000a0108e05cfa2a709 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This is starting to sound like a more generic Flymake lim= itation/bug than a documentation bug. I'll have a look when I=C2=A0get = home.

Have you experimented wi= th the 'region' arg when reporting back diagnostics?=C2=A0 Also you= can have a look at how the Elisp backend does it?=C2=A0 I think, though I = am not sure, that it works with narrowed buffers.
By the way, Flymake for spell checking is a great= idea. Is your backend available somewhere?

Jo=C3=A3o

On Sat, Oct 30, 2021, 22:15 Rudolf Adamk= ovi=C4=8D <salutis@me.com> wrot= e:
Jo=C3=A3o T=C3=A1vora <joao= tavora@gmail.com> writes:

> I can't test right now, but maybe Rudolf can. If it works then
> I'd say commit it.

The patch fixes the errors, but it also causes troubles. Say I use Flymake = to check on my English grammar, and say I have 10 errors in my text. I narr= ow down to a part with 5 errors, fix them, write some new text, and after a= while, I widen the buffer. I look through my final text, see that Flymake = reports 0 errors, and submit my work to someone. Well, I submitted 5 errors= , because Flymake did not re-check when I widened the buffer. Further, Flym= ake might report incorrect data on narrow. In the example above, it would h= ave said 10 errors after narrowing and then 5 for the same narrowed content= on the next re-check. Thus, we should either always check the entire conte= nt of the buffer, or we should recheck on narrow and widen, potentially was= ting bandwidth for online checks and the like.

Rudy

--
"'Contrariwise,' continued Tweedledee, 'if it was so, it m= ight be; and if it were so, it would be; but as it isn't, it ain't.= That's logic.'" -- Lewis Carroll, Through the Looking Glass
Rudolf Adamkovi=C4=8D <salutis@me.com>
Studenohorsk=C3=A1 25
84103 Bratislava
Slovakia

[he/him]
--000000000000a0108e05cfa2a709--