From: "João Távora" <joaotavora@gmail.com>
To: Felician Nemeth <felician.nemeth@gmail.com>
Cc: 62198@debbugs.gnu.org, Michael Albinus <michael.albinus@gmx.de>
Subject: bug#62198: [PATCH] Eglot: Send clientInfo during the initialize request
Date: Sun, 19 Mar 2023 13:23:29 +0000 [thread overview]
Message-ID: <CALDnm526vVTC8c=RVCPG4S75TDWemu9tqj0eRJfg2YQh0qTtHg@mail.gmail.com> (raw)
In-Reply-To: <871qll7x9f.fsf@betli.tmit.bme.hu>
On Sun, Mar 19, 2023 at 12:15 PM Felician Nemeth
<felician.nemeth@gmail.com> wrote:
>
> Hi Michael,
>
> > FTR, trampver.el is always generated from trampver.el.in in the Tramp
> > repository, see <https://git.savannah.gnu.org/cgit/tramp.git/plain/lisp/trampver.el.in>.
>
> Ah, okay, sorry.
>
> At any rate, I think a Makefile would be an overkill for this little
> feature.
FWIW, my other SLY extension also has a complicated "scan own file"
thing. Known to not work extremely well/be very useful...
> So maybe clientInfo should just send the name of the client if
> João is not happy with the previous approach finding out the version of
> Eglot.
I don't know if I'm happy with it, since I'm not familiar with what
it does.
The version could be useful. The problem is that it is tricky
to get right, meaning something that you can really rely on. Ideally
I'd like to know two things in the log transcript some hypothetical
bug reporter shares:
1. Is this an unmodified GNU(-devel) ELPA version of Eglot installed by
the only officially supported `M-x package-install` method? If so,
what version exactly?
2. This is something else, a user compilation, a straight-installed
package, nix installation (never tried these, but they show
up in the wild a lot, and are problematic like in
https://github.com/joaotavora/eglot/discussions/1182).
I don't think any more granularity within 2 would be very useful,
especially to the server devs. Although it _could_ be useful to
somehow debug -- not via LSP messages to server, but in the events
log as an internal message -- the versions of the packages that
Eglot depends on. But that's a broader idea, I think, and one
more suitable for a future M-x report-bug-in-elpa-package.
If this is not easy to do without complex libraries, i'd prefer just to
send the client name via LSP.
João
next prev parent reply other threads:[~2023-03-19 13:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 11:53 bug#62198: [PATCH] Eglot: Send clientInfo during the initialize request Felician Nemeth
2023-03-15 20:38 ` João Távora
2023-03-16 16:47 ` Felician Nemeth
2023-03-17 8:25 ` Michael Albinus
2023-03-19 12:15 ` Felician Nemeth
2023-03-19 13:23 ` João Távora [this message]
2023-03-22 16:05 ` Felician Nemeth
2023-03-22 18:40 ` João Távora
2023-03-23 16:03 ` Felician Nemeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm526vVTC8c=RVCPG4S75TDWemu9tqj0eRJfg2YQh0qTtHg@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=62198@debbugs.gnu.org \
--cc=felician.nemeth@gmail.com \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).