From: "João Távora" <joaotavora@gmail.com>
To: Felician Nemeth <felician.nemeth@gmail.com>
Cc: 62198@debbugs.gnu.org, Michael Albinus <michael.albinus@gmx.de>
Subject: bug#62198: [PATCH] Eglot: Send clientInfo during the initialize request
Date: Wed, 22 Mar 2023 18:40:06 +0000 [thread overview]
Message-ID: <87ttycvddl.fsf@gmail.com> (raw)
In-Reply-To: <87o7ok7owb.fsf@betli.tmit.bme.hu> (Felician Nemeth's message of "Wed, 22 Mar 2023 17:05:08 +0100")
Felician Nemeth <felician.nemeth@gmail.com> writes:
>> I don't think any more granularity within 2 would be very useful,
>> especially to the server devs.
>
> I don't know how to answer these questions.
I'm not asking you :-) These are questions I ask myself when facing bug
reports. And usually I don't have a good way of answering except for
drilling the bug reporter.
I agree this most of this information shouldn't probably be sent over to
the server.
>> Although it _could_ be useful to somehow debug -- not via LSP messages
>> to server, but in the events log as an internal message -- the
>> versions of the packages that Eglot depends on. But that's a broader
>> idea, I think, and one more suitable for a future M-x
>> report-bug-in-elpa-package.
>
> I think it is possible write the versions of Eglot and its dependencies
> into eglot-events-buffer with the help of list-mnt, but I don't think
> Eglot should send this in clientInfo.
Yes, of course. It's debugging information. Currently the manual
advises users to list the files in 'package-user-dir', which is a really
poor way of telling the versions of ELPA packages, but it's the best
I've come up with. What I meant is I'd like to have a way to produce a
listing of packages (required and optional, like
markdown/company/yasnippet) for inclusion in bug reports.
>> If this is not easy to do without complex libraries, i'd prefer just to
>> send the client name via LSP.
>
> I've attached a simple patch that sends just the client name if you
> decide to go this way.
Thanks, I've pushed it to master.
João
next prev parent reply other threads:[~2023-03-22 18:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 11:53 bug#62198: [PATCH] Eglot: Send clientInfo during the initialize request Felician Nemeth
2023-03-15 20:38 ` João Távora
2023-03-16 16:47 ` Felician Nemeth
2023-03-17 8:25 ` Michael Albinus
2023-03-19 12:15 ` Felician Nemeth
2023-03-19 13:23 ` João Távora
2023-03-22 16:05 ` Felician Nemeth
2023-03-22 18:40 ` João Távora [this message]
2023-03-23 16:03 ` Felician Nemeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttycvddl.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=62198@debbugs.gnu.org \
--cc=felician.nemeth@gmail.com \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).