From: "João Távora" <joaotavora@gmail.com>
To: Augusto Stoffel <arstoffel@gmail.com>
Cc: 54473@debbugs.gnu.org, andreyk.mad@gmail.com
Subject: bug#54473: 28.0.91; [PATCH] Eldoc: Handle invisible text when truncating strings
Date: Sun, 20 Mar 2022 13:10:54 +0000 [thread overview]
Message-ID: <CALDnm50zMkhKE9Q=sB0=JhY9uejqArDmeA0w-ceM2My9XRPhKA@mail.gmail.com> (raw)
In-Reply-To: <87o8203k0v.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 964 bytes --]
Looks fine, but would need, I think, a decent amount of testing:
* In eglot.el, being validated by both Andrii and you for your particular
use cases.
* In bare emacs-lisp-mode, with multiple eldoc-documentation-strategy
options. It should
behave exactly the same before and after the patch, as elisp doesn't use
invisible stuff.
* In other situations you can think of. Like variations on
eldoc-area-use-multiline-p and
eldoc-echo-area-display-truncation-messages. Again, here the behaviour
should be
equivalent pre- and post- patch.
Just noting this because in my memory this code is somewhat hairy. That
said, the patch "looks" really fine :-)
Thanks,
João
On Sun, Mar 20, 2022 at 12:06 PM Augusto Stoffel <arstoffel@gmail.com>
wrote:
> This should solve the Eglot-related problem described in this Github
> comment:
>
> https://github.com/joaotavora/eglot/issues/865#issuecomment-1065565845
>
>
--
João Távora
[-- Attachment #2: Type: text/html, Size: 1614 bytes --]
next prev parent reply other threads:[~2022-03-20 13:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 12:06 bug#54473: 28.0.91; [PATCH] Eldoc: Handle invisible text when truncating strings Augusto Stoffel
2022-03-20 13:10 ` João Távora [this message]
2022-03-20 13:52 ` Eli Zaretskii
2022-03-20 14:03 ` João Távora
2022-03-20 14:34 ` Augusto Stoffel
2022-03-20 15:57 ` Eli Zaretskii
2022-03-20 21:24 ` Andrii Kolomoiets
2022-03-24 15:25 ` João Távora
2022-06-23 17:24 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm50zMkhKE9Q=sB0=JhY9uejqArDmeA0w-ceM2My9XRPhKA@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=54473@debbugs.gnu.org \
--cc=andreyk.mad@gmail.com \
--cc=arstoffel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).