From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#54473: 28.0.91; [PATCH] Eldoc: Handle invisible text when truncating strings Date: Sun, 20 Mar 2022 13:10:54 +0000 Message-ID: References: <87o8203k0v.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000000b052105daa6198d" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21767"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54473@debbugs.gnu.org, andreyk.mad@gmail.com To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 20 14:11:36 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVvLL-0005Q3-Jo for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Mar 2022 14:11:35 +0100 Original-Received: from localhost ([::1]:38850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVvLK-0005yc-GZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Mar 2022 09:11:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVvL1-0005xy-3Q for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2022 09:11:15 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39280) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVvKo-0006W6-Hy for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2022 09:11:14 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVvKo-0007Fm-8s for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2022 09:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Mar 2022 13:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54473 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: "simon254--- via Bug reports for GNU Emacs, the Swiss army knife of text editors" , Andrii Kolomoiets Original-Received: via spool by submit@debbugs.gnu.org id=B.164778180727803 (code B ref -1); Sun, 20 Mar 2022 13:11:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Mar 2022 13:10:07 +0000 Original-Received: from localhost ([127.0.0.1]:33174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvJv-0007EN-Fi for submit@debbugs.gnu.org; Sun, 20 Mar 2022 09:10:07 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:44018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvJu-0007EG-EU for submit@debbugs.gnu.org; Sun, 20 Mar 2022 09:10:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVvJu-0005Ze-AR for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2022 09:10:06 -0400 Original-Received: from [2607:f8b0:4864:20::236] (port=41560 helo=mail-oi1-x236.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVvJs-0006CY-Fs for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2022 09:10:05 -0400 Original-Received: by mail-oi1-x236.google.com with SMTP id ay7so13740145oib.8 for ; Sun, 20 Mar 2022 06:10:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=55RjGWC7zuMbMnZ46Qa/wlQN92hyUs8Kg5zVUIpC5Jw=; b=ngYnZlCMyh751qpq2pgWoo7WWzMfdIjQ3D1S7yktJfUJqTCJ9SEX3IV07f0W2Sx7a5 M45sk9rWbyorZoAHZQD4uhHr8IvFI4vErISI8K6M8jYuq53IwwdcXVfRwLUJe8sDVLqD +K8ZUKMuXAEQ2TAjIUpUqaaMOXGMMiJ8d8++XLdUKYaK+R8oaMAZiaFuY8ag0QnjBzAS WYLr99frwG+MkPgV2wu7dxgaj62NHjdg61YsbnHUm/owI1994/yp9v48gS4kfEj1tyjh xaW/04D5kVV9IXpNZ4fVMp1Jif/IFT2X6R/tqj1XX0BVim2hJMsz5nTgHaOKuYZ0376x 7GkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=55RjGWC7zuMbMnZ46Qa/wlQN92hyUs8Kg5zVUIpC5Jw=; b=ynRAj/NKazwoM1MZiA3SaQSg4/oJlwMC2LjNo+zIU9xscdqa8Q5Y/6Bve2cm9EcNl2 UwGbyB0W95kkzUZvvfM9wSp12BTeh+K/HrzE2vgmuRRe/PRcbRKSS/oNVnAOXc2cejEw LgvI0Ag95tbgWGu1178KozKQl9Biapu0WTDFtwfFHDJ6iTPJdYYu6gAtoxqVNfZZRrXb cL+4ck3RXZDNuhqoY07sspU4j819rR9QVLbzlKz4pB1zk7aViW1KePl1H1WrrLeQFsGB T2dCRTrhRD8v65N3fXAqs4rQjz14yTy66IwAS47rLFmI+TaYRYG1z2Wq496q8UvKFI3p xxow== X-Gm-Message-State: AOAM531hhYL+xMp1F+GTXQjyxgJqRJcxmOoSjq+IJI152U4xc/hPlsZ8 X6ccFQvd6bHbbCYjY5LicgR6vXaGsqQBuqi0uYU= X-Google-Smtp-Source: ABdhPJy7QOgqZLvNS2z+sN08y/NG4oR3hBREuh3TxOXxodvztcd+Z2CFSoPw2J1H7jAGWAwQVi8G58QgwCsTvCOOBqQ= X-Received: by 2002:aca:2b0d:0:b0:2d9:dc99:3898 with SMTP id i13-20020aca2b0d000000b002d9dc993898mr11324576oik.209.1647781803131; Sun, 20 Mar 2022 06:10:03 -0700 (PDT) In-Reply-To: <87o8203k0v.fsf@gmail.com> X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::236 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::236; envelope-from=joaotavora@gmail.com; helo=mail-oi1-x236.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228621 Archived-At: --0000000000000b052105daa6198d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Looks fine, but would need, I think, a decent amount of testing: * In eglot.el, being validated by both Andrii and you for your particular use cases. * In bare emacs-lisp-mode, with multiple eldoc-documentation-strategy options. It should behave exactly the same before and after the patch, as elisp doesn't use invisible stuff. * In other situations you can think of. Like variations on eldoc-area-use-multiline-p and eldoc-echo-area-display-truncation-messages. Again, here the behaviour should be equivalent pre- and post- patch. Just noting this because in my memory this code is somewhat hairy. That said, the patch "looks" really fine :-) Thanks, Jo=C3=A3o On Sun, Mar 20, 2022 at 12:06 PM Augusto Stoffel wrote: > This should solve the Eglot-related problem described in this Github > comment: > > https://github.com/joaotavora/eglot/issues/865#issuecomment-1065565845 > > --=20 Jo=C3=A3o T=C3=A1vora --0000000000000b052105daa6198d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Looks fine, but would need, I think, a decent amount = of testing:

* In eglot.el, being validated by both= Andrii and you for your particular use cases.
* In bare emac= s-lisp-mode, with multiple eldoc-documentation-strategy options.=C2=A0 It s= hould
=C2=A0 behave exactly the same before and after the pa= tch, as elisp doesn't use invisible stuff.
* In other sit= uations you can think of.=C2=A0 Like variations on eldoc-area-use-multiline= -p and
=C2=A0 eldoc-echo-area-display-truncation-messages.= =C2=A0 Again, here the behaviour should be
=C2=A0 equivalent pre-= and post- patch.

Just noting this because in my m= emory this code is somewhat hairy.=C2=A0 That
said, the patc= h "looks" really fine :-)

Thanks,
Jo=C3=A3o

On Sun, Mar 20, 2022 at 12:06 PM Augusto Sto= ffel <arstoffel@gmail.com>= wrote:
This sho= uld solve the Eglot-related problem described in this Github comment:

https://github.com/joaotavora/= eglot/issues/865#issuecomment-1065565845



--
Jo=C3=A3o T=C3=A1vora
--0000000000000b052105daa6198d--