From: "João Távora" <joaotavora@gmail.com>
To: Alan Mackenzie <acm@muc.de>
Cc: Michael Albinus <michael.albinus@gmx.de>, 47320-done@debbugs.gnu.org
Subject: bug#47320: Improve failure reporting in test/lisp/electrict-tests.el
Date: Thu, 25 Mar 2021 23:47:11 +0000 [thread overview]
Message-ID: <CALDnm50m_C8BnBCEetsawwOp=xqCHArDSY4PTOmNcp4Ec1FSNA@mail.gmail.com> (raw)
In-Reply-To: <YFyTf4BxJ2UtOJin@ACM>
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
>
> > (point) expected-point)))))
>
> OK, I see what you meant now. This version, instead of duplicating the
> test comparisons, duplicates the call to message. I
The difference being that it's a one-arg call to message that has no
branching, i.e. functional impact, so if that code gets out of sync,
at least the test results don't change. Your version duplicates the
test assertion itself.
It's localized, and none of this is serious, I was just a bit peeved
that my simple suggestion was ignored. The solution for this is to
have ert.el utilize ert-describe-test and output that when
the test fails. As you may know, ert-describe-test has the output
you are looking for.
João
[-- Attachment #2: Type: text/html, Size: 1143 bytes --]
prev parent reply other threads:[~2021-03-25 23:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 14:24 bug#47320: Improve failure reporting in test/lisp/electrict-tests.el Alan Mackenzie
2021-03-23 8:53 ` Michael Albinus
2021-03-23 14:47 ` Alan Mackenzie
2021-03-23 15:24 ` Michael Albinus
2021-03-23 15:59 ` João Távora
2021-03-24 13:46 ` Alan Mackenzie
2021-03-24 14:02 ` João Távora
2021-03-24 19:42 ` Alan Mackenzie
2021-03-24 20:10 ` João Távora
2021-03-25 13:43 ` Alan Mackenzie
2021-03-25 23:47 ` João Távora [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm50m_C8BnBCEetsawwOp=xqCHArDSY4PTOmNcp4Ec1FSNA@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=47320-done@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).