From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#47320: Improve failure reporting in test/lisp/electrict-tests.el Date: Thu, 25 Mar 2021 23:47:11 +0000 Message-ID: References: <87v99i5k0f.fsf@gmx.de> <877dlx3nb8.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000006fe22c05be6509a9" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11220"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Albinus , 47320-done@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 26 00:48:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPZi6-0002oc-Fw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Mar 2021 00:48:18 +0100 Original-Received: from localhost ([::1]:38450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPZi5-0001Kz-HG for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Mar 2021 19:48:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPZhq-0001EO-5m for bug-gnu-emacs@gnu.org; Thu, 25 Mar 2021 19:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56595) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPZhp-0002xp-Uf for bug-gnu-emacs@gnu.org; Thu, 25 Mar 2021 19:48:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lPZhp-0006nr-Sm for bug-gnu-emacs@gnu.org; Thu, 25 Mar 2021 19:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Mar 2021 23:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47320 X-GNU-PR-Package: emacs Original-Received: via spool by 47320-done@debbugs.gnu.org id=D47320.161671605126113 (code D ref 47320); Thu, 25 Mar 2021 23:48:01 +0000 Original-Received: (at 47320-done) by debbugs.gnu.org; 25 Mar 2021 23:47:31 +0000 Original-Received: from localhost ([127.0.0.1]:39908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPZhK-0006n7-T5 for submit@debbugs.gnu.org; Thu, 25 Mar 2021 19:47:31 -0400 Original-Received: from mail-io1-f54.google.com ([209.85.166.54]:33763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPZhI-0006mu-Lx for 47320-done@debbugs.gnu.org; Thu, 25 Mar 2021 19:47:29 -0400 Original-Received: by mail-io1-f54.google.com with SMTP id n198so3713489iod.0 for <47320-done@debbugs.gnu.org>; Thu, 25 Mar 2021 16:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bns6MurV3TpCzemVZ6GGQ7Cl2NvlqGOSOZFJz9rfr1I=; b=TL1n8Gp/84FNNL3JAGWutDEPNsqUEeEI1/DAhUaeWPytOtLLIv2zEAQJSqCzQShtTt BNK2rTxhbfLcLctVwB+dsLqn5LnbCeCjU8P/+BrZ1n9raCv3ZXhg5paFHmQqgpqQ6WGl g4bMXax6IRADAZfh6r+bzEcq/pZaubYTsaHajEkw2Jl0Yg+ZNGzxZ10pF7ndJrSCjBPt OrLFZVWwhU5LaDp1Up9ZuL/557OtK0PevE0PI79HgX7lryF2+xLz1E89yxPLAZhFhVNk VH0u2gNQupFhSSZaLttz++3dLclfV2fTdhFfj+NLQH8Xpm7z7D5kIB2Wtv+5b5InTnDP NwQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bns6MurV3TpCzemVZ6GGQ7Cl2NvlqGOSOZFJz9rfr1I=; b=ob9zqs+YbuZcILLyCeh41rVhqZ5SqemuunTpbVhZKK/x2XronCmrp6YaQKKuhgXHQw S/snzXZ26MeaqPg7qoyAlRRQshOzFYX7XoxjnOfHujR/VQgLsFsxSzy+q5pG5ZQ3PPNJ ohFSWxiIs0HPgLJ2X1q0Jv/Q65/hL+OxDp8GepmQjy1V/d2GJF9fcD5D8LNodPgyR2BR I6cQ/KktiT9XzonYsIDzYRJdpW/FO3kM4ulCXijvyRTqVKGzR4yadZfTzKPWvy7QF77D RKqJxUKC7qbPKRjP7vbdco7k6d2GCZ+CXnfKGsIiNQ8fuKUDcQga375tEqti0w5/SWag xd+Q== X-Gm-Message-State: AOAM532E3jDjbDpg2noUlTKuQaEj+JczfQr4ZBNlnjUfI6QCytncgAWa YYkb5ubIgh+/M2jEzCxQMRVtLFvp2u0VunvLKL0= X-Google-Smtp-Source: ABdhPJy/cqvXWN6I2/bNDXkbPRrl0xmv81DtgpArvmfhRBkySOHwkYfbKT5o94JIqKux733aX77IwNVPGxaXELy43MM= X-Received: by 2002:a5e:8c16:: with SMTP id n22mr8273803ioj.156.1616716042853; Thu, 25 Mar 2021 16:47:22 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203032 Archived-At: --0000000000006fe22c05be6509a9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > > > (point) expected-point))))) > > OK, I see what you meant now. This version, instead of duplicating the > test comparisons, duplicates the call to message. I The difference being that it's a one-arg call to message that has no branching, i.e. functional impact, so if that code gets out of sync, at least the test results don't change. Your version duplicates the test assertion itself. It's localized, and none of this is serious, I was just a bit peeved that my simple suggestion was ignored. The solution for this is to have ert.el utilize ert-describe-test and output that when the test fails. As you may know, ert-describe-test has the output you are looking for. Jo=C3=A3o --0000000000006fe22c05be6509a9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (point) expecte= d-point)))))

OK, I see what you meant now.=C2=A0 This version, instead of duplicating th= e
test comparisons, duplicates the call to message.=C2=A0 I
=
The difference being that it's a one-arg call to message= that has no
branching, i.e. functional impact, so if that c= ode gets out of sync,
at least the test results don't ch= ange.=C2=A0 Your version duplicates the
test assertion itself.

It's localized, and none of this is serious, I = was just a bit peeved
that my simple suggestion was ignored.= =C2=A0=C2=A0 The solution for this is to
have ert.el utilize= ert-describe-test and output that when
the test fails.=C2= =A0=C2=A0 As you may know, ert-describe-test has the output
= you are looking for.

Jo=C3=A3o

<= /div>


--0000000000006fe22c05be6509a9--