* bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs log format
@ 2017-06-23 0:49 Rohan Hart
2019-07-21 17:40 ` Lars Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Rohan Hart @ 2017-06-23 0:49 UTC (permalink / raw)
To: 27453
[-- Attachment #1: Type: text/plain, Size: 904 bytes --]
Darcs now shows the internal hash for each patch in a format like:
patch f4128969c4700a0b34414390d04159cb6b11b4e5
Author: bob <bob>
Date: Sun May 21 22:44:55 NZST 2017
* patch name
- further details
Adding the regex "\\|^patch \\(?1:[.0-9a-f]+\\)" to log-view-message-re
seems to be sufficient to use the hash.
cheers
Rohan
--
| Rohan Hart | Consultant | Fronde Systems Group Ltd
| 3 Queens Wharf | PO Box 11545 | Wellington 6142, New Zealand
| p. +64 4 499 3000 | ddi. +64 4 439 4080 | m. +64 21 937 533
| e. rohan.hart@fronde.com | w. www.fronde.com
--
The information contained in this email is privileged and confidential and
intended for the addressee only. If you are not the intended recipient,
please respect that confidentiality and do not disclose, copy or make use
of its contents. If received in error, please destroy this email and
contact the sender immediately. Thank you.
[-- Attachment #2: Type: text/html, Size: 1325 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs log format
2017-06-23 0:49 bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs log format Rohan Hart
@ 2019-07-21 17:40 ` Lars Ingebrigtsen
2019-07-21 20:36 ` Rohan Hart
0 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-21 17:40 UTC (permalink / raw)
To: Rohan Hart; +Cc: 27453
Rohan Hart <rohan.hart@fronde.com> writes:
> Darcs now shows the internal hash for each patch in a format like:
>
> patch f4128969c4700a0b34414390d04159cb6b11b4e5
> Author: bob <bob>
> Date: Sun May 21 22:44:55 NZST 2017
> * patch name
> - further details
>
> Adding the regex "\\|^patch \\(?1:[.0-9a-f]+\\)" to log-view-message-re
> seems to be sufficient to use the hash.
Hm... Unless I'm mistaken, Emacs doesn't support Darcs? I ran
$ darcs clone https://hub.darcs.net/onetom/0wnDB
and Emacs then claimed that the files in that directory weren't under
source control? So I'm unsure how this would help...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs log format
2019-07-21 17:40 ` Lars Ingebrigtsen
@ 2019-07-21 20:36 ` Rohan Hart
2019-07-22 12:28 ` Lars Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Rohan Hart @ 2019-07-21 20:36 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 27453
[-- Attachment #1: Type: text/plain, Size: 1507 bytes --]
Hi Lars
Emacs doesn't support Darcs out of the box. See
https://www.emacswiki.org/emacs/DaRcs
cheers
Rohan
On Mon, 22 Jul 2019 at 05:40, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Rohan Hart <rohan.hart@fronde.com> writes:
>
> > Darcs now shows the internal hash for each patch in a format like:
> >
> > patch f4128969c4700a0b34414390d04159cb6b11b4e5
> > Author: bob <bob>
> > Date: Sun May 21 22:44:55 NZST 2017
> > * patch name
> > - further details
> >
> > Adding the regex "\\|^patch \\(?1:[.0-9a-f]+\\)" to log-view-message-re
> > seems to be sufficient to use the hash.
>
> Hm... Unless I'm mistaken, Emacs doesn't support Darcs? I ran
>
> $ darcs clone https://hub.darcs.net/onetom/0wnDB
>
> and Emacs then claimed that the files in that directory weren't under
> source control? So I'm unsure how this would help...
>
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no
>
--
*Rohan Hart*
Technical Lead Developer
Fronde
[image: Fronde Logo]
Level 1, 222 Lambton Quay | PO Box 11-545 | Wellington 6011, New Zealand
m. +64 21 937 533 | e. rohan.hart@fronde.com | w. www.fronde.com
--
The information contained in this email is privileged and confidential and
intended for the addressee only. If you are not the intended recipient,
please respect that confidentiality and do not disclose, copy or make use
of its contents. If received in error, please destroy this email and
contact the sender immediately. Thank you.
[-- Attachment #2: Type: text/html, Size: 3574 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs log format
2019-07-21 20:36 ` Rohan Hart
@ 2019-07-22 12:28 ` Lars Ingebrigtsen
2019-07-22 20:42 ` Rohan Hart
0 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-22 12:28 UTC (permalink / raw)
To: Rohan Hart; +Cc: 27453
Rohan Hart <rohan.hart@fronde.com> writes:
> Emacs doesn't support Darcs out of the box. See
> https://www.emacswiki.org/emacs/DaRcs
Wouldn't it then be up to these external packages to extend
`log-view-message-re' to match the formats?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs log format
2019-07-22 12:28 ` Lars Ingebrigtsen
@ 2019-07-22 20:42 ` Rohan Hart
2019-07-23 11:31 ` Lars Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Rohan Hart @ 2019-07-22 20:42 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 27453
[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]
Well sure, I only raised this as log-view states:
;; Currently supports the format output by:
;; SCCS, RCS, CVS, Subversion, DaRCS, and Mercurial.
And later mentions code related to both darcsum and vc-darcs.
I'll raise it with the other packages
cheers
On Tue, 23 Jul 2019 at 00:28, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Rohan Hart <rohan.hart@fronde.com> writes:
>
> > Emacs doesn't support Darcs out of the box. See
> > https://www.emacswiki.org/emacs/DaRcs
>
> Wouldn't it then be up to these external packages to extend
> `log-view-message-re' to match the formats?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no
>
--
*Rohan Hart*
Technical Lead Developer
Fronde
[image: Fronde Logo]
Level 1, 222 Lambton Quay | PO Box 11-545 | Wellington 6011, New Zealand
m. +64 21 937 533 | e. rohan.hart@fronde.com | w. www.fronde.com
--
The information contained in this email is privileged and confidential and
intended for the addressee only. If you are not the intended recipient,
please respect that confidentiality and do not disclose, copy or make use
of its contents. If received in error, please destroy this email and
contact the sender immediately. Thank you.
[-- Attachment #2: Type: text/html, Size: 3159 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs log format
2019-07-22 20:42 ` Rohan Hart
@ 2019-07-23 11:31 ` Lars Ingebrigtsen
2019-07-23 20:57 ` Rohan Hart
0 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-23 11:31 UTC (permalink / raw)
To: Rohan Hart; +Cc: 27453
Rohan Hart <rohan.hart@fronde.com> writes:
> Well sure, I only raised this as log-view states:
>
> ;; Currently supports the format output by:
> ;; SCCS, RCS, CVS, Subversion, DaRCS, and Mercurial.
>
> And later mentions code related to both darcsum and vc-darcs.
Then perhaps it does make sense to add the regexp to log-view-message-re
after all. The current definition is:
(defvar log-view-message-re
(concat "^\\(?:revision \\(?1:[.0-9]+\\)\\(?:\t.*\\)?" ; RCS and CVS.
"\\|r\\(?1:[0-9]+\\) | .* | .*" ; Subversion.
"\\|D \\(?1:[.0-9]+\\) .*" ; SCCS.
;; Darcs doesn't have revision names. VC-darcs uses patch names
;; instead. Darcs patch names are hashcodes, which do not appear
;; in the log output :-(, but darcs accepts any prefix of the log
;; message as a patch name, so we match the first line of the log
;; message.
;; First loosely match the date format.
(concat "\\|[^ \n].*[^0-9\n][0-9][0-9]:[0-9][0-9][^0-9\n].*[^ \n]"
;;Email of user and finally Msg, used as revision name.
" .*@.*\n\\(?: \\* \\(?1:.*\\)\\)?")
"\\)$")
Is VC-darcs something else than darcs? Or is that an Emacs package?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs log format
2019-07-23 11:31 ` Lars Ingebrigtsen
@ 2019-07-23 20:57 ` Rohan Hart
2019-07-24 12:32 ` Lars Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Rohan Hart @ 2019-07-23 20:57 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 27453
[-- Attachment #1: Type: text/plain, Size: 2405 bytes --]
vc-darcs is the emacs package for darcs integration with vc.
If you wished to support very old versions of darcs then keep that complex
match and put the new one before it. Not that I've tested that config - I
just override the entire log-view-message-re as I don't use any of those
other version control systems
thanks
On Tue, 23 Jul 2019 at 23:32, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Rohan Hart <rohan.hart@fronde.com> writes:
>
> > Well sure, I only raised this as log-view states:
> >
> > ;; Currently supports the format output by:
> > ;; SCCS, RCS, CVS, Subversion, DaRCS, and Mercurial.
> >
> > And later mentions code related to both darcsum and vc-darcs.
>
> Then perhaps it does make sense to add the regexp to log-view-message-re
> after all. The current definition is:
>
> (defvar log-view-message-re
> (concat "^\\(?:revision \\(?1:[.0-9]+\\)\\(?:\t.*\\)?" ; RCS and CVS.
> "\\|r\\(?1:[0-9]+\\) | .* | .*" ; Subversion.
> "\\|D \\(?1:[.0-9]+\\) .*" ; SCCS.
> ;; Darcs doesn't have revision names. VC-darcs uses patch names
> ;; instead. Darcs patch names are hashcodes, which do not appear
> ;; in the log output :-(, but darcs accepts any prefix of the log
> ;; message as a patch name, so we match the first line of the log
> ;; message.
> ;; First loosely match the date format.
> (concat "\\|[^ \n].*[^0-9\n][0-9][0-9]:[0-9][0-9][^0-9\n].*[^
> \n]"
> ;;Email of user and finally Msg, used as revision name.
> " .*@.*\n\\(?: \\* \\(?1:.*\\)\\)?")
> "\\)$")
>
> Is VC-darcs something else than darcs? Or is that an Emacs package?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no
>
--
*Rohan Hart*
Technical Lead Developer
Fronde
[image: Fronde Logo]
Level 1, 222 Lambton Quay | PO Box 11-545 | Wellington 6011, New Zealand
m. +64 21 937 533 | e. rohan.hart@fronde.com | w. www.fronde.com
--
The information contained in this email is privileged and confidential and
intended for the addressee only. If you are not the intended recipient,
please respect that confidentiality and do not disclose, copy or make use
of its contents. If received in error, please destroy this email and
contact the sender immediately. Thank you.
[-- Attachment #2: Type: text/html, Size: 4398 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs log format
2019-07-23 20:57 ` Rohan Hart
@ 2019-07-24 12:32 ` Lars Ingebrigtsen
2020-08-20 16:01 ` Lars Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-24 12:32 UTC (permalink / raw)
To: Rohan Hart; +Cc: 27453
Rohan Hart <rohan.hart@fronde.com> writes:
> vc-darcs is the emacs package for darcs integration with vc.
>
> If you wished to support very old versions of darcs then keep that complex
> match and put the new one before it. Not that I've tested that config - I just
> override the entire log-view-message-re as I don't use any of those other
> version control systems
As this isn't something I can test myself, can you post a patch to
log-view.el that you've verified works for you?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs log format
2019-07-24 12:32 ` Lars Ingebrigtsen
@ 2020-08-20 16:01 ` Lars Ingebrigtsen
0 siblings, 0 replies; 9+ messages in thread
From: Lars Ingebrigtsen @ 2020-08-20 16:01 UTC (permalink / raw)
To: Rohan Hart; +Cc: 27453
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Rohan Hart <rohan.hart@fronde.com> writes:
>
>> vc-darcs is the emacs package for darcs integration with vc.
>>
>> If you wished to support very old versions of darcs then keep that complex
>> match and put the new one before it. Not that I've tested that config - I just
>> override the entire log-view-message-re as I don't use any of those other
>> version control systems
>
> As this isn't something I can test myself, can you post a patch to
> log-view.el that you've verified works for you?
More information was requested, but no response was given within a yes,
so I'm closing this bug report. If this is something that should still
be worked on, please respond to this email and we'll reopen the bug
report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-08-20 16:01 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-23 0:49 bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs log format Rohan Hart
2019-07-21 17:40 ` Lars Ingebrigtsen
2019-07-21 20:36 ` Rohan Hart
2019-07-22 12:28 ` Lars Ingebrigtsen
2019-07-22 20:42 ` Rohan Hart
2019-07-23 11:31 ` Lars Ingebrigtsen
2019-07-23 20:57 ` Rohan Hart
2019-07-24 12:32 ` Lars Ingebrigtsen
2020-08-20 16:01 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).