bug#25229: 25.1; newline inserted at end of html-href-anchor

bug#25229: 25.1; newline inserted at end of html-href-anchor

[Simon Wright]

From emacs -Q, in the scratch buffer,

M-x html-mode RET

enter "foo."

highlight "foo", point before "."

M-x html-href-anchor RET
sample RET

buffer contains

<a href="sample">foo</a>
.

where it should contain

<a href="sample">foo</a>.

I believe this is down to the same problem as reported in PR16634.

In GNU Emacs 25.1.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version 10.9.5 (Build 13F1911))
of 2016-09-21 built on builder10-9.porkrind.org
Windowing system distributor 'Apple', version 10.3.1504
Configured using:
'configure --with-ns '--enable-locallisppath=/Library/Application
Support/Emacs/${version}/site-lisp:/Library/Application
Support/Emacs/site-lisp' --with-modules'

Configured features:
NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES

Important settings:
  value of $LANG: en_GB.UTF-8
  locale-coding-system: utf-8-unix

Major mode: HTML

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
user-error: The mark is not set now, so there is no region
Mark set
You can run the command ‘html-href-anchor’ with C-c C-c h
mwheel-scroll: Beginning of buffer [17 times]
current-kill: Kill ring is empty
read-number: Command attempted to use minibuffer while in minibuffer

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message dired format-spec rfc822 mml
mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu
cl-loaddefs pcase cl-lib mail-prsvr mail-utils skeleton sgml-mode
time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel ns-win ucs-normalize term/common-win tool-bar dnd
fontset image regexp-opt fringe tabulated-list newcomment elisp-mode
lisp-mode prog-mode register page menu-bar rfn-eshadow timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame
cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian
slovak czech european ethiopic indian cyrillic chinese charscript
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote kqueue cocoa ns
multi-tty make-network-process emacs)

Memory information:
((conses 16 200051 6221)
(symbols 48 19907 0)
(miscs 40 56 148)
(strings 32 16504 5506)
(string-bytes 1 456332)
(vectors 16 33151)
(vector-slots 8 656015 4921)
(floats 8 162 175)
(intervals 56 217 0)
(buffers 976 18))

bug#25229: 25.1; newline inserted at end of html-href-anchor

[nitish chandra]

[-- Attachment #1: Type: text/plain, Size: 3667 bytes --]

This appears to be the default behaviour of all skeletons. AFAIU a newline
is inserted after the insertion of the skeleton. To override this
behaviour, set skeleton-end-newline to nil.

Thanks,
Nitish

On 19 December 2016 at 17:35, Simon Wright <simon@pushface.org> wrote:

> From emacs -Q, in the scratch buffer,
>
> M-x html-mode RET
>
> enter "foo."
>
> highlight "foo", point before "."
>
> M-x html-href-anchor RET
> sample RET
>
> buffer contains
>
> <a href="sample">foo</a>
> .
>
> where it should contain
>
> <a href="sample">foo</a>.
>
> I believe this is down to the same problem as reported in PR16634.
>
> In GNU Emacs 25.1.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version
> 10.9.5 (Build 13F1911))
> of 2016-09-21 built on builder10-9.porkrind.org
> Windowing system distributor 'Apple', version 10.3.1504
> Configured using:
> 'configure --with-ns '--enable-locallisppath=/Library/Application
> Support/Emacs/${version}/site-lisp:/Library/Application
> Support/Emacs/site-lisp' --with-modules'
>
> Configured features:
> NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES
>
> Important settings:
>   value of $LANG: en_GB.UTF-8
>   locale-coding-system: utf-8-unix
>
> Major mode: HTML
>
> Minor modes in effect:
>   tooltip-mode: t
>   global-eldoc-mode: t
>   electric-indent-mode: t
>   mouse-wheel-mode: t
>   tool-bar-mode: t
>   menu-bar-mode: t
>   file-name-shadow-mode: t
>   global-font-lock-mode: t
>   font-lock-mode: t
>   blink-cursor-mode: t
>   auto-composition-mode: t
>   auto-encryption-mode: t
>   auto-compression-mode: t
>   line-number-mode: t
>   transient-mark-mode: t
>
> Recent messages:
> For information about GNU Emacs and the GNU system, type C-h C-a.
> user-error: The mark is not set now, so there is no region
> Mark set
> You can run the command ‘html-href-anchor’ with C-c C-c h
> mwheel-scroll: Beginning of buffer [17 times]
> current-kill: Kill ring is empty
> read-number: Command attempted to use minibuffer while in minibuffer
>
> Load-path shadows:
> None found.
>
> Features:
> (shadow sort mail-extr emacsbug message dired format-spec rfc822 mml
> mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies
> mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
> rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu
> cl-loaddefs pcase cl-lib mail-prsvr mail-utils skeleton sgml-mode
> time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
> lisp-float-type mwheel ns-win ucs-normalize term/common-win tool-bar dnd
> fontset image regexp-opt fringe tabulated-list newcomment elisp-mode
> lisp-mode prog-mode register page menu-bar rfn-eshadow timer select
> scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame
> cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai
> tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian
> slovak czech european ethiopic indian cyrillic chinese charscript
> case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer
> cl-preloaded nadvice loaddefs button faces cus-face macroexp files
> text-properties overlay sha1 md5 base64 format env code-pages mule
> custom widget hashtable-print-readable backquote kqueue cocoa ns
> multi-tty make-network-process emacs)
>
> Memory information:
> ((conses 16 200051 6221)
> (symbols 48 19907 0)
> (miscs 40 56 148)
> (strings 32 16504 5506)
> (string-bytes 1 456332)
> (vectors 16 33151)
> (vector-slots 8 656015 4921)
> (floats 8 162 175)
> (intervals 56 217 0)
> (buffers 976 18))
>
>
>
>

[-- Attachment #2: Type: text/html, Size: 4409 bytes --]

bug#25229: 25.1; newline inserted at end of html-href-anchor

[Simon Wright]

[-- Attachment #1: Type: text/plain, Size: 3959 bytes --]

Thanks for this, which indeed fixes my problem.

No mention of this in skeleton-insert's doc string!

--S

> On 19 Dec 2016, at 15:18, nitish chandra <nitishchandrachinta@gmail.com> wrote:
> 
> This appears to be the default behaviour of all skeletons. AFAIU a newline is inserted after the insertion of the skeleton. To override this behaviour, set skeleton-end-newline to nil.
> 
> Thanks,
> Nitish
> 
> On 19 December 2016 at 17:35, Simon Wright <simon@pushface.org <mailto:simon@pushface.org>> wrote:
> From emacs -Q, in the scratch buffer,
> 
> M-x html-mode RET
> 
> enter "foo."
> 
> highlight "foo", point before "."
> 
> M-x html-href-anchor RET
> sample RET
> 
> buffer contains
> 
> <a href="sample">foo</a>
> .
> 
> where it should contain
> 
> <a href="sample">foo</a>.
> 
> I believe this is down to the same problem as reported in PR16634.
> 
> In GNU Emacs 25.1.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version 10.9.5 (Build 13F1911))
> of 2016-09-21 built on builder10-9.porkrind.org <http://builder10-9.porkrind.org/>
> Windowing system distributor 'Apple', version 10.3.1504
> Configured using:
> 'configure --with-ns '--enable-locallisppath=/Library/Application
> Support/Emacs/${version}/site-lisp:/Library/Application
> Support/Emacs/site-lisp' --with-modules'
> 
> Configured features:
> NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES
> 
> Important settings:
>   value of $LANG: en_GB.UTF-8
>   locale-coding-system: utf-8-unix
> 
> Major mode: HTML
> 
> Minor modes in effect:
>   tooltip-mode: t
>   global-eldoc-mode: t
>   electric-indent-mode: t
>   mouse-wheel-mode: t
>   tool-bar-mode: t
>   menu-bar-mode: t
>   file-name-shadow-mode: t
>   global-font-lock-mode: t
>   font-lock-mode: t
>   blink-cursor-mode: t
>   auto-composition-mode: t
>   auto-encryption-mode: t
>   auto-compression-mode: t
>   line-number-mode: t
>   transient-mark-mode: t
> 
> Recent messages:
> For information about GNU Emacs and the GNU system, type C-h C-a.
> user-error: The mark is not set now, so there is no region
> Mark set
> You can run the command ‘html-href-anchor’ with C-c C-c h
> mwheel-scroll: Beginning of buffer [17 times]
> current-kill: Kill ring is empty
> read-number: Command attempted to use minibuffer while in minibuffer
> 
> Load-path shadows:
> None found.
> 
> Features:
> (shadow sort mail-extr emacsbug message dired format-spec rfc822 mml
> mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies
> mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
> rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu
> cl-loaddefs pcase cl-lib mail-prsvr mail-utils skeleton sgml-mode
> time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
> lisp-float-type mwheel ns-win ucs-normalize term/common-win tool-bar dnd
> fontset image regexp-opt fringe tabulated-list newcomment elisp-mode
> lisp-mode prog-mode register page menu-bar rfn-eshadow timer select
> scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame
> cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai
> tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian
> slovak czech european ethiopic indian cyrillic chinese charscript
> case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer
> cl-preloaded nadvice loaddefs button faces cus-face macroexp files
> text-properties overlay sha1 md5 base64 format env code-pages mule
> custom widget hashtable-print-readable backquote kqueue cocoa ns
> multi-tty make-network-process emacs)
> 
> Memory information:
> ((conses 16 200051 6221)
> (symbols 48 19907 0)
> (miscs 40 56 148)
> (strings 32 16504 5506)
> (string-bytes 1 456332)
> (vectors 16 33151)
> (vector-slots 8 656015 4921)
> (floats 8 162 175)
> (intervals 56 217 0)
> (buffers 976 18))
> 
> 
> 
> 


[-- Attachment #2: Type: text/html, Size: 6200 bytes --]

bug#25229: Not a bug

[nitish chandra]

[-- Attachment #1: Type: text/plain, Size: 91 bytes --]

Closing this as this is a confusion arising out of undocumented behaviour.

Thanks,
Nitish

[-- Attachment #2: Type: text/html, Size: 147 bytes --]

bug#25229: 25.1; newline inserted at end of html-href-anchor

[npostavs]

tags 25229 notabug
quit

Simon Wright <simon@pushface.org> writes:

> Thanks for this, which indeed fixes my problem.
>
> No mention of this in skeleton-insert's doc string!

I've updated the documentation of skeleton-insert.

http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=88cdf14b37a7344bb266e94512485e3cc738c23d

bug#25229: 25.1; newline inserted at end of html-href-anchor

[Simon Wright]

Thanks, but ... shouldn't that be "(unless `skeleton-end-newline' is nil)"?

@@ -187,6 +186,10 @@ The optional third argument STR, if specified, is the value for the
 variable `str' within the skeleton.  When this is non-nil, the
 interactor gets ignored, and this should be a valid skeleton element.
 
+When done with skeleton, but before going back to `_'-point, add
+a newline (unless `skeleton-end-newline' is non-nil) and run the
+hook `skeleton-end-hook'.
+
 SKELETON is made up as (INTERACTOR ELEMENT ...).  INTERACTOR may be nil if
 not needed, a prompt-string or an expression for complex read functions.

> On 20 Dec 2016, at 01:08, npostavs@users.sourceforge.net wrote:
> 
> tags 25229 notabug
> quit
> 
> Simon Wright <simon@pushface.org> writes:
> 
>> Thanks for this, which indeed fixes my problem.
>> 
>> No mention of this in skeleton-insert's doc string!
> 
> I've updated the documentation of skeleton-insert.
> 
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=88cdf14b37a7344bb266e94512485e3cc738c23d
> 

bug#25229: 25.1; newline inserted at end of html-href-anchor

[npostavs]

Simon Wright <simon@pushface.org> writes:

> Thanks, but ... shouldn't that be "(unless `skeleton-end-newline' is
> nil)"?

Oops!  Thanks for catching that.  Fixed.

http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=cf1f9852d0e8d571dfe74486c26417828faa945a