bug#14860: [Peter Vasil] emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0

bug#14860: [Peter Vasil] emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0

[Stefan Monnier]

[-- Attachment #1: Type: text/plain, Size: 42 bytes --]

[ Making it into a proper bug-report.  ]


[-- Attachment #2: Type: message/rfc822, Size: 4927 bytes --]

From: Peter Vasil <mailing_lists@petervasil.net>
To: emacs-devel@gnu.org
Subject: emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0
Date: Sat, 13 Jul 2013 13:02:24 +0200
Message-ID: <CAJe0aUT2y2t_=YzrKt_aas7baeEen97MKrbMP0OCQJD2vnG7Ew@mail.gmail.com>

Hi list,

I have the following function in my init.el file

(defun goto-line-with-feedback ()
  "Show line numbers temporarily, while prompting for the line number input"
  (interactive)
  (let ((line-numbers-off-p (if (boundp 'linum-mode)
                                (not linum-mode)
                              t)))
    (unwind-protect
        (progn
          (when line-numbers-off-p
            (linum-mode 1))
          (call-interactively 'goto-line))
      (when line-numbers-off-p
        (linum-mode -1)))))

When I byte-compile init.el I get the following warning:
function goto-line-with-feedback used to take 0+ arguments, now takes 0

With emacs 24.3 I don't get this warning only with emacs trunk.
I am on revision 113411

Thanks,
Peter

bug#14860: [Peter Vasil] emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0

[Stefan Monnier]

> (defun goto-line-with-feedback ()
>   "Show line numbers temporarily, while prompting for the line number input"
>   (interactive)
>   (let ((line-numbers-off-p (if (boundp 'linum-mode)
>                                 (not linum-mode)
>                               t)))
>     (unwind-protect
>         (progn
>           (when line-numbers-off-p
>             (linum-mode 1))
>           (call-interactively 'goto-line))
>       (when line-numbers-off-p
>         (linum-mode -1)))))

> When I byte-compile init.el I get the following warning:
> function goto-line-with-feedback used to take 0+ arguments, now takes 0

I can't reproduce this here.  What does C-h f goto-line-with-feedback RET
say, after starting an Emacs session?


        Stefan

bug#14860: [Peter Vasil] emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0

[Michael Heerdegen]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> > When I byte-compile init.el I get the following warning:
> > function goto-line-with-feedback used to take 0+ arguments, now takes 0

FWIW, I get exactly the same message when using nadvices.  Example: put
this into a file:

--8<---------------cut here---------------start------------->8---
(defun test () (message "test"))

(advice-add 'test :before
            (lambda () (message "before advice")))
--8<---------------cut here---------------end--------------->8---

load it, and byte-compile it:

==>

| In test:
| test.el:1:8:Warning: function test used to take 0+ arguments, now takes 0


Regards,

Michael.

bug#14860: [Peter Vasil] emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0

[Stefan Monnier]

>> > When I byte-compile init.el I get the following warning:
>> > function goto-line-with-feedback used to take 0+ arguments, now takes 0
> FWIW, I get exactly the same message when using nadvices.  Example: put

That's expected, yes.  But in his case it's on a user-defined function,
so it seems unlikely he put an advice on it.


        Stefan

bug#14860: [Peter Vasil] emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0

[Peter Vasil]

Indeed, I have an advice on that function

(defadvice goto-line-with-feedback
    (after
     expand-after-goto-line-with-feedback
     activate compile)
    "hideshow-expand affected block when using
goto-line-with-feedback in a collapsed buffer"
    (save-excursion
      (hs-show-block)))

Peter

On Sun, Jul 14, 2013 at 1:35 AM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
> [ Making it into a proper bug-report.  ]
>
>
>
> ---------- Forwarded message ----------
> From: Peter Vasil <mailing_lists@petervasil.net>
> To: emacs-devel@gnu.org
> Cc:
> Date: Sat, 13 Jul 2013 13:02:24 +0200
> Subject: emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0
> Hi list,
>
> I have the following function in my init.el file
>
> (defun goto-line-with-feedback ()
>   "Show line numbers temporarily, while prompting for the line number input"
>   (interactive)
>   (let ((line-numbers-off-p (if (boundp 'linum-mode)
>                                 (not linum-mode)
>                               t)))
>     (unwind-protect
>         (progn
>           (when line-numbers-off-p
>             (linum-mode 1))
>           (call-interactively 'goto-line))
>       (when line-numbers-off-p
>         (linum-mode -1)))))
>
> When I byte-compile init.el I get the following warning:
> function goto-line-with-feedback used to take 0+ arguments, now takes 0
>
> With emacs 24.3 I don't get this warning only with emacs trunk.
> I am on revision 113411
>
> Thanks,
> Peter
>

bug#14860: [Peter Vasil] emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0

[Stefan Monnier]

> Indeed, I have an advice on that function
> (defadvice goto-line-with-feedback
>     (after
>      expand-after-goto-line-with-feedback
>      activate compile)
>     "hideshow-expand affected block when using
> goto-line-with-feedback in a collapsed buffer"
>     (save-excursion
>       (hs-show-block)))

Than it's a known issue.  I do wonder, tho: why on earth do you have an
advice on your hand-written function?


        Stefan

bug#14860: [Peter Vasil] emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0

[Peter Vasil]

I had the advice only because I adviced the regular goto-line to call
hs-show-block and when I added the got-line-with-feedback I just
copied the first advice and did not realize that it makes no sense. I
have removed the advice now and I've put the hs-show-block into
got-line-with-feedback function.

Sorry for the noise.

Peter

On Sun, Jul 14, 2013 at 7:41 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>> Indeed, I have an advice on that function
>> (defadvice goto-line-with-feedback
>>     (after
>>      expand-after-goto-line-with-feedback
>>      activate compile)
>>     "hideshow-expand affected block when using
>> goto-line-with-feedback in a collapsed buffer"
>>     (save-excursion
>>       (hs-show-block)))
>
> Than it's a known issue.  I do wonder, tho: why on earth do you have an
> advice on your hand-written function?
>
>
>         Stefan