unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#18938: Emacs 24.3: newline-and-indent has two undo boundaries
@ 2014-11-03 19:25 Samuel Wales
       [not found] ` <handler.18938.B.141504274132691.ack@debbugs.gnu.org>
  2018-05-31 23:55 ` bug#18938: Emacs 24.3: newline-and-indent has two undo boundaries Noam Postavsky
  0 siblings, 2 replies; 4+ messages in thread
From: Samuel Wales @ 2014-11-03 19:25 UTC (permalink / raw)
  To: 18938, monnier; +Cc: Bastien, 11774-done, Martin Pohlack, Toby Cubitt

Reporting as suggested by Stefan.

In order to bunch up undos by 1 instead of the hardcoded 20, I do this:

  (add-hook 'post-self-insert-hook #'undo-boundary 'append)

This or advice used to work, then around Emacs 24.1 it stopped
working.  Stefan patched it in 24.3.  It now works in most cases.  The
history is in this Debian bug:

  Re: [O] bug#11774: bug#11774: org-mode causes undo boundaries to be lost

I use undo-tree 0.6.6.  The bug also occurs with it turned off.

When I press RET when it is bound to newline-and-indent, the newline
and the indentation are undone separately.  I expected the RET to be
undone.

This is a minor issue for me, but might point to other cases.

Thanks.

Samuel





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#18938: Acknowledgement (Emacs 24.3: newline-and-indent has two undo boundaries)
       [not found] ` <handler.18938.B.141504274132691.ack@debbugs.gnu.org>
@ 2014-11-20 23:01   ` Samuel Wales
  0 siblings, 0 replies; 4+ messages in thread
From: Samuel Wales @ 2014-11-20 23:01 UTC (permalink / raw)
  To: 18938

I found more places where this bug occurs.  A major [i.e. common] one
is that M-RET in Org will create a new headline, but undo requires two
steps.

-- 
The Kafka Pandemic: http://thekafkapandemic.blogspot.com

The disease DOES progress.  MANY people have died from it.  And
ANYBODY can get it.

Denmark: free Karina Hansen NOW.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#18938: Emacs 24.3: newline-and-indent has two undo boundaries
  2014-11-03 19:25 bug#18938: Emacs 24.3: newline-and-indent has two undo boundaries Samuel Wales
       [not found] ` <handler.18938.B.141504274132691.ack@debbugs.gnu.org>
@ 2018-05-31 23:55 ` Noam Postavsky
  2018-06-01  0:20   ` Samuel Wales
  1 sibling, 1 reply; 4+ messages in thread
From: Noam Postavsky @ 2018-05-31 23:55 UTC (permalink / raw)
  To: Samuel Wales; +Cc: Bastien, Martin Pohlack, Toby Cubitt, monnier, 18938

tags 18938 fixed
close 18938 24.4
quit

Samuel Wales <samologist@gmail.com> writes:

> Reporting as suggested by Stefan.
>
> In order to bunch up undos by 1 instead of the hardcoded 20, I do this:
>
>   (add-hook 'post-self-insert-hook #'undo-boundary 'append)
>
> This or advice used to work, then around Emacs 24.1 it stopped
> working.  Stefan patched it in 24.3.  It now works in most cases.  The
> history is in this Debian bug:
>
>   Re: [O] bug#11774: bug#11774: org-mode causes undo boundaries to be lost
>
> I use undo-tree 0.6.6.  The bug also occurs with it turned off.
>
> When I press RET when it is bound to newline-and-indent, the newline
> and the indentation are undone separately.  I expected the RET to be
> undone.

Seems to be fixed in 24.4





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#18938: Emacs 24.3: newline-and-indent has two undo boundaries
  2018-05-31 23:55 ` bug#18938: Emacs 24.3: newline-and-indent has two undo boundaries Noam Postavsky
@ 2018-06-01  0:20   ` Samuel Wales
  0 siblings, 0 replies; 4+ messages in thread
From: Samuel Wales @ 2018-06-01  0:20 UTC (permalink / raw)
  To: Noam Postavsky; +Cc: Bastien, Martin Pohlack, Toby Cubitt, monnier, 18938

yes, it seems to be fixed in 24.4.1 on debian jessie.  i do not have
access to other versions.

thank you.

On 5/31/18, Noam Postavsky <npostavs@gmail.com> wrote:
> tags 18938 fixed
> close 18938 24.4
> quit
>
> Samuel Wales <samologist@gmail.com> writes:
>
>> Reporting as suggested by Stefan.
>>
>> In order to bunch up undos by 1 instead of the hardcoded 20, I do this:
>>
>>   (add-hook 'post-self-insert-hook #'undo-boundary 'append)
>>
>> This or advice used to work, then around Emacs 24.1 it stopped
>> working.  Stefan patched it in 24.3.  It now works in most cases.  The
>> history is in this Debian bug:
>>
>>   Re: [O] bug#11774: bug#11774: org-mode causes undo boundaries to be
>> lost
>>
>> I use undo-tree 0.6.6.  The bug also occurs with it turned off.
>>
>> When I press RET when it is bound to newline-and-indent, the newline
>> and the indentation are undone separately.  I expected the RET to be
>> undone.
>
> Seems to be fixed in 24.4
>


-- 
The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>

The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.

"You’ve really gotta quit this and get moving, because this is murder
by neglect." ---
<http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-06-01  0:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-03 19:25 bug#18938: Emacs 24.3: newline-and-indent has two undo boundaries Samuel Wales
     [not found] ` <handler.18938.B.141504274132691.ack@debbugs.gnu.org>
2014-11-20 23:01   ` bug#18938: Acknowledgement (Emacs 24.3: newline-and-indent has two undo boundaries) Samuel Wales
2018-05-31 23:55 ` bug#18938: Emacs 24.3: newline-and-indent has two undo boundaries Noam Postavsky
2018-06-01  0:20   ` Samuel Wales

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).