bug#55455: [macOS] Fix build when using brew's libgccjit

bug#55455: [macOS] Fix build when using brew's libgccjit

[John Buckley]

[-- Attachment #1.1: Type: text/plain, Size: 845 bytes --]

libgccjit installed via Homebrew now uses the correct .dylib dynamic library
extension on macOS. This causes configure to fail because it is still
using the .so extension.

The attached patch fixes the libgccjit library extension in configure.ac

In GNU Emacs 28.1.50 (build 2, x86_64-apple-darwin21.4.0, NS appkit-2113.40
Version 12.3.1 (Build 21E258))
 of 2022-04-25 built on iMac-Pro.local
Repository revision: 7c1fc2348918a1ad8c61c7519a51042d48d7aa8d
Repository branch: emacs-28
Windowing system distributor 'Apple', version 10.3.2113
System Description:  macOS 12.3.1

Configured using:
 'configure --with-native-compilation'

Configured features:
ACL GMP GNUTLS JSON LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER
THREADS TOOLKIT_SCROLL_BARS ZLIB

Important settings:
  value of $LANG: en_GB.UTF-8
  locale-coding-system: utf-8-unix

[-- Attachment #1.2: Type: text/html, Size: 1135 bytes --]

[-- Attachment #2: configure.ac.patch --]
[-- Type: application/octet-stream, Size: 501 bytes --]

diff --git a/configure.ac b/configure.ac
index 7314eb6978..9ed064b184 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3844,7 +3844,7 @@ AC_DEFUN
           MAC_CFLAGS="-I$(dirname $($BREW ls -v libgccjit | \
                                                 grep libgccjit.h))"
           MAC_LIBS="-L$(dirname $($BREW ls -v libgccjit| \
-                                            grep libgccjit.so\$))"
+                                            grep libgccjit.dylib\$))"
         fi
       fi
 

bug#55455: [macOS] Fix build when using brew's libgccjit

[Robert Pluim]

merge 55173 55455
tags 55455 fixed
close 55455 29.1
quit

>>>>> On Mon, 16 May 2022 12:38:14 +0100, John Buckley <nhoj.buckley@gmail.com> said:

    John> libgccjit installed via Homebrew now uses the correct .dylib dynamic library
    John> extension on macOS. This causes configure to fail because it is still
    John> using the .so extension.

    John> The attached patch fixes the libgccjit library extension in configure.ac

This was fixed on master in a more backwards compatible way already
for bug#55173 by commit faa29fa2c9

Closing.

Robert
-- 
Closing.

bug#55455: [macOS] Fix build when using brew's libgccjit

[John Buckley]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

A little more info:

- This patch will not currently work on ARM64 because brew's libgccjit is
using a fork for ARM. The .so -> .dylib fix for macOS has not been
incorporated into the fork yet.
- I forgot to add the [PATCH] prefix to this issue. Apologies.

For more context please see:
https://github.com/Homebrew/homebrew-core/issues/101673

[-- Attachment #2: Type: text/html, Size: 540 bytes --]

bug#55455: [macOS] Fix build when using brew's libgccjit

[Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors]

John Buckley <nhoj.buckley@gmail.com> writes:

> libgccjit installed via Homebrew now uses the correct .dylib dynamic library
> extension on macOS. This causes configure to fail because it is still
> using the .so extension.
>
> The attached patch fixes the libgccjit library extension in
> configure.ac

I think this is a duplicate of bug#55173, which should be fixed already.
Could you try to build Emacs with native compilation from the master
branch?

bug#55455: [macOS] Fix build when using brew's libgccjit

[Eli Zaretskii]

> From: John Buckley <nhoj.buckley@gmail.com>
> Date: Mon, 16 May 2022 12:38:14 +0100
> 
> libgccjit installed via Homebrew now uses the correct .dylib dynamic library
> extension on macOS.

By "now" do you mean in some recent enough version?  That is, older
versions will still use the .so extension?

> This causes configure to fail because it is still
> using the .so extension.
> 
> The attached patch fixes the libgccjit library extension in configure.ac

Shouldn't we try both extensions?

Thanks.

bug#55455: [macOS] Fix build when using brew's libgccjit

[John Buckley]

[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]

> Daniel Martin <mardani29@yahoo.es>

> I think this is a duplicate of bug#55173, which should be fixed already.
> Could you try to build Emacs with native compilation from the
master branch?

Yes it is as confirmed by Robert.
All is ok now on `master`. I've been on emacs-28 for a while now, probably
time to move to master.

> Eli Zaretskii <eliz@gnu.org>

> By "now" do you mean in some recent enough version?  That is, older
> versions will still use the .so extension?

Older versions of gcc used the wrong dynamic library extension for
libgccjit on macOS. Brew on X86_64 uses the latest version. However, brew on
ARM64 is still using the .so version because it depends on an older fork of
gcc. So both need to be supported.

> Shouldn't we try both extensions?

The fix in master does this correctly.

Thanks for the comments - all resolved now.

On Mon, 16 May 2022 at 17:23, Eli Zaretskii <eliz@gnu.org> wrote:

> > From: John Buckley <nhoj.buckley@gmail.com>
> > Date: Mon, 16 May 2022 12:38:14 +0100
> >
> > libgccjit installed via Homebrew now uses the correct .dylib dynamic
> library
> > extension on macOS.
>
> By "now" do you mean in some recent enough version?  That is, older
> versions will still use the .so extension?
>
> > This causes configure to fail because it is still
> > using the .so extension.
> >
> > The attached patch fixes the libgccjit library extension in configure.ac
>
> Shouldn't we try both extensions?
>
> Thanks.
>

[-- Attachment #2: Type: text/html, Size: 2659 bytes --]