bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Aaron Jensen]

Bisected to 4a6302330384ad89bcfccce6b563eb5462b753a9

Before that, request with multi-byte characters in them were successful.
Afterwards, they get the error:

error in process sentinel: url-http-create-request: Multibyte text in
HTTP request: POST /repos/user/repo/pulls HTTP/1.1

Perhaps the thing doing the requesting should be setting Content-Type to
include charset=utf-8?


In GNU Emacs 27.0.50 (build 1, x86_64-apple-darwin17.5.0, NS appkit-1561.40 Version 10.13.4 (Build 17E199))
 of 2018-04-23 built on aaron-mbt.local
Repository revision: 0ecc10a7771bf1f62d15b2e6c747bee9f7a557ff
Windowing system distributor 'Apple', version 10.3.1561
System Description:  Mac OS X 10.13.4

Recent messages:
Host: api.github.com
Accept-encoding: gzip
Accept: */*
User-Agent: URL/Emacs Emacs/27.0.50 (OpenStep; x86_64-apple-darwin17.5.0)
Cookie: logged_in=no
Authorization: token xxxxxxxxxxxx
Content-Type: application/json
Content-length: 677

{"maintainer_can_modify":true,"title":"test","body":"<!-- boilerplate -->\nŸ’ Please complete and/or check off the following before submitting for review:\n\n#### Ÿ“ Zero-Downtime Deployment\n\n- [ ] All migrations are safe for zero-downtime deployment. [strong_migrations][] should catch most issues.\n- [ ] All removed APIs were previously removed from the client and deployed for at least 2 weeks.\n- [ ] No additions to the Algolia index are required for any searches to work. Updates to the index have already been deployed in a previous PR and reindexing is complete.\n\n[strong_migrations]: https://github.com/ankane/strong_migrations","base":"master","head":"test"}

Configured using:
 'configure --disable-dependency-tracking --disable-silent-rules
 --enable-locallisppath=/usr/local/share/emacs/site-lisp
 --infodir=/usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/info/emacs
 --prefix=/usr/local/Cellar/emacs-plus/HEAD-0ecc10a --with-xml2
 --without-dbus --with-gnutls --with-imagemagick --with-modules
 --with-rsvg --with-ns --disable-ns-self-contained'

Configured features:
RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS
MODULES THREADS

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Messages

Minor modes in effect:
  magit-auto-revert-mode: t
  company-statistics-mode: t
  company-childframe-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  auto-dim-other-buffers-mode: t
  global-git-gutter+-mode: t
  global-git-commit-mode: t
  async-bytecomp-package-mode: t
  recentf-mode: t
  desktop-save-mode: t
  global-wakatime-mode: t
  wakatime-mode: t
  global-spacemacs-whitespace-cleanup-mode: t
  spacemacs-whitespace-cleanup-mode: t
  ws-butler-global-mode: t
  ws-butler-mode: t
  winum-mode: t
  winner-mode: t
  pupo-mode: t
  purpose-mode: t
  volatile-highlights-mode: t
  global-vi-tilde-fringe-mode: t
  vi-tilde-fringe-mode: t
  save-place-mode: t
  savehist-mode: t
  projectile-rails-global-mode: t
  projectile-mode: t
  persp-mode: t
  global-origami-mode: t
  origami-mode: t
  Info-breadcrumbs-in-mode-line-mode: t
  flycheck-pos-tip-mode: t
  global-flycheck-mode: t
  flx-ido-mode: t
  eyebrowse-mode: t
  global-evil-surround-mode: t
  evil-surround-mode: t
  global-evil-search-highlight-persist: t
  evil-search-highlight-persist: t
  show-smartparens-global-mode: t
  evil-lion-mode: t
  evil-escape-mode: t
  global-anzu-mode: t
  anzu-mode: t
  eval-sexp-fu-flash-mode: t
  editorconfig-mode: t
  diff-auto-refine-mode: t
  counsel-mode: t
  ivy-mode: t
  delete-selection-mode: t
  clean-aindent-mode: t
  hybrid-mode: t
  which-key-mode: t
  override-global-mode: t
  global-undo-tree-mode: t
  undo-tree-mode: t
  evil-mode: t
  evil-local-mode: t
  spacemacs-leader-override-mode: t
  global-spacemacs-leader-override-mode: t
  global-hl-line-mode: t
  xterm-mouse-mode: t
  global-auto-revert-mode: t
  shell-dirtrack-mode: t
  ido-vertical-mode: t
  global-page-break-lines-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t

Load-path shadows:
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/ht-20180129.1434/ht hides /Users/aaronjensen/.emacs.d/core/libs/ht
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/inf-ruby-20180309.433/inf-ruby hides /usr/local/share/emacs/site-lisp/ruby/inf-ruby
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-stan hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-stan
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-exp hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-exp
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-J hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-J
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-eshell hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-eshell
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-emacs-lisp hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-emacs-lisp
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-gnus hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-gnus
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-css hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-css
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-lob hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-lob
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-forth hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-forth
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-macs hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-macs
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-version hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-version
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-scheme hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-scheme
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ox hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ox
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-abc hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-abc
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-C hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-C
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-capture hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-capture
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-ref hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-ref
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-clojure hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-clojure
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-mouse hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-mouse
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-ledger hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-ledger
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-ctags hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-ctags
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-entities hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-entities
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-archive hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-archive
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-screen hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-screen
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-haskell hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-haskell
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-asymptote hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-asymptote
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-mhe hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-mhe
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-table hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-table
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-keys hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-keys
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ox-org hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ox-org
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-plot hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-plot
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-awk hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-awk
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-groovy hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-groovy
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-octave hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-octave
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-faces hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-faces
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-colview hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-colview
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-R hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-R
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-timer hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-timer
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-ebnf hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-ebnf
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-mobile hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-mobile
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-fortran hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-fortran
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-shell hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-shell
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-perl hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-perl
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-sqlite hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-sqlite
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-sed hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-sed
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-list hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-list
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-ruby hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-ruby
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-eval hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-eval
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-habit hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-habit
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-clock hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-clock
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ox-html hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ox-html
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-src hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-src
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-lisp hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-lisp
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-ditaa hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-ditaa
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-pcomplete hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-pcomplete
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-lint hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-lint
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-rmail hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-rmail
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ox-latex hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ox-latex
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-sass hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-sass
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-io hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-io
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-tangle hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-tangle
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-calc hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-calc
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-java hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-java
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ox-icalendar hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ox-icalendar
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-eww hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-eww
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ox-md hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ox-md
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ox-beamer hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ox-beamer
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-element hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-element
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-protocol hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-protocol
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-mscgen hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-mscgen
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-gnuplot hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-gnuplot
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-latex hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-latex
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-id hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-id
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-vala hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-vala
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ox-man hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ox-man
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-feed hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-feed
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-lua hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-lua
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-table hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-table
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-ocaml hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-ocaml
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-coq hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-coq
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-picolisp hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-picolisp
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-indent hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-indent
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-lilypond hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-lilypond
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-matlab hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-matlab
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-datetree hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-datetree
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-python hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-python
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-bbdb hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-bbdb
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-makefile hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-makefile
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-duration hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-duration
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-agenda hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-agenda
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-dot hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-dot
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-js hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-js
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ox-publish hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ox-publish
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-inlinetask hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-inlinetask
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-org hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-org
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-core hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-core
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-compat hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-compat
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-docview hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-docview
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ox-odt hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ox-odt
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-plantuml hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-plantuml
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ox-ascii hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ox-ascii
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-loaddefs hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-loaddefs
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-w3m hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-w3m
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-bibtex hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-bibtex
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-info hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-info
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-hledger hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-hledger
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-maxima hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-maxima
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-macro hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-macro
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-sql hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-sql
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-attach hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-attach
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-processing hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-processing
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ox-texinfo hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ox-texinfo
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-irc hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-irc
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-crypt hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-crypt
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-footnote hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-footnote
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/org-install hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/org-install
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-comint hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-comint
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20180416/ob-shen hides /usr/local/Cellar/emacs-plus/HEAD-0ecc10a/share/emacs/27.0.50/lisp/org/ob-shen

Features:
(shadow sort mail-extr magithub-completion company-emoji
company-emoji-list mmm-mode mmm-univ mmm-class mmm-region mmm-auto
mmm-vars mmm-utils mmm-compat org-rmail org-mhe org-irc org-info
org-gnus nnir gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap
nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range
gnus-win gnus nnheader org-docview doc-view jka-compr org-bibtex bibtex
org-bbdb org-w3m org-checklist org-inlinetask org-table smartparens-org
ob-elixir ob-http ob-http-mode ob-restclient restclient ox-gfm ox-md
ox-reveal ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util
rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex
ox-icalendar ox-html table ox-ascii ox-publish ox orgit org-element
avl-tree generator org org-macro org-footnote org-pcomplete org-list
org-faces org-entities org-version ob-emacs-lisp ob ob-tangle org-src
ob-ref ob-lob ob-table ob-keys ob-exp ob-comint ob-core ob-eval
org-compat org-macs org-loaddefs cal-menu calendar cal-loaddefs
network-stream starttls url-cache epa-file magit-gitflow magithub
magithub-dash magithub-notification magithub-issue-view magithub-comment
magithub-repo magithub-orgs magithub-issue-tricks magithub-issue-post
magithub-edit-mode magithub-ci magithub-issue magithub-label
magithub-user magithub-core magithub-faces magithub-settings
smartparens-markdown markdown-mode ghub+ apiwrap apropos evil-magit
git-rebase magit-gh-pulls gh gh-users gh-issues gh-pulls gh-repos
gh-comments gh-gist gh-oauth gh-api logito gh-cache gh-auth gh-url
gh-profile magit-obsolete magit-blame magit-stash magit-bisect
magit-remote magit-commit magit-sequence magit-notes magit-worktree
magit-tag magit-merge magit-branch magit-reset magit-collab ghub
url-http tls gnutls url-gw nsm url-auth url url-proxy url-privacy
url-expand url-methods url-history url-cookie url-domsuf mailcap
magit-files magit-refs magit-status magit magit-repos magit-apply
magit-wip magit-log magit-diff smerge-mode magit-core magit-autorevert
magit-process magit-margin magit-mode shrink-path vc-git open-junk-file
eslintd-fix flow-minor-mode flycheck-flow company-statistics
company-files company-keywords company-capf company-dabbrev-code
company-dabbrev company-flow company-childframe company js-doc iswitchb
js2-imenu-extras js2-refactor js2r-paredit js2r-conveniences
js2r-conditionals js2r-wrapping js2r-functions js2r-vars
multiple-cursors-core js2r-iife js2r-formatting js2r-helpers skewer-mode
cache-table simple-httpd pp url-util add-node-modules-path goto-addr
bug-reference auto-highlight-symbol dtrt-indent highlight-numbers
parent-mode highlight-parentheses hideshow rainbow-delimiters
yasnippet-snippets yasnippet flycheck-credo flycheck-posframe posframe
elec-pair cursor-sensor rjsx-mode js2-mode smartparens-javascript js
smartparens-html sgml-mode dom cc-mode cc-fonts cc-guess cc-menus
cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs editorconfig-core
editorconfig-core-handle editorconfig-fnmatch face-remap
auto-dim-other-buffers emacsbug sendmail colir smex git-gutter-fringe+
fringe-helper git-gutter+ git-commit with-editor magit-git magit-section
magit-utils crm magit-popup async-bytecomp async log-edit message rmc
puny rfc822 mml mml-sec epa gnus-util rmail rmail-loaddefs mailabbrev
mail-utils gmm-utils mailheader pcvs-util add-log recentf tree-widget
desktop frameset wakatime-mode contextual-menubar quiet-emacs
fill-or-unfill init-macos-terminal-copy-paste init-terminal-cursor
evil-terminal-cursor-changer init-org init-magit evil-mc
evil-mc-command-execute evil-mc-command-record evil-mc-cursor-make
evil-mc-region evil-mc-cursor-state evil-mc-undo evil-mc-vars
evil-mc-known-commands evil-mc-common hl-todo persistent-soft list-utils
pcache eieio-base font-utils server zone xterm-color
spacemacs-whitespace-cleanup ws-butler winum winner
spacemacs-purpose-popwin window-purpose-x imenu-list imenu
window-purpose window-purpose-fixes window-purpose-prefix-overload
window-purpose-switch window-purpose-layout window-purpose-core
window-purpose-configuration window-purpose-utils volatile-highlights
vi-tilde-fringe unicode-fonts tmux string-inflection smartparens-config
smartparens-text smartparens-ruby saveplace savehist ruby-test-mode
pcre2el rxt re-builder projectile-rails rake f inflections inf-ruby
ruby-mode smie projectile grep ibuf-ext ibuffer ibuffer-loaddefs popwin
persp-mode osx-trash origami origami-parsers s linum ivy-hydra info+
image-mode google-c-style flycheck-pos-tip pos-tip flycheck-jest
flycheck find-func flx-ido eyebrowse evil-surround
evil-search-highlight-persist evil-numbers evil-lisp-state smartparens
dash evil-lion evil-indent-plus evil-exchange evil-escape evil-args
evil-anzu anzu eval-sexp-fu highlight font-lock+ frame-fns avoid
editorconfig noutline outline doom-modeline let-alist
powerline-separators color all-the-icons all-the-icons-faces
data-material data-weathericons data-octicons data-fileicons
data-faicons data-alltheicons memoize diff-hl vc-dir ewoc vc
vc-dispatcher diff-mode counsel dired dired-loaddefs compile esh-util
etags xref project swiper ivy flx delsel ivy-overlay ffap
clean-aindent-mode adaptive-wrap gh-common marshal fix-word rx
docker-tramp tramp-cache hybrid-mode evil-evilified-state which-key
use-package use-package-ensure use-package-delight use-package-diminish
use-package-bind-key bind-key use-package-core hydra lv
exec-path-from-shell cus-edit cus-start cus-load time-date evil
evil-integration undo-tree diff evil-maps evil-commands reveal flyspell
ispell evil-jumps evil-command-window evil-types evil-search evil-ex
evil-macros evil-repeat evil-states evil-core evil-common windmove
thingatpt rect evil-digraphs diminish evil-vars bind-map quelpa help-fns
radix-tree package-build mm-decode mm-bodies mm-encode mail-parse
rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr lisp-mnt hl-line
xt-mouse autorevert filenotify cl-extra disp-table wid-edit
monokai-theme info finder-inf patch-server init-sass init-php init-html
init-evil tramp trampver tramp-compat tramp-loaddefs shell pcomplete
comint ansi-color ring parse-time format-spec ido-vertical-mode ido
core-spacemacs core-use-package-ext core-transient-state
core-micro-state core-toggle core-keybindings core-fonts-support
core-themes-support core-display-init core-jump core-release-management
core-custom-settings core-configuration-layer eieio-compat
core-spacemacs-buffer core-funcs core-dotspacemacs ht cl help-mode
warnings package url-handlers url-parse auth-source cl-seq
password-cache json map url-vars seq eieio byte-opt bytecomp
byte-compile cconv eieio-core eieio-loaddefs epg epg-config
core-command-line pcase core-debug edmacro kmacro derived cl-macs gv
advice profiler easymenu cl-loaddefs cl-lib page-break-lines easy-mmode
core-emacs-backports subr-x tooltip eldoc electric uniquify ediff-hook
vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize
mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow isearch timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote kqueue cocoa ns multi-tty make-network-process emacs)

Memory information:
((conses 16 1586197 397512)
 (symbols 48 85860 1)
 (miscs 40 607 1476)
 (strings 32 394057 101168)
 (string-bytes 1 14943681)
 (vectors 16 129981)
 (vector-slots 8 2021288 676116)
 (floats 8 995 976)
 (intervals 56 10679 207)
 (buffers 992 23))

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Lars Ingebrigtsen]

Aaron Jensen <aaronjensen@gmail.com> writes:

> Before that, request with multi-byte characters in them were successful.
> Afterwards, they get the error:
>
> error in process sentinel: url-http-create-request: Multibyte text in
> HTTP request: POST /repos/user/repo/pulls HTTP/1.1

Is the multibyte text in the headers or in the POST?  There's nothing
that looks multibytey in the headers of the HTTP request you included,
but the body looked suspicious.  However, that commit doesn't seem to
affect the body at all, so I'm not sure how that commit could lead to a
regression in the POST body...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Aaron Jensen]

On Mon, Apr 23, 2018 at 10:04 AM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Aaron Jensen <aaronjensen@gmail.com> writes:
>
> Is the multibyte text in the headers or in the POST?  There's nothing
> that looks multibytey in the headers of the HTTP request you included,
> but the body looked suspicious.  However, that commit doesn't seem to
> affect the body at all, so I'm not sure how that commit could lead to a
> regression in the POST body...

It's in the post body only AFAICT. They're emoji: 📦 and 💁

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Lars Ingebrigtsen]

Aaron Jensen <aaronjensen@gmail.com> writes:

> On Mon, Apr 23, 2018 at 10:04 AM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
>> Aaron Jensen <aaronjensen@gmail.com> writes:
>>
>> Is the multibyte text in the headers or in the POST?  There's nothing
>> that looks multibytey in the headers of the HTTP request you included,
>> but the body looked suspicious.  However, that commit doesn't seem to
>> affect the body at all, so I'm not sure how that commit could lead to a
>> regression in the POST body...
>
> It's in the post body only AFAICT. They're emoji: 📦 and 💁

And reverting 4a6302330384 makes things work?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Aaron Jensen]

On Mon, Apr 23, 2018 at 11:55 AM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> And reverting 4a6302330384 makes things work?

I'm not on my home machine where I was testing it, so I haven't tried
reverting 4a6302330384 on the current master, but it worked on the
parent of 4a6302330384.

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Lars Ingebrigtsen]

Aaron Jensen <aaronjensen@gmail.com> writes:

> On Mon, Apr 23, 2018 at 11:55 AM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
>> And reverting 4a6302330384 makes things work?
>
> I'm not on my home machine where I was testing it, so I haven't tried
> reverting 4a6302330384 on the current master, but it worked on the
> parent of 4a6302330384.

Do you have a test case to trigger this bug?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Aaron Jensen]

On Mon, Apr 23, 2018 at 12:14 PM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Do you have a test case to trigger this bug?

Not at the moment. I'm not at all familiar w/ the
url-http-create-request interface, so I'd have to figure that out
first. You could probably reproduce it by including the two emojis in
https://gist.github.com/aaronjensen/a8b7f87471a76b2f69c7c7432ad75f42
in a post body.

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Lars Ingebrigtsen]

Aaron Jensen <aaronjensen@gmail.com> writes:

> On Mon, Apr 23, 2018 at 12:14 PM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
>> Do you have a test case to trigger this bug?
>
> Not at the moment. I'm not at all familiar w/ the
> url-http-create-request interface, so I'd have to figure that out
> first. You could probably reproduce it by including the two emojis in
> https://gist.github.com/aaronjensen/a8b7f87471a76b2f69c7c7432ad75f42
> in a post body.

It's up to the callers to encode the POST bodies, I think, and the
commit you pointed to doesn't seem to change anything in that area,
unless I'm misreading something, which is quite possible.

That's why I'm wondering what code you were using that triggered this
bug. 

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Aaron Jensen]

On Mon, Apr 23, 2018 at 12:42 PM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Aaron Jensen <aaronjensen@gmail.com> writes:
> It's up to the callers to encode the POST bodies, I think, and the
> commit you pointed to doesn't seem to change anything in that area,
> unless I'm misreading something, which is quite possible.
>
> That's why I'm wondering what code you were using that triggered this
> bug.

Got it, in that case I'm using magithub, which uses ghub to create a
github pull request. The PR body has those two emoji in it.

https://github.com/vermiculus/magithub/
https://github.com/magit/ghub

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Lars Ingebrigtsen]

Aaron Jensen <aaronjensen@gmail.com> writes:

> On Mon, Apr 23, 2018 at 12:42 PM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
>> Aaron Jensen <aaronjensen@gmail.com> writes:
>> It's up to the callers to encode the POST bodies, I think, and the
>> commit you pointed to doesn't seem to change anything in that area,
>> unless I'm misreading something, which is quite possible.
>>
>> That's why I'm wondering what code you were using that triggered this
>> bug.
>
> Got it, in that case I'm using magithub, which uses ghub to create a
> github pull request. The PR body has those two emoji in it.
>
> https://github.com/vermiculus/magithub/
> https://github.com/magit/ghub

Oh, then it's not a thing I can easily reproduce here.  Darn.

When you get home, can you try the same pull request both with that
commit and with that commit reverted and see whether it really is that
commit that's the culprit?  That would help a lot.  Also setting
url-debug to t and looking at the *URL-DEBUG* might be helpful...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Aaron Jensen]

On Mon, Apr 23, 2018 at 12:54 PM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> When you get home, can you try the same pull request both with that
> commit and with that commit reverted and see whether it really is that
> commit that's the culprit?  That would help a lot.

Sure--confirmed, reverting 4a6302330384ad89bcfccce6b563eb5462b753a9 fixes it.

> Also setting
> url-debug to t and looking at the *URL-DEBUG* might be helpful...

*URL-DEBUG* doesn't have much afaict:

http -> Found existing connection: api.github.com:443 #<process api.github.com>
http -> Reusing existing connection: api.github.com:443
http -> Marking connection as busy: api.github.com:443 #<process api.github.com>
http -> getting referer from buffer: buffer:#<buffer
*magithub-pull-request: test into org/repo:master*> target-url:#s(url
"https" nil nil "api.github.com" nil "/repos/org/repo/pulls" nil nil t
nil t nil) lastloc:nil
http -> Contacting host: api.github.com:443
http -> Marking connection as busy: api.github.com:443 #<process
api.github.com<1>>
http -> getting referer from buffer: buffer:#<buffer
*magithub-pull-request: test into org/repo:master*> target-url:#s(url
"https" nil nil "api.github.com" nil "/repos/org/repo/pulls" nil nil t
nil t nil) lastloc:nil
http -> url-http-end-of-document-sentinel in buffer ( *http
api.github.com:443*-584054)
http -> Contacting host: api.github.com:443
http -> Marking connection as busy: api.github.com:443 #<process
api.github.com<1>>
http -> getting referer from buffer: buffer:#<buffer  *http
api.github.com:443*-584054> target-url:#s(url "https" nil nil
"api.github.com" nil "/repos/org/repo/pulls" nil nil t nil t nil)
lastloc:nil
http -> url-http-end-of-document-sentinel in buffer ( *http
api.github.com:443*-689368)
http -> Contacting host: api.github.com:443
http -> Marking connection as busy: api.github.com:443 #<process api.github.com>
http -> getting referer from buffer: buffer:#<buffer  *http
api.github.com:443*-689368> target-url:#s(url "https" nil nil
"api.github.com" nil "/repos/org/repo/pulls" nil nil t nil t nil)
lastloc:nil

FWIW, this reproduces it on both master and with the commit reverted:

(let ((url "http://requestbin.fullcontact.com/1kkmrpx1")
      (url-request-method "POST")
      (url-request-data "📦")
      (url-http-extra-headers '())
      (url-http-proxy nil))
  (url-retrieve url (lambda ())))


It seems that perhaps that is expected? I'm not sure what ghub is
doing differently that allows it to pass with your commit reverted...

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Andreas Schwab]

On Apr 23 2018, Aaron Jensen <aaronjensen@gmail.com> wrote:

> FWIW, this reproduces it on both master and with the commit reverted:
>
> (let ((url "http://requestbin.fullcontact.com/1kkmrpx1")
>       (url-request-method "POST")
>       (url-request-data "📦")

url-request-data is supposed to be an encoded string.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Aaron Jensen]

On Tue, Apr 24, 2018 at 12:19 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> url-request-data is supposed to be an encoded string.

Thank you for pointing that out.

Lars, this reproduces the problem on master (but not with
4a6302330384ad89bcfccce6b563eb5462b753a9 reverted):

(let ((url "http://requestbin.fullcontact.com/1kkmrpx1")
      (url-request-method "POST")
      (url-request-data (encode-coding-string "📦" 'utf-8))
      (url-request-extra-headers '(("Content-Type" . "application/json")))
      (url-http-proxy nil))
  (url-retrieve url (lambda (_))))

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Lars Ingebrigtsen]

Aaron Jensen <aaronjensen@gmail.com> writes:

> Lars, this reproduces the problem on master (but not with
> 4a6302330384ad89bcfccce6b563eb5462b753a9 reverted):
>
> (let ((url "http://requestbin.fullcontact.com/1kkmrpx1")
>       (url-request-method "POST")
>       (url-request-data (encode-coding-string "📦" 'utf-8))
>       (url-request-extra-headers '(("Content-Type" . "application/json")))
>       (url-http-proxy nil))
>   (url-retrieve url (lambda (_))))

Thanks; with that test case I'm able to reproduce the bug, too.  I'll
get debugging...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Lars Ingebrigtsen]

OK, I found the problem, and it's, er, obscure, man:

(setq i "http://requestbin.fullcontact.com")
(multibyte-string-p i)
=> nil

(setq u (url-generic-parse-url i))
(url-host u)
=> "requestbin.fullcontact.com"
(multibyte-string-p (url-host u))
=> t

And this made the entire request string multibyte.

I'll push a fix in a few minutes.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Aaron Jensen]

On Tue, Apr 24, 2018 at 5:06 AM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> And this made the entire request string multibyte.

Hm, that's odd. What does that have to do with the url-request-data w/
the emoji? If I change that to just an "x" then it won't fail in the
same way:

(let ((url "http://requestbin.fullcontact.com/1kkmrpx1")
      (url-request-method "POST")
      (url-request-data (encode-coding-string "x" 'utf-8))
      (url-request-extra-headers '(("Content-Type" . "application/json")))
      (url-http-proxy nil))
  (url-retrieve url (lambda (_))))

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Lars Ingebrigtsen]

Aaron Jensen <aaronjensen@gmail.com> writes:

> On Tue, Apr 24, 2018 at 5:06 AM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
>> And this made the entire request string multibyte.
>
> Hm, that's odd. What does that have to do with the url-request-data w/
> the emoji?

That's the *really* obscure bit.  :-)

> If I change that to just an "x" then it won't fail in the
> same way:
>
> (let ((url "http://requestbin.fullcontact.com/1kkmrpx1")
>       (url-request-method "POST")
>       (url-request-data (encode-coding-string "x" 'utf-8))
>       (url-request-extra-headers '(("Content-Type" . "application/json")))
>       (url-http-proxy nil))
>   (url-retrieve url (lambda (_))))

So you start with a thing that's now multibyte:

(url-host u)
=> "requestbin.fullcontact.com"

(multibyte-string-p (url-host u))
=> t

(setq data (encode-coding-string "📦" 'utf-8))
(multibyte-string-p data)
=> nil

Then concatenate:

(setq foo (concat (url-host u) data))
"\360\237\223\246"
foo
=> "requestbin.fullcontact.com\360\237\223\246"
(multibyte-string-p foo)
=> t
(string-bytes data)
=> 4

(length foo)
=> 30
(string-bytes foo)
=> 34

Fun!  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> (length foo)
> => 30
> (string-bytes foo)
> => 34
>
> Fun!  :-)

The reason here is that when you put raw bytes into a multibyte string,
Emacs has to represent that somehow, and it represents that with an
internal coding that takes two bytes per byte.  If you get my drift.

So the moral here is: That function is really, really badly designed,
because it makes it easy (for people like me) to make these errors
really easily.  Once I merge the `with-url' branch (which reimplements
all the HTTP stuff) into master I hopefully won't ever have to look at
that function again.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#31248: 27.0.50; Regression: Multibyte text in HTTP request

[Aaron Jensen]

close 31248
quit

On Tue, Apr 24, 2018 at 5:23 AM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
>> Fun!  :-)
>
> The reason here is that when you put raw bytes into a multibyte string,
> Emacs has to represent that somehow, and it represents that with an
> internal coding that takes two bytes per byte.  If you get my drift.
>
> So the moral here is: That function is really, really badly designed,
> because it makes it easy (for people like me) to make these errors
> really easily.  Once I merge the `with-url' branch (which reimplements
> all the HTTP stuff) into master I hopefully won't ever have to look at
> that function again.  :-)

Wild. Well, I appreciate the explanation and the quick fix. I can
confirm that it fixes my original issue w/ ghub. Thanks again!