unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Colin Woodbury <cwoodbury@azavea.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com,
	Noam Postavsky <npostavs@users.sourceforge.net>
Subject: bug#23574: 24.5; Overzealous underlining in emacs-nox
Date: Sun, 5 Jun 2016 11:20:24 -0700	[thread overview]
Message-ID: <CAHuwsfhRt5i2J25Po8fcRsJSsw9uutfmvMF_Cus=Ej=aynHbZQ@mail.gmail.com> (raw)
In-Reply-To: <83twh7tt83.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 2001 bytes --]

Interesting that you consider the the GUI _not_ displaying the face all the
way to end of screen to be a bug. I think only displaying to the end of the
characters (as shown in images in the Github issue) is the expected
behaviour. Otherwise, the screen (at least with underlining) gets quite
noisy.

On Sun, Jun 5, 2016 at 10:56 AM, Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Noam Postavsky <npostavs@users.sourceforge.net>
> > Date: Sun, 5 Jun 2016 13:05:53 -0400
> > Cc: John Mastro <john.b.mastro@gmail.com>, 23574@debbugs.gnu.org,
> cwoodbury@azavea.com
> >
> > On Sun, Jun 5, 2016 at 11:54 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> > > We always try to make the empty space
> > > after the end of a screen line have the same face as the last
> > > character of that line.
> >
> > Just to clarify, "last character of that line" refers to the newline
> > character or the one before it?
>
> The last displayed character of the line.  The newline is not
> displayed, in the sense that it has no glyph, so it can have no face.
>
> > > While it should be
> > > possible to have GUI frames display underline all the way to window
> > > edge, no one has ever requested that, so we didn't bother.
> >
> > I think this would have been useful for magit to simplify the use of
> > overlays to display the region with horizontal lines.
>
> This is doable (and in fact we already do that in R2L paragraphs,
> which you can observe if you change the recipe's text to use R2L
> characters).  But note that the OP in this bug report wants the exact
> opposite: to NOT have the underlining extended on TTYs.  So clearly
> there's no "one size fits all" solution here.
>
> > In http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21468#43 you
> > suggested a way using :align-to which turned out to have a bunch of
> > complications and magit ended up not using it (see
> > https://github.com/magit/magit/pull/2293).
>
> Did you try using the box attribute of a face?
>



-- 
Colin Woodbury
Geotrellis Team @ Azavea

[-- Attachment #2: Type: text/html, Size: 3128 bytes --]

  reply	other threads:[~2016-06-05 18:20 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-18 17:03 bug#23574: 24.5; Overzealous underlining in emacs-nox Colin Woodbury
2016-05-30 15:04 ` Colin Woodbury
2016-06-04  7:48   ` Eli Zaretskii
     [not found]     ` <CAHuwsfihHJ8WHwmHvMDF7Ynns4YOJSKEEbjhpbYrw0V=5aYXEQ@mail.gmail.com>
2016-06-04 16:20       ` Eli Zaretskii
2016-06-04 21:37         ` John Mastro
2016-06-05 15:54           ` Eli Zaretskii
2016-06-05 17:05             ` Noam Postavsky
2016-06-05 17:56               ` Eli Zaretskii
2016-06-05 18:20                 ` Colin Woodbury [this message]
2016-06-05 18:36                   ` Eli Zaretskii
2016-06-05 19:13                 ` Noam Postavsky
2016-06-06  2:27                   ` Eli Zaretskii
2016-06-06 11:42                     ` Noam Postavsky
2016-06-06 15:04                       ` Eli Zaretskii
2016-06-06 16:54                         ` martin rudalics
2016-06-06 18:25                           ` Colin Woodbury
2016-06-06 19:18                             ` Eli Zaretskii
2016-06-07  0:18                               ` Noam Postavsky
2016-06-07 15:55                                 ` Eli Zaretskii
2016-06-08  2:52                                   ` Noam Postavsky
2016-06-06 18:55                           ` Eli Zaretskii
2016-06-07  9:10                             ` martin rudalics
2016-06-07 15:50                               ` Eli Zaretskii
2016-06-08  6:33                                 ` martin rudalics
2016-06-08 17:05                                   ` Eli Zaretskii
2016-06-09  8:38                                     ` martin rudalics
2016-06-09 12:26                                       ` Eli Zaretskii
2016-06-10  7:16                                         ` martin rudalics
2016-06-10  8:10                                           ` Eli Zaretskii
2016-06-10  8:24                                             ` martin rudalics
2016-06-10  9:50                                               ` Eli Zaretskii
2016-06-10 13:59                                                 ` martin rudalics
2016-06-10 14:24                                                   ` Eli Zaretskii
2019-10-21 11:49 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-08  5:32   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHuwsfhRt5i2J25Po8fcRsJSsw9uutfmvMF_Cus=Ej=aynHbZQ@mail.gmail.com' \
    --to=cwoodbury@azavea.com \
    --cc=23574@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=john.b.mastro@gmail.com \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).