From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Colin Woodbury Newsgroups: gmane.emacs.bugs Subject: bug#23574: 24.5; Overzealous underlining in emacs-nox Date: Sun, 5 Jun 2016 11:20:24 -0700 Message-ID: References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1140e420743c7205348c02d2 X-Trace: ger.gmane.org 1465150887 29546 80.91.229.3 (5 Jun 2016 18:21:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 5 Jun 2016 18:21:27 +0000 (UTC) Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, Noam Postavsky To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 05 20:21:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b9cfl-0007XR-Ah for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Jun 2016 20:21:17 +0200 Original-Received: from localhost ([::1]:38219 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9cfg-0007c1-Oj for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Jun 2016 14:21:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9cfa-0007bk-Al for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 14:21:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9cfW-0004iP-2K for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 14:21:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43539) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9cfV-0004iL-VE for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 14:21:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b9cfV-0004DS-Qx for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 14:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Colin Woodbury Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jun 2016 18:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23574 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23574-submit@debbugs.gnu.org id=B23574.146515083316150 (code B ref 23574); Sun, 05 Jun 2016 18:21:01 +0000 Original-Received: (at 23574) by debbugs.gnu.org; 5 Jun 2016 18:20:33 +0000 Original-Received: from localhost ([127.0.0.1]:55876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9cf3-0004CQ-10 for submit@debbugs.gnu.org; Sun, 05 Jun 2016 14:20:33 -0400 Original-Received: from mail-lf0-f42.google.com ([209.85.215.42]:35955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9cf0-0004CA-Qf for 23574@debbugs.gnu.org; Sun, 05 Jun 2016 14:20:31 -0400 Original-Received: by mail-lf0-f42.google.com with SMTP id b73so82098676lfb.3 for <23574@debbugs.gnu.org>; Sun, 05 Jun 2016 11:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azavea.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=XK8D0EB2YB8tZiddM0VdljYm+e71u5FUsyvpWJGQMqg=; b=kwSGqUGax8YwC24Mf5QhkvNxyFPC86W3Y06+2lI26/ZntTwIKoEFzpA+IiOTNmy/y6 V+NS3spId3BjGtck6h6yXisJ/uleCM0HLtYUwLBJ50bCNCZaYN/wVsLludBG0ShWN0dp TcDHO+2VqRPXSlpKXYFUvvo8Nk0g7OlrBssO0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=XK8D0EB2YB8tZiddM0VdljYm+e71u5FUsyvpWJGQMqg=; b=GM82R6JuVsqYNcLubNofFdC3MMGz5jZzwKDCcMMvZvYct2PJFN32gJ3T3O3ZN/RBUF Xj2FiY4vxsEM+87D/5nAZLeLcsulAY7DvnVAlnbL7uOdMAswb4D7cvzwstkzyntu3TP+ lMJfqr/56T5TzKHPp1uG+modskn9Lw1taXCuzC73iIYLRS0DAW4rUA8Imd6tcDBgbnTw KBx0woR3+TFYf0KShMTAHj+ZPmHsdByq4xEJ7EqFZHmFKqn4Ol67vkNI1N7YWBZspMXO PJY9LciHvASf0yVPkcuJzi7mWPiFf17CWfYPszC878ZfDF0cdcTXUUHYjo5mNEa7r5wE dtFQ== X-Gm-Message-State: ALyK8tK7oGAtW91V+PjUyze0y6iwRm6MdZXtpm3whnMQ4EyKO9xrAtKmRrZ9/R7JcT+pVCVsT4ehB80MBORfsW2d X-Received: by 10.25.215.30 with SMTP id o30mr379762lfg.132.1465150824784; Sun, 05 Jun 2016 11:20:24 -0700 (PDT) Original-Received: by 10.25.32.212 with HTTP; Sun, 5 Jun 2016 11:20:24 -0700 (PDT) In-Reply-To: <83twh7tt83.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119124 Archived-At: --001a1140e420743c7205348c02d2 Content-Type: text/plain; charset=UTF-8 Interesting that you consider the the GUI _not_ displaying the face all the way to end of screen to be a bug. I think only displaying to the end of the characters (as shown in images in the Github issue) is the expected behaviour. Otherwise, the screen (at least with underlining) gets quite noisy. On Sun, Jun 5, 2016 at 10:56 AM, Eli Zaretskii wrote: > > From: Noam Postavsky > > Date: Sun, 5 Jun 2016 13:05:53 -0400 > > Cc: John Mastro , 23574@debbugs.gnu.org, > cwoodbury@azavea.com > > > > On Sun, Jun 5, 2016 at 11:54 AM, Eli Zaretskii wrote: > > > We always try to make the empty space > > > after the end of a screen line have the same face as the last > > > character of that line. > > > > Just to clarify, "last character of that line" refers to the newline > > character or the one before it? > > The last displayed character of the line. The newline is not > displayed, in the sense that it has no glyph, so it can have no face. > > > > While it should be > > > possible to have GUI frames display underline all the way to window > > > edge, no one has ever requested that, so we didn't bother. > > > > I think this would have been useful for magit to simplify the use of > > overlays to display the region with horizontal lines. > > This is doable (and in fact we already do that in R2L paragraphs, > which you can observe if you change the recipe's text to use R2L > characters). But note that the OP in this bug report wants the exact > opposite: to NOT have the underlining extended on TTYs. So clearly > there's no "one size fits all" solution here. > > > In http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21468#43 you > > suggested a way using :align-to which turned out to have a bunch of > > complications and magit ended up not using it (see > > https://github.com/magit/magit/pull/2293). > > Did you try using the box attribute of a face? > -- Colin Woodbury Geotrellis Team @ Azavea --001a1140e420743c7205348c02d2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Interesting that you consider the the GUI _not_ displaying= the face all the way to end of screen to be a bug. I think only displaying= to the end of the characters (as shown in images in the Github issue) is t= he expected behaviour. Otherwise, the screen (at least with underlining) ge= ts quite noisy.

On Sun, Jun 5, 2016 at 10:56 AM, Eli Zaretskii &l= t;eliz@gnu.org> wrote:
> From: Noam Postavsky <= ;npostavs@users.sourcefor= ge.net>
> Date: Sun, 5 Jun 2016 13:05:53 -0400
> Cc: John Mastro <john.b.= mastro@gmail.com>, 23574@de= bbugs.gnu.org, cwoodbury@azavea= .com
>
> On Sun, Jun 5, 2016 at 11:54 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> > We always try to make the empty space
> > after the end of a screen line have the same face as the last
> > character of that line.
>
> Just to clarify, "last character of that line" refers to the= newline
> character or the one before it?

The last displayed character of the line.=C2=A0 The newline is not displayed, in the sense that it has no glyph, so it can have no face.

> > While it should be
> > possible to have GUI frames display underline all the way to wind= ow
> > edge, no one has ever requested that, so we didn't bother. >
> I think this would have been useful for magit to simplify the use of > overlays to display the region with horizontal lines.

This is doable (and in fact we already do that in R2L paragraphs, which you can observe if you change the recipe's text to use R2L
characters).=C2=A0 But note that the OP in this bug report wants the exact<= br> opposite: to NOT have the underlining extended on TTYs.=C2=A0 So clearly there's no "one size fits all" solution here.

> In http://debbugs.gnu.org/cgi/bugreport.= cgi?bug=3D21468#43 you
> suggested a way using :align-to which turned out to have a bunch of > complications and magit ended up not using it (see
> https://github.com/magit/magit/pull/2293).

Did you try using the box attribute of a face?



--
Colin Wood= bury
Geotrellis Team @ Azavea
--001a1140e420743c7205348c02d2--