unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#21895: 25.0.50; eww: Lisp error: (void-function fringe-columns)
@ 2015-11-13  0:06 Eric Hanchrow
  2015-11-13  0:17 ` bug#21895: easy workaround Eric Hanchrow
  0 siblings, 1 reply; 11+ messages in thread
From: Eric Hanchrow @ 2015-11-13  0:06 UTC (permalink / raw)
  To: 21895

[-- Attachment #1: Type: text/plain, Size: 28339 bytes --]

I started emacs with -Q, typed M-x eww RET http://google.com RET, and saw
the error.  I then did M-x toggle-debug-on-error RET, and hit "g" to reload
the page, in order to get the below stack trace:

Debugger entered--Lisp error: (void-function fringe-columns)
  fringe-columns(right)
  shr-insert-document((base ((href . "http://www.google.com/")) (html
((itemscope . "") (itemtype . "http://schema.org/WebPage") (lang . "en"))
(head nil (meta ((content . "Search the world's information, including
webpages, images, videos and more. Google has many special features to help
you find exactly what you're looking for.") (name . "description"))) (meta
((content . "noodp") (name . "robots"))) (meta ((content .
"/images/branding/googleg/1x/googleg_standard_color_128dp.png") (itemprop .
"image"))) (title nil "Google") (script nil
"(function(){window.google={kEI:'gihFVo_MGMnaoASPxLHABg',kEXPI:'4029815,4031109,4032677,4033307,4033344,4036527,4037333,4038012,4039268,4041837,4042491,4043255,4043457,4043458,4043492,4044606,4045023,4045681,4045841,4046304,4046399,4047318,4047768,4048007,4048011,4048347,4048853,4048909,4049201,4049238,4049251,4049468,4049548,4049556,4049809,4049897,4050000,4050343,4050735,4050751,4050891,4050908,4050916,4051000,4051033,4051107,4051154,4051795,4051831,4052236,4052312,4052344,4052384,4052439,4052446,4052560,4053110,4053189,4053247,4054049,8300096,8300272,8300290,8502189,8502221,8502312,8502315,8502341,8502443,8502451,8502468,8502537,8502551,8502554,8502651,10200083,10201418',authuser:0,kscs:'c9c918f0_10'};google.kHL='en';})();(function(){
google.lc=[];google.li=0;google.getEI=function(a){for(var
b;a&&(!a.getAttribute||!(b=a.getAttribute(\"eid\")));)a=a.parentNode;return
b||google.kEI};google.getLEI=function(a){for(var
b=null;a&&(!a.getAttribute||!(b=a.getAttribute(\"leid\")));)a=a.parentNode;return
b};google.https=function(){return\"https:\"==window.location.protocol};
google.ml=function(){return
null};google.wl=function(a,b){try{google.ml(Error(a),!1,b)}catch(d){}};google.time=function(){return(new
Date).getTime()};google.log=function(a,b,d,e,g){a=google.logUrl(a,b,d,e,g);if(\"\"!=a){b=new
Image;var c=google.lc,f=google.li;c[f]=b;b.onerror=b.onload=b.onabort=function(){delete
c[f]};window.google&&window.google.vel&&window.google.vel.lu&&
window.google.vel.lu(a);b.src=a;google.li=f+1}};google.logUrl=function(a,b,d,e,g){var
c=\"\",f=google.ls||\"\";if(!d&&-1==b.search(\"&ei=\")){var
h=google.getEI(e),c=\"&ei=\"+h;-1==b.search(\"&lei=\")&&((e=google.getLEI(e))?c+=\"&lei=\"+e:h!=google.kEI&&(c+=\"&lei=\"+google.kEI))}a=d||\"/\"+(g||\"gen_204\")+\"?atyp=i&ct=\"+a+\"&cad=\"+b+c+f+\"&zx=\"+google.time();/^http:/i.test(a)&&google.https()&&(
google.ml(Error(\"a\"),!1,{src:a,glmm:1}),a=\"\");return
a};google.y={};google.x=function(a,b){google.y[a.id]=[a,b];return!1};google.load=function(a,b,d){google.x({id:a+k++},function(){google.load(a,b,d)})};var
k=0;})();var _gjwl=location;function _gjuc(){var
a=_gjwl.href.indexOf(\"#\");if(0<=a&&(a=_gjwl.href.substring(a),0<a.indexOf(\"&q=\")||0<=a.indexOf(\"#q=\"))&&(a=a.substring(1),-1==a.indexOf(\"#\"))){for(var
d=0;d<a.length;){var b=d;\"&\"==a.charAt(b)&&++b;var
c=a.indexOf(\"&\",b);-1==c&&(c=a.length);b=a.substring(b,c);if(0==b.indexOf(\"fp=\"))a=a.substring(0,d)+a.substring(c,a.length),c=d;else
if(\"cad=h\"==b)return 0;d=c}_gjwl.href=\"/search?\"+a+\"&cad=h\";return
1}return 0}\nfunction
_gjh(){!_gjuc()&&window.google&&google.x&&google.x({id:\"GJH\"},function(){google.nav&&google.nav.gjh&&google.nav.gjh()})};window._gjh&&_gjh();")
(style nil "#gbar,#guser{font-size:13px;padding-top:1px
!important;}#gbar{height:22px}#guser{padding-bottom:7px
!important;text-align:right}.gbh,.gbd{border-top:1px solid
#c9d7f1;font-size:1px}.gbh{height:0;position:absolute;top:24px;width:100%}@media
all{.gb1{height:22px;margin-right:.5em;vertical-align:top}#gbar{float:left}}a.gb1,a.gb4{text-decoration:underline
!important}a.gb1,a.gb4{color:#00c !important}.gbi .gb4{color:#dd8e27
!important}.gbf .gb4{color:#900 !important}\n") (style nil
"body,td,a,p,.h{font-family:arial,sans-serif}body{margin:0;overflow-y:scroll}#gog{padding:3px
8px 0}td{line-height:.8em}.gac_m
td{line-height:17px}form{margin-bottom:20px}.h{color:#36c}.q{color:#00c}.ts
td{padding:0}.ts{border-collapse:collapse}em{font-weight:bold;font-style:normal}.lst{height:25px;width:496px}.gsfi,.lst{font:18px
arial,sans-serif}.gsfs{font:17px
arial,sans-serif}.ds{display:inline-box;display:inline-block;margin:3px 0
4px;margin-left:4px}input{font-family:inherit}a.gb1,a.gb2,a.gb3,a.gb4{color:#11c
!important}body{background:#fff;color:black}a{color:#11c;text-decoration:none}a:hover,a:active{text-decoration:underline}.fl
a{color:#36c}a:visited{color:#551a8b}a.gb1,a.gb4{text-decoration:underline}a.gb3:hover{text-decoration:none}#ghead
a.gb2:hover{color:#fff !important}.sblc{padding-top:5px}.sblc
a{display:block;margin:2px
0;margin-left:13px;font-size:11px}.lsbb{background:#eee;border:solid
1px;border-color:#ccc #999 #999
#ccc;height:30px}.lsbb{display:block}.ftl,#fll
a{display:inline-block;margin:0
12px}.lsb{background:url(/images/nav_logo229.png) 0 -261px
repeat-x;border:none;color:#000;cursor:pointer;height:30px;margin:0;outline:0;font:15px
arial,sans-serif;vertical-align:top}.lsb:active{background:#ccc}.lst:focus{outline:none}")
(script nil) (link ((href .
"/images/branding/product/ico/googleg_lodp.ico") (rel . "shortcut icon"))))
(body ((bgcolor . "#fff")) (script nil "(function(){var
src='/images/nav_logo229.png';var iesg=false;document.body.onload =
function(){window.n && window.n();if (document.images){new
Image().src=src;}\nif
(!iesg){document.f&&document.f.q.focus();document.gbqf&&document.gbqf.q.focus();}\n}\n})();")
(div ((id . "mngb")) "    " (div ((id . "gbar")) (nobr nil (b (...)
"Search") " " (a (... ...) "Images") " " (a (... ...) "Maps") " " (a (...
...) "Play") " " (a (... ...) "YouTube") " " (a (... ...) "News") " " (a
(... ...) "Gmail") " " (a (... ...) "Drive") " " (a (... ... ...) (u nil
"More") " »"))) (div ((id . "guser") (width . "100%")) (nobr nil (span (...
...)) (span (... ...)) (span (...)) (a (... ...) "Web History") " | " (a
(... ...) "Settings") " | " (a (... ... ... ...) "Sign in"))) (div ((class
. "gbh") (style . "left:0"))) (div ((class . "gbh") (style . "right:0"))) "
   ") (center nil (span ((id . "prt") (style . "display:block")) " " (div
nil (style nil ".pmoabs{background-color:#fff;border:1px solid
#E5E5E5;color:#666;font-size:13px;padding-bottom:20px;position:absolute;right:2px;top:3px;z-index:986}#pmolnk{border-radius:2px;-moz-border-radius:2px;-webkit-border-radius:2px}.kd-button-submit{border:1px
solid
#3079ed;background-color:#4d90fe;background-image:-webkit-gradient(linear,left
top,left
bottom,from(#4d90fe),to(#4787ed));background-image:-webkit-linear-gradient(top,#4d90fe,#4787ed);background-image:-moz-linear-gradient(top,#4d90fe,#4787ed);background-image:-ms-linear-gradient(top,#4d90fe,#4787ed);background-image:-o-linear-gradient(top,#4d90fe,#4787ed);background-image:linear-gradient(top,#4d90fe,#4787ed);filter:progid:DXImageTransform.Microsoft.gradient(startColorStr='#4d90fe',EndColorStr='#4787ed')}.kd-button-submit:hover{border:1px
solid
#2f5bb7;background-color:#357ae8;background-image:-webkit-gradient(linear,left
top,left
bottom,from(#4d90fe),to(#357ae8));background-image:-webkit-linear-gradient(top,#4d90fe,#357ae8);background-image:-moz-linear-gradient(top,#4d90fe,#357ae8);background-image:-ms-linear-gradient(top,#4d90fe,#357ae8);background-image:-o-linear-gradient(top,#4d90fe,#357ae8);background-image:linear-gradient(top,#4d90fe,#357ae8);filter:progid:DXImageTransform.Microsoft.gradient(startColorStr='#4d90fe',EndColorStr='#357ae8')}.kd-button-submit:active{-webkit-box-shadow:inset
0 1px 2px rgba(0,0,0,0.3);-moz-box-shadow:inset 0 1px 2px
rgba(0,0,0,0.3);box-shadow:inset 0 1px 2px rgba(0,0,0,0.3)}#pmolnk
a{color:#fff;display:inline-block;font-weight:bold;padding:5px
20px;text-decoration:none;white-space:nowrap}.xbtn{color:#999;cursor:pointer;font-size:23px;line-height:5px;padding-top:5px}.padi{padding:0
8px 0 10px}.padt{padding:5px 20px 0
0;color:#444}.pads{text-align:left;max-width:200px}") (div (... ... ...) "
" (table ... ... ... ...)) " " (script (...) "(function(){var
a={v:{}};a.v.Ya=50;a.v.Wa=10;a.v.Fa=\"body\";a.v.Eb=!0;a.v.Hb=function(b,c){var
d=a.v.rb();a.v.ub(d,b,c);a.v.Ib(d);a.v.Eb&&a.v.Fb(d)};a.v.Ib=function(b){(b=a.v.Ha(b))&&0<b.forms.length&&b.forms[0].submit()};a.v.rb=function(){var
b=document.createElement(\"iframe\");b.height=0;b.width=0;b.style.overflow=\"hidden\";b.style.top=b.style.left=\"-100px\";b.style.position=\"absolute\";document.body.appendChild(b);return
b};a.v.Ha=function(b){return
b.contentDocument||b.contentWindow.document};a.v.ub=function(b,c,d){b=a.v.Ha(b);b.open();d=[\"<\",a.v.Fa,'><form
method=POST action=\"',d,'\">'];for(var e in
c)c.hasOwnProperty(e)&&d.push('<textarea
name=\"',e,'\">',c[e],\"</textarea>\");d.push(\"</form></\",a.v.Fa,\">\");b.write(d.join(\"\"));b.close()};a.v.Ja=function(b,c){c>a.v.Wa?google&&
google.ml&&google.ml
(Error(\"ogcdr\"),!1,{cause:\"timeout\"}):b.contentWindow?a.v.Gb
(b):window.setTimeout(function(){a.v.Ja(b,c+1)},a.v.Ya)};a.v.Gb=function(b){document.body.removeChild(b)};a.v.Fb=function(b){a.v.pb(b,\"load\",function(){a.v.Ja(b,0)})};a.v.pb=function(b,c,d){b.addEventListener?b.addEventListener(c,d,!1):b.attachEvent&&b.attachEvent(\"on\"+c,d)};var
m={Lb:0,U:1,V:2,na:5};a.s={};a.s.pa
={Sa:\"i\",ma:\"d\",Ua:\"l\"};a.s.R={qa:\"0\",W:\"1\"};a.s.ra={oa:1,ma:2,ka:3};a.s.O={Ma:\"a\",Qa:\"g\",T:\"c\",lb:\"u\",kb:\"t\",qa:\"p\",Xa:\"pid\",Oa:\"eid\",mb:\"at\"};a.s.Ta=window.location.protocol+\"//
www.google.com/_/og/promos/\";a.s.Pa=\"g\";a.s.nb=\"z\";a.s.ya=function(b,c,d,e){var
f=null;switch(c){case m.U:f=window.gbar.up.gpd(b,d,!0);break;case
m.na:f=window.gbar.up.gcc(e)}return
null==f?0:parseInt(f,10)};a.s.Ab=function(b,c,d){return
c==m.U?null!=window.gbar.up.gpd(b,d,!0):!1};a.s.ta=function(b,c,d,e,f,h,k,l){var
g={};g[a.s.O.qa]=b;g[a.s.O.Qa]=c;g[a.s.O.Ma
]=d;g[a.s.O.mb]=e;g[a.s.O.Oa]=f;g[a.s.O.Xa]=1;k&&(g[a.s.O.T]=k);l&&(g[
a.s.O.lb]=l);if(h)g[a.s.O.kb]=h;else return
google.ml(Error(\"knu\"),!1,{cause:\"Token
is not found\"}),null;return g};a.s.Ca=function(b,c,d){if(b){var e=c?a.s.Pa:
a.s.nb;c&&d&&(e+=\"?authuser=\"+d);a.v.Hb(b,a.s.Ta+e)}};a.s.tb=function(b,c,d,e,f,h,k){b=a.s.ta(c,b,
a.s.pa.ma,a.s.ra.ma,d,f,null,e);a.s.Ca
(b,h,k)};a.s.wb=function(b,c,d,e,f,h,k){b=a.s.ta(c,b,a.s.pa.Sa
,a.s.ra.oa,d,f,e,null);a.s.Ca(b,h,k)};a.s.Db=function(b,c,d,e,f,h,k,l,g,n){switch(c){case
m.na:window.gbar.up.dpc(e,f);break;case
m.U:window.gbar.up.spd(b,d,1,!0);break;case
m.V:g=g||!1,l=l||\"\",h=h||0,k=k||a.s.R.W,n=n||0,a.s.tb(e,h,k,f,l,g,n)}};
a.s.Bb=function(b,c,d,e,f){return
c==m.U?0<d&&a.s.ya(b,c,e,f)>=d:!1};a.s.vb=function(b,c,d,e,f,h,k,l,g,n){switch(c){case
m.na:window.gbar.up.iic(e,f);break;case
m.U:c=a.s.ya(b,c,d,e)+1;window.gbar.up.spd(b,d,c.toString(),!0);break;case
m.V:g=g||!1,l=l||\"\",h=h||0,k=k||a.s.R.qa
,n=n||0,a.s.wb(e,h,k,1,l,g,n)}};a.s.Cb=function(b,c,d,e,f,h){b=a.s.ta(c,b,
a.s.pa.Ua,a.s.ra.ka,d,e,null,null);a.s.Ca(b,f,h)};var
p={Jb:\"a\",Mb:\"l\",Kb:\"c\",Na:\"d\",ka:\"h\",oa:\"i\",Wb:\"n\",W:\"x\",Tb:\"ma\",Ub:\"mc\",Vb:\"mi\",Nb:\"pa\",Ob:\"pc\",Qb:\"pi\",Sb:\"pn\",Rb:\"px\",Pb:\"pd\",Xb:\"gpa\",Zb:\"gpi\",$b:\"gpn\",ac:\"gpx\",Yb:\"gpd\"};a.o={};a.o.N={Va:\"hplogo\",jb:\"pmocntr2\"};a.o.R={ab:\"0\",W:\"1\",La:\"2\"};a.o.w=document.getElementById(a.o.N.jb);a.o.Ra=16;
a.o.Za
=2;a.o.$a=20;google.promos=google.promos||{};google.promos.toast=google.promos.toast||{};a.o.$=function(b){a.o.w&&(a.o.w.style.display=b?\"\":\"none\",a.o.w.parentNode&&(a.o.w.parentNode.style.position=b?\"relative\":\"\"))};a.o.Ka=function(b){try{if(a.o.w&&b&&
b.es&&b.es.m){var
c=window.gbar.rtl(document.body)?\"left\":\"right\";a.o.w.style[c]=b.es.m-a.o.Ra+
a.o.Za+\"px\";a.o.w.style.top=a.o.$a+\"px\"}}catch(d){google.ml
(d,!1,{cause:a.o.P+\"_PT\"})}};google.promos.toast.cl=function(){try{a.o.va
==m.V&&a.s.Cb(a.o.Aa,a.o.S,a.o.R.La,a.o.Ea,a.o.Ba,a.o.Da),window.gbar.up.sl
(a.o.S,a.o.P,p.ka,a.o.wa(),1)}catch(b){google.ml
(b,!1,{cause:a.o.P+\"_CL\"})}};google.promos.toast.cpc=function(){try{a.o.w&&(a.o.$(!1),a.s.Db(a.o.w,
a.o.va,a.o.N.Ga,a.o.Aa,a.o.qb,a.o.S,a.o.R.W,a.o.Ea,a.o.Ba,a.o.Da),
window.gbar.up.sl(a.o.S,a.o.P,p.Na,a.o.wa(),1))}catch(b){google.ml(b,!1,{cause:a.o.P+\"_CPC\"})}};a.o.Ia=function(){try{if(a.o.w){var
b=276,c=document.getElementById(a.o.N.Va);c&&(b=Math.max(b,c.offsetWidth));var
d=parseInt(a.o.w.style.right,10)||0;a.o.w.style.visibility=2*(a.o.w.offsetWidth+d)+b>document.body.clientWidth?\"hidden\":\"\"}}catch(e){
google.ml(e,!1,{cause:a.o.P+\"_HOSW\"})}};a.o.ob=function(){var
b=[\"gpd\",\"spd\",\"aeh\",\"sl\"];if(!window.gbar||!window.gbar.up)return!1;for(var
c=0,d;d=b[c];c++)if(!(d in
window.gbar.up))return!1;return!0};a.o.yb=function(){return
a.o.w.currentStyle&&\"absolute\"!=a.o.w.currentStyle.position};google.promos.toast.init=function(b,c,d,e,f,h,k,l,g,n,q,r){try{if(!a.o.ob())
google.ml(Error(\"apa\"),!1,{cause:a.o.P+\"_INIT\"});else
if(a.o.w)if(e==m.V&&!l==!g)google.ml(Error(\"tku\"),!1,{cause:\"zwieback:
\"+g+\", gaia: \"+l}),a.o.$(!1);else
if(a.o.N.T=\"toast_count_\"+c+(q?\"_\"+q:\"\"),a.o.N.Ga
=\"toast_dp_\"+c+(r?\"_\"+r:\"\"),a.o.P=d,a.o.S=b,a.o.va
=e,a.o.Aa=c,a.o.qb=f,a.o.Ea=l?l:g,a.o.Ba=!!l,a.o.Da=k,a.s.Ab(a.o.w,e,
a.o.N.Ga,c)||a.s.Bb
(a.o.w,e,h,a.o.N.T,c)||a.o.yb())a.o.$(!1);else{a.s.vb(a.o.w,e,a.o.N.T,c,f,a.o.S,a.o.R.ab,a.o.Ea,
a.o.Ba
,a.o.Da);if(!n){try{window.gbar.up.aeh(window,\"resize\",a.o.Ia)}catch(t){}window.lol=a.o.Ia;window.gbar.elr&&a.o.Ka(window.gbar.elr());window.gbar.elc&&window.gbar.elc(a.o.Ka);a.o.$(!0)}
window.gbar.up.sl(a.o.S,a.o.P,p.oa,a.o.wa())}}catch(t){google.ml(t,!1,{cause:a.o.P+\"_INIT\"})}};a.o.wa=function(){var
b=a.s.ya(a.o.w,a.o.va,a.o.N.T,a.o.Aa);return\"ic=\"+b};})();") (script
(...) "(function(){var sourceWebappPromoID=144002;var
sourceWebappGroupID=5;var payloadType=5;var cookieMaxAgeSec=2592000;var
dismissalType=5;var impressionCap=25;var gaiaXsrfToken='';var
zwbkXsrfToken='';var kansasDismissalEnabled=false;var sessionIndex=0;var
invisible=false;window.gbar&&gbar.up&&gbar.up.r&&gbar.up.r(payloadType,function(show){if
(show){google.promos.toast.init(sourceWebappPromoID,sourceWebappGroupID,payloadType,dismissalType,cookieMaxAgeSec,impressionCap,sessionIndex,gaiaXsrfToken,zwbkXsrfToken,invisible,'0612');}\n});})();"))
" ") (br ((clear . "all") (id . "lgpd"))) (div ((id . "lga")) (img ((alt .
"Google") (height . "92") (src .
"/images/branding/googlelogo/1x/googlelogo_white_background_color_272x92dp.png")
(style . "padding:28px 0 14px") (width . "272") (id . "hplogo") (onload .
"window.lol&&lol()"))) (br nil) (br nil)) (form ((action . "/search") (name
. "f")) (table ((cellpadding . "0") (cellspacing . "0")) (tr (...) (td ...
" ") (td ... ... ... ... ... ... ... ... ... ...) (td ... ... ...))) (input
((id . "gbv") (name . "gbv") (type . "hidden") (value . "1")))) (div ((id .
"gac_scont"))) (div ((style . "font-size:83%;min-height:3.5em")) (br nil))
(span ((id . "footer")) (div ((style . "font-size:10pt")) (div (... ...) (a
... "Advertising Programs") (a ... "Business Solutions") (a ... "+Google")
(a ... "About Google"))) (p ((style . "color:#767676;font-size:8pt")) "©
2015 - " (a (...) "Privacy") " - " (a (...) "Terms")))) (script nil
"(function(){window.google.cdo={height:0,width:0};(function(){var
a=window.innerWidth,b=window.innerHeight;if(!a||!b)var
c=window.document,d=\"CSS1Compat\"==c.compatMode?c.documentElement:c.body,a=d.clientWidth,b=d.clientHeight;a&&b&&(a!=google.cdo.width||b!=google.cdo.height)&&google.log(\"\",\"\",\"/client_204?&atyp=i&biw=\"+a+\"&bih=\"+b+\"&ei=\"+google.kEI);})();})();")
(div ((id . "xjsd"))) (div ((id . "xjsi")) (script nil
"(function(){function c(b){window.setTimeout(function(){var
a=document.createElement(\"script\");a.src=b;document.getElementById(\"xjsd\").appendChild(a)},0)}google.dljp=function(b,a){google.xjsu=b;c(a)};google.dlj=c;})();(function(){window.google.xjsrm=[];})();if(google.y)google.y.first=[];if(!google.xjs){window._=window._||{};window._._DumpException=function(e){throw
e};if(google.timers&&google.timers.load.t){google.timers.load.t.xjsls=new
Date().getTime();}google.dljp('/xjs/_/js/k\\x3dxjs.hp.en_US.gp1oeOY8XtQ.O/m\\x3dsb_he,d/rt\\x3dj/d\\x3d1/t\\x3dzcms/rs\\x3dACT90oGwouWTJDmCa07lBRv_ExUF65bHGw','/xjs/_/js/k\\x3dxjs.hp.en_US.gp1oeOY8XtQ.O/m\\x3dsb_he,d/rt\\x3dj/d\\x3d1/t\\x3dzcms/rs\\x3dACT90oGwouWTJDmCa07lBRv_ExUF65bHGw');google.xjs=1;}google.pmc={\"sb_he\":{\"agen\":true,\"cgen\":true,\"client\":\"heirloom-hp\",\"dh\":true,\"ds\":\"\",\"fl\":true,\"host\":\"
google.com\",\"isbh\":28,\"jam\":0,\"jsonp\":true,\"msgs\":{\"cibl\":\"Clear
Search\",\"dym\":\"Did you mean:\",\"lcky\":\"I\\u0026#39;m Feeling
Lucky\",\"lml\":\"Learn more\",\"oskt\":\"Input tools\",\"psrc\":\"This
search was removed from your \\u003Ca href=\\\"/history\\\"\\u003EWeb
History\\u003C/a\\u003E\",\"psrl\":\"Remove\",\"sbit\":\"Search by
image\",\"srch\":\"Google
Search\"},\"ovr\":{\"spsxb\":1},\"pq\":\"\",\"refoq\":true,\"refpd\":true,\"rfs\":[],\"scd\":10,\"sce\":5,\"stok\":\"A57FW64MJ1BNeAeeECtcQBHciLQ\"},\"d\":{}};google.y.first.push(function(){if(google.med){google.med('init');google.initHistory();google.med('history');}});if(google.j&&google.j.en&&google.j.xi){window.setTimeout(google.j.xi,0);}\n"))))))
  eww-display-html(iso-8859-1 "http://www.google.com/" nil 1 #<buffer
*eww*> nil)
  eww-render((:redirect "http://www.google.com/") "http://google.com/" 1
#<buffer *eww*> nil)
  apply(eww-render ((:redirect "http://www.google.com/") "http://google.com/"
1 #<buffer *eww*> nil))
  url-http-activate-callback()
  url-http-content-length-after-change-function(4082 7968 3886)
  url-http-generic-filter(#<process www.google.com> "Q0\327
\235\245E\224B\303d\302\203a\373\354\345\233 \274\270\314\303\353,^\246.
\200\203y\222\224\265x\224\272\f\355z\225 \nj\306\335\317\377\300\314
0q'/`\225\313\347 g\234k
7\354\230\263.W\263\252MD\236\212x\330\202\213\240\373\231\336PQK\266\302rj\257n,\274\336\244\372\215\376
\265\207 \317}\240 \360\334O \242p\302K\347\216\275'\352_:\325\365
^G\254\304\375 6\245 \204\300\230Y:mO\343w
X\272\200\222*\251\264Z\2346\326\254ec\215\234\272\342\367\310\320
\205\202\332j
\307\216\216v<\223W \255\226, 4>\351b\322\333\222P\352\330 Ct\3542^wSFsv
0,\265\211?Mi\310 ^X\n{d \220 \346\370\352\321\213\263`
|\317\203I.[\300b\331E m\214M L\264- D\341\366\332\244\360{\311\306\341 M
;\316\334 < k\355R\\\214\277!\225\242Q\227\357r\236KJ e\325 q
R\364\261\226\363\320\230+\274\252\253\311 \357\214\201
<\346\260?\222c\242\211i\327\366O\216Q\306J\310\362y\354\331\357\336^^)\324
\243\331\327<m\237\234\354 \232 W_\fb \305U]}N\263\267\267\321\273
h\246\371}\233\301\364yz\262\314\346\355\375cTG\ns
\355k\214S\321\334\217\354\223F@\225e\373 \314\211D\202Z\344
\342\235\2221r\302\247\3546\205\235\250\355\351\237a\233i \202n
,\2368c\205*\374L7T\324= \272}\272q\377 \265lq\243 \317\\/\225\267\252. +o
4\234 \244\222\265jm \374 \277p@\232\226<\215\312\3043\257/9\301
r\3231\325\265& \235d\367Es 4\325$e!\350a\241& \341\247&
V%\300\202F\360\270\214h\273\2725\370\355\230\200\334\326 6\326\363
\350\363 \334,b\351\351vU @A&( \232\347\324\235\363V\\\220\265\"H/\"
$*\356wC{\365\312\261\f\355\275ej\277Y=-\242\326 \331\310\360
\330\261\355\325%\265\210O\264 \340\376=$
\255\277\332\253/P4\210\366\301\"\246\254L %\246@ z\332\202Z}Q\377\326^\275
`J\264_ \231 \355\312\".\321 \307\"K\242- \311\211\206\344 \242\375\216\211
\275\275\205\f\276S\321Bh\247\271\354\342\212>\372\344\244C\266\202\376\353n\314
S\301\224w \307
\266s&\262\221c\223\257\"{O7$\2571a\250\246\342eMv\353\343\253
\324W\n{b\250\277\267\246 xh\250/ }\226\200 \340D \240\365\260` \222\335
v]X\206\353\332s \333\236\236
VB\323\214]\300lM5\323P\305\220\237n\253\205\304sm X9E\364\275o\260c\341#
\244\224o S\233jsm\241 b\2703\376 \341#\2373\375 \305\327+E\351
(\271e\3515\224\274\262 :\237lV\226\336B\333\264,\375 %s\262\300
\262\346\352\223\275P'A\255&\374\200\337\236\317\325\242n usq .G\273e
\321\262i\f\256\342 \213 ?S\2428W\246 \257\200]\320\370\f 4\204 \3166
\241\256\240sG \201\331\356\251P K\250\311\304 { \354\262\216MN\213
f6\351\310\255\363%.p\241\233 \230S)\352\315I+D-\354<\316
,[\201\227P=\244\232X@\230\363 \231 %\224\334 D
\244o\377=\322\227%\351X\220f\234\370N\322\317 #\255
\332L\213\324\325\326B\345\336P< \334\\\300\332X
\3577\3012\251\237\346\366\202\371\315\232\331\263\207 \230\330\300
\360\251\2216\267\347 \206\266\260 \334\372\350 \264\310\216\260N
zD.\247\222O9 \317v
gs\365 \307 \272>h 8 \202\234\330^\271hn\376
2\361\375\3352q\355Z\307ht:\346\344
9\271\340\332\\\212\367\"\352\217\211\354
\255\313\354\266\220\231\331\224\331\331\356\341\356\326\255\367\245n-(\207\344j\273\241^\210-\366\234\304^\375\354\360}\340\265\203[\211\366O\207o
o\304\376 \231 - \233\316 h\213\370\366r
B\300{\217)`\374\206)\275\2014\201\372\267\230B\375/\230B\375%\246\200\375+\246\200\377
S\350\342wHg\210\360/\236 \310\277\363\f\200R 3\373 \257\361\370\206
\213\3350\326\337\330\253\337\220\275 \357\310\210\366 \351
\301\250\200\200 \221:\325\216\250\275
\360\242\355\266\362w\361-\234pv\237\335_xmN[\377\354\250\202
\370\370\207<\367/j\367x\346\357\220)_\237\212\255\314n\224
\252\207c\365\250\305\336Q\307a9\325
7 X\304\227U\230J7YF\316\266sJ L \306\317\232h\257\336\213\226(U\325\246\223
\350) ( \313 \360 E\377\377lz\321\370\342 \f\260\344\303A\327\205e\342W
\213'\210\365\205\221\346A\273\341\215\251\247
\335}\350C\204\324\223\332X>\272\260\221qR B\310 !\341 \252F \220G
B\350\274m]\2756\2556 \257\266\343 \354\273 \271~w
\315z\3474\200\377[\217~p\244\210uC\321\372\374&,\317\231\303\207\376\224r
_\362\337_\365W\242x.\222g\"yNUm\323B
\355\n\355\235\226\340Z\344\203\242`)\314\342\305\254S
\203\263c\fg\257\2761\206\304\3355\210Bg\376\336 \357S \210\230DM\214Q
\352\375Bd\344\370\2768\215a~\370\301Q\276i\214\362\257 \363\335\231
'V\\\320\315a ZX\304\251\275\243C|\223\367\315\325\373
U\321E\200\3715\315\347\260\203\337\241\345\324\343\351 \"\216 \272\252\342
\245g\227\376]]\353\270\306\242\277 \266\271\241\216\3700\305\361
?\277\267{\377%QjT\301 \3518'\315\240\304
| A\363i \303\272+4\231\325\305\303v\210\347\345\333\313 \225|\342
\221\373Gn 5\222\361_\312\346\230 \310'\376 \2706i\260 5\247P-^\254\226
\252k \232 !\256 +t\342v:*\222h{ \266n\240V\2702c \357\235\355\207\337\212
\224\273L\321(]\242$[\255*\330\337\263\267\333K{\265[\375\375\310\317\277\351
h_\264\264\324\237=!\271\266\252n? Nh\303c-\244~\361\346 -H\371\362S\250
d\230\264 { \354\315\266 \346\213
\370\353\255\317\360\270\336RHg\326!\2322\243>\305B\200O\217\213\265\332\350\350\215~e
>\320k~\321z
ab\247\375\345\224@\346 \332\354r `^\"`R \223\2260\357lO,m\333\221
\300fr\345\333\256\\\373\366T\256w;8
\254\231\\\365\366\336^ W\276\275\320D\324#-
\253\214\210\253\n_\346Y\3256\227\255W\262
U $\337 \351J\370q E\2336L uv\333\"\256\332\221\230\340
\263 \372\337 U ltx\242.\266\311
ZX\244\\]\255\313\2205\260Ec\303\313cA\212\373\356\212\355\215z \312
\250[\275\330\225 m\201*<
4\304\215\337\263\235qe;\325u\305g\245^\371\343J*M\303-\3356
\322\231\335\261 \\I5(N\323\210\357\342\213\373\365\244\3716\347\337=* \302
@\343\223\344 \256\330\213\347\2669 Fo\262\331\374\"\215\227 4
\205'J\357\361D\346\n\273 5.~\242\307^\323\273\2473v\311\\\2737
\343\307E\302n\373Y\350g
j\360~\230\300|g\300\313 M\232W\342b\373=K\247<
\265\367\305#\252\257\267\316b\253rA\243\214f\317 \302\347 \236 {\362\255
\347] \277\300\353w[\260\341G|C \230
\253\315r\253%\347\272\314\350i-\333\256\215\267:\204\312\346\361-
\276\212\314=f\372\332;\304\254\355\220\255V\357\245!3mC\272ZCzZ}\254ZC\206ZCxZ)
m\33784{\373\374}\227\272\245D\305\221\274x\354\342\300\344 \214B\304N\203@\\D
\270\205U/\301\202 \205 ^\243\320
\267\2118\344'\212<\200&c\274o\252\337\257l|r\211!A\365\325%\226\256\371\225\334uuo*?\300\354
\365\356\306\275\342 Ly T\334\235\365\344\255\332<O\371 \210\202\340X
\212\374\200\210T \245\325\202 \274\2378\346\317\326\312\267,\374\240\2708
\226\237 \237\224\342\243@q \346\262 \220\f\340} /\343M\242,
X\252\334\360+;4\376 Vx%s\303 \220\223V\344d\311\204_ `\223 /_\240;~ i />
\226\375\373 ]\240\272\204\354\305\345\333\203\321h8>0\211\\\365\322k)0$
\336\344 \344y\360 \244h \212\271 RP\231' \320\216
\373Mj\216?\337j\257\335syY9\215\305S\323\352
?\276\222V\214\222\240\204\253=V-_\244\326\257O\205
\225\355'\250D\241K<\353\f \374T\314&\340\f
\357\232H\220\345\3450\201e\374~\267Pe\345R\316>\270\246\342\266 &\317
\214\n\211~\201A\300\316e\223\341 )\324
V\215d\270~9\214\243\341\257\231\252\3617+\360]p9\342\252\256\344l\203!)\344<zQHY\336
\226O\325\352\257\330~\264\323\213\375P\371\211\261?\301~\265t
\367\265\216/j \204\260\315\347s?\343\367X\372 \235c\253\274\306\2353w
\366\331\234(\334u\202\271( \240\355\375\256 \307^\206a\377;\243(V\211\344q
(\370\274\233
\253\206G\260\325\232i\254\263\352\312\224z74r\231w-?\375\251\256L\313\263I\230\246\247
J\311\344\343UZ#\201_\320/\301\224]\347q d\217Px%\201 $
\313!\377x\307Y\\qJ\231\243\205\23297\205Xyv\347\3723Q$\342\362\2500\276\370eF\20677\244\376\306\256\270%/\337)\214\372\377\230\204~T(b
?\214!u{W>\262\233\3061\332\236G\350\230 : \3656\271\n\3151>
\207\345U\377,\250\260c\234.\354 5 /=\251\207\257<A\334\270Z3P1a
a\237\234\2454\314\232\202\317\304\273E\304x\266
`\330\370\224K\214K\360\261h
\264z\307\273l\274|4\315\303\321xl\364\306\375\243\341\330\304/\334\207CC\276
O\226N\340gs
|\247\370\220\237\356b\331\211\227\271\216 } \307\274R\203 \322
\277\311\206\321::\304 \265\327##
f\313\215\223\373\211\3223\314\241r\240lw\227\304\260\274|\206/ \374
\352\336\303\340\337\211
\277A\377&\nH?Di]a*\370K\252\345T>\260\374\316\237)\320]/\266\313o\2644\361\346
B\310\355\253w\211\346G Ky \2559\215\272\227\234 (D\270\216\3328\233*bq
\324\345\354\362\322< KMsb\333.\316 d_\307 ;uK8y\226`\271<x\327\250\355\325
x\350\272(\313n)? k\323\362 X \227\270 xp \225b\254\325w\252\340=\264
D\352\360\377\256
\211_\303\236\266\344\247\260\260
\312oaa\303\343\337\302\312 uk_\324\n7\353\221\307\364w\2373\217l\274f\306J
\367\347 \345\347\210.\236\330|\363~V\314\313c\357
dd\300\217\233\301Es&\217 \325 \325\306\345>\304hx\375*\307\350
\237\223z\224O\253\257g?gK \355\"\302\244\202\266\335\355\277 \320T;@LC\374K
\224\246\370\222\267\210\344\357\365\251\237f9\202\240JUh%\245\353B\267\256\371\341mQ\320\257\237/\303\344\374\316e\374\241y\3057\2030u\236\306\267\n[\327:\304k\362\264z\363\"\212\374\263_\275\212\373
\265\310D\220\331\305G\364\355\332W\364\223\272\304\332\373]\200\354^w\341g\361\347]\337\203\222>Ot
]\277\277\324g\211 \263\267 \214~\317 \321\337vCl\317\234\3539\204
\3354\307\322\347\256\207\211\331\345\245\257.,\3664\303\354\323\263\253\261
\277\270\215\227 \256~~ \236Q\343(x\366\353\315\365\371\335\373\237
\207\316\313 \267\373\332\377_\327\352\244\232*p\n\n\201$\241k\257
\357\206X+ \233gD\254<]2\215\270\365<_\200\304B\2371
\3428<\277T#\336\274 \307\302\245:
\212\232y\234!B\265 @\253\2379\200\321 i\3443
\3305\3629\213\243\244@ \263Y\206\\\270 0 \352 \306@\205\343 ]\334
\ny\356{\374/\327\204\214F \324 \350
Y\344\342\317%\304\320\207O\372\343\311\246\347 0!\222{
\204\"\376Gr\240*\316 \310\335 w \270\273\225 ,H\250\274 \377I:!\312-\315
\361l\302S\360m-\366\235*\330Y\377L\356 \222\342\373\203? o8\257}n
 \273T4\210>\220\231_9M<\210t|dD\376 \347^\374a l\300Q[ \356\347
8\277IQFY\222\3359\3042\241&\371\"d \314\304_\nYB \"\306\2420 \271~\374
D]\2503
\314\300| !\315\343 `? \375\364\341p\360\372g\363\331
\366\224\261\363\263\334\375\345\331K\327 \365 \366
H\265\277^!M\200xZS\263$\325\342
Y\355 \202y\355}\f\312+ \304\222\224O\273\254\344pR\220 &\257\353\346\347si
>\303b\251 \356\374]\306\270\326\f\346r\302\277\351-\276f \316 \356^\370 \376U\247\377
Rye{\345I")

In GNU Emacs 25.0.50.3 (x86_64-unknown-linux-gnu)
 of 2015-11-10
Repository revision: 3c3aad733522365a8fe729d7c92e64e98bc4ce92
Configured using:
 'configure --without-x'

Configured features:
SOUND NOTIFY LIBSELINUX LIBXML2 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

[-- Attachment #2: Type: text/html, Size: 36300 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#21895: easy workaround
  2015-11-13  0:06 bug#21895: 25.0.50; eww: Lisp error: (void-function fringe-columns) Eric Hanchrow
@ 2015-11-13  0:17 ` Eric Hanchrow
  2015-11-13  1:29   ` bug#21895: [PATCH] shr: don't invoke unbound function (Bug#21895) Eric Hanchrow
  0 siblings, 1 reply; 11+ messages in thread
From: Eric Hanchrow @ 2015-11-13  0:17 UTC (permalink / raw)
  To: 21895

[-- Attachment #1: Type: text/plain, Size: 73 bytes --]

twb points out that I can (require 'fringe) to make the problem go away.

[-- Attachment #2: Type: text/html, Size: 98 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#21895: [PATCH] shr: don't invoke unbound function (Bug#21895)
  2015-11-13  0:17 ` bug#21895: easy workaround Eric Hanchrow
@ 2015-11-13  1:29   ` Eric Hanchrow
  2015-11-13  1:35     ` Eric Hanchrow
                       ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Eric Hanchrow @ 2015-11-13  1:29 UTC (permalink / raw)
  To: 21895

[-- Attachment #1: Type: text/plain, Size: 2831 bytes --]

* lisp/net/shr.el (fringes-p):
New function.
(shr-insert-document, shr-fill-text): Use it.
---
 lisp/net/shr.el | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/lisp/net/shr.el b/lisp/net/shr.el
index 58deaea..853b2fd 100644
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -203,6 +203,12 @@ cid: URL as the argument.")
       (goto-char begin)
       (shr-insert-document dom))))

+(defun fringes-p ()
+  "Return t if fringe-columns is bound, and either (fringe-columns 'left)
or (fringe-columns 'right) returns nonzero."
+  (and (fboundp 'fringe-columns)
+       (or (not (zerop (fringe-columns 'right)))
+           (not (zerop (fringe-columns 'left))))))
+
 ;;;###autoload
 (defun shr-insert-document (dom)
   "Render the parsed document DOM into the current buffer.
@@ -230,19 +236,13 @@ DOM should be a parse tree as generated by
  (if (not shr-use-fonts)
     (- (window-body-width) 1
                                        (if (and (null shr-width)
-                                                (or (zerop
-                                                     (fringe-columns
'right))
-                                                    (zerop
-                                                     (fringe-columns
'left))))
+                                                (not (fringes-p)))
                                            0
                                          1))
   (- (window-body-width nil t)
                                      (* 2 (frame-char-width))
                                      (if (and (null shr-width)
-                                              (or (zerop
-                                                   (fringe-columns 'right))
-                                                  (zerop
-                                                   (fringe-columns
'left))))
+                                              (not (fringes-p)))
                                          (* (frame-char-width) 2)
                                        0))))))
     (shr-descend dom)
@@ -466,8 +466,7 @@ size, and full-buffer size."
                                    ;; to usurp one column for the
                                    ;; continuation glyph.
                                    (if (and (null shr-width)
-                                            (or (zerop (fringe-columns
'right))
-                                                (zerop (fringe-columns
'left))))
+                                            (not (fringes-p)))
                                        (* (frame-char-width) 2)
                                      0))))
  (shr-insert text)
-- 
2.6.3


On Thu, Nov 12, 2015 at 4:17 PM Eric Hanchrow <eric.hanchrow@gmail.com>
wrote:

> twb points out that I can (require 'fringe) to make the problem go away.
>

[-- Attachment #2: Type: text/html, Size: 4643 bytes --]

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* bug#21895: [PATCH] shr: don't invoke unbound function (Bug#21895)
  2015-11-13  1:29   ` bug#21895: [PATCH] shr: don't invoke unbound function (Bug#21895) Eric Hanchrow
@ 2015-11-13  1:35     ` Eric Hanchrow
  2015-11-13  1:48       ` John Wiegley
  2015-11-13  3:16     ` Glenn Morris
  2015-11-13  8:04     ` martin rudalics
  2 siblings, 1 reply; 11+ messages in thread
From: Eric Hanchrow @ 2015-11-13  1:35 UTC (permalink / raw)
  To: 21895


[-- Attachment #1.1: Type: text/plain, Size: 3079 bytes --]

Again, but as an attachment.

On Thu, Nov 12, 2015 at 5:29 PM Eric Hanchrow <eric.hanchrow@gmail.com>
wrote:

> * lisp/net/shr.el (fringes-p):
> New function.
> (shr-insert-document, shr-fill-text): Use it.
> ---
>  lisp/net/shr.el | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/lisp/net/shr.el b/lisp/net/shr.el
> index 58deaea..853b2fd 100644
> --- a/lisp/net/shr.el
> +++ b/lisp/net/shr.el
> @@ -203,6 +203,12 @@ cid: URL as the argument.")
>        (goto-char begin)
>        (shr-insert-document dom))))
>
> +(defun fringes-p ()
> +  "Return t if fringe-columns is bound, and either (fringe-columns 'left)
> or (fringe-columns 'right) returns nonzero."
> +  (and (fboundp 'fringe-columns)
> +       (or (not (zerop (fringe-columns 'right)))
> +           (not (zerop (fringe-columns 'left))))))
> +
>  ;;;###autoload
>  (defun shr-insert-document (dom)
>    "Render the parsed document DOM into the current buffer.
> @@ -230,19 +236,13 @@ DOM should be a parse tree as generated by
>   (if (not shr-use-fonts)
>      (- (window-body-width) 1
>                                         (if (and (null shr-width)
> -                                                (or (zerop
> -                                                     (fringe-columns
> 'right))
> -                                                    (zerop
> -                                                     (fringe-columns
> 'left))))
> +                                                (not (fringes-p)))
>                                             0
>                                           1))
>    (- (window-body-width nil t)
>                                       (* 2 (frame-char-width))
>                                       (if (and (null shr-width)
> -                                              (or (zerop
> -                                                   (fringe-columns
> 'right))
> -                                                  (zerop
> -                                                   (fringe-columns
> 'left))))
> +                                              (not (fringes-p)))
>                                           (* (frame-char-width) 2)
>                                         0))))))
>      (shr-descend dom)
> @@ -466,8 +466,7 @@ size, and full-buffer size."
>                                     ;; to usurp one column for the
>                                     ;; continuation glyph.
>                                     (if (and (null shr-width)
> -                                            (or (zerop (fringe-columns
> 'right))
> -                                                (zerop (fringe-columns
> 'left))))
> +                                            (not (fringes-p)))
>                                         (* (frame-char-width) 2)
>                                       0))))
>   (shr-insert text)
> --
> 2.6.3
>
>
> On Thu, Nov 12, 2015 at 4:17 PM Eric Hanchrow <eric.hanchrow@gmail.com>
> wrote:
>
>> twb points out that I can (require 'fringe) to make the problem go away.
>>
>

[-- Attachment #1.2: Type: text/html, Size: 4965 bytes --]

[-- Attachment #2: 0001-shr-don-t-invoke-unbound-function-Bug-21895.patch --]
[-- Type: application/octet-stream, Size: 2931 bytes --]

From ffe294d70617f1f5331f7fab93a29cafd0ee0787 Mon Sep 17 00:00:00 2001
From: Eric Hanchrow <eric.hanchrow@gmail.com>
Date: Thu, 12 Nov 2015 17:23:37 -0800
Subject: [PATCH] shr: don't invoke unbound function (Bug#21895)
To: 21895@debbugs.gnu.org

* lisp/net/shr.el (fringes-p):
New function.
(shr-insert-document, shr-fill-text): Use it.
---
 lisp/net/shr.el | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/lisp/net/shr.el b/lisp/net/shr.el
index 58deaea..853b2fd 100644
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -203,6 +203,12 @@ cid: URL as the argument.")
       (goto-char begin)
       (shr-insert-document dom))))
 
+(defun fringes-p ()
+  "Return t if fringe-columns is bound, and either (fringe-columns 'left) or (fringe-columns 'right) returns nonzero."
+  (and (fboundp 'fringe-columns)
+       (or (not (zerop (fringe-columns 'right)))
+           (not (zerop (fringe-columns 'left))))))
+
 ;;;###autoload
 (defun shr-insert-document (dom)
   "Render the parsed document DOM into the current buffer.
@@ -230,19 +236,13 @@ DOM should be a parse tree as generated by
 				(if (not shr-use-fonts)
 				    (- (window-body-width) 1
                                        (if (and (null shr-width)
-                                                (or (zerop
-                                                     (fringe-columns 'right))
-                                                    (zerop
-                                                     (fringe-columns 'left))))
+                                                (not (fringes-p)))
                                            0
                                          1))
 				  (- (window-body-width nil t)
                                      (* 2 (frame-char-width))
                                      (if (and (null shr-width)
-                                              (or (zerop
-                                                   (fringe-columns 'right))
-                                                  (zerop
-                                                   (fringe-columns 'left))))
+                                              (not (fringes-p)))
                                          (* (frame-char-width) 2)
                                        0))))))
     (shr-descend dom)
@@ -466,8 +466,7 @@ size, and full-buffer size."
                                    ;; to usurp one column for the
                                    ;; continuation glyph.
                                    (if (and (null shr-width)
-                                            (or (zerop (fringe-columns 'right))
-                                                (zerop (fringe-columns 'left))))
+                                            (not (fringes-p)))
                                        (* (frame-char-width) 2)
                                      0))))
 	(shr-insert text)
-- 
2.6.3


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* bug#21895: [PATCH] shr: don't invoke unbound function (Bug#21895)
  2015-11-13  1:35     ` Eric Hanchrow
@ 2015-11-13  1:48       ` John Wiegley
  0 siblings, 0 replies; 11+ messages in thread
From: John Wiegley @ 2015-11-13  1:48 UTC (permalink / raw)
  To: Eric Hanchrow; +Cc: 21895-done

>>>>> Eric Hanchrow <eric.hanchrow@gmail.com> writes:

> Again, but as an attachment.

Thanks, applied!

John





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#21895: [PATCH] shr: don't invoke unbound function (Bug#21895)
  2015-11-13  1:29   ` bug#21895: [PATCH] shr: don't invoke unbound function (Bug#21895) Eric Hanchrow
  2015-11-13  1:35     ` Eric Hanchrow
@ 2015-11-13  3:16     ` Glenn Morris
  2015-11-13  3:24       ` Glenn Morris
  2015-11-13  9:24       ` Eli Zaretskii
  2015-11-13  8:04     ` martin rudalics
  2 siblings, 2 replies; 11+ messages in thread
From: Glenn Morris @ 2015-11-13  3:16 UTC (permalink / raw)
  To: Eric Hanchrow; +Cc: 21895

Eric Hanchrow wrote:

> * lisp/net/shr.el (fringes-p):

That should have a shr- prefix, probably shr--.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#21895: [PATCH] shr: don't invoke unbound function (Bug#21895)
  2015-11-13  3:16     ` Glenn Morris
@ 2015-11-13  3:24       ` Glenn Morris
  2015-11-13  9:24       ` Eli Zaretskii
  1 sibling, 0 replies; 11+ messages in thread
From: Glenn Morris @ 2015-11-13  3:24 UTC (permalink / raw)
  To: Eric Hanchrow; +Cc: 21895


Also first line of doc should be a complete sentence.
Also doc basically just reiterates the code.
Something like "Return non-nil if there's a fringe." would be more typical.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#21895: [PATCH] shr: don't invoke unbound function (Bug#21895)
  2015-11-13  1:29   ` bug#21895: [PATCH] shr: don't invoke unbound function (Bug#21895) Eric Hanchrow
  2015-11-13  1:35     ` Eric Hanchrow
  2015-11-13  3:16     ` Glenn Morris
@ 2015-11-13  8:04     ` martin rudalics
  2015-11-13  8:23       ` Eli Zaretskii
  2 siblings, 1 reply; 11+ messages in thread
From: martin rudalics @ 2015-11-13  8:04 UTC (permalink / raw)
  To: Eric Hanchrow, 21895

 > +(defun fringes-p ()
 > +  "Return t if fringe-columns is bound, and either (fringe-columns 'left)
 > or (fringe-columns 'right) returns nonzero."
 > +  (and (fboundp 'fringe-columns)
 > +       (or (not (zerop (fringe-columns 'right)))
 > +           (not (zerop (fringe-columns 'left))))))
 > +

This is wrong when ‘fringe-columns’ is unbound and a fringe is present.
The right solution is to

(require 'fringe)

in ‘shr-mode’ as you proposed earlier.

martin






^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#21895: [PATCH] shr: don't invoke unbound function (Bug#21895)
  2015-11-13  8:04     ` martin rudalics
@ 2015-11-13  8:23       ` Eli Zaretskii
  2015-11-13 10:01         ` martin rudalics
  0 siblings, 1 reply; 11+ messages in thread
From: Eli Zaretskii @ 2015-11-13  8:23 UTC (permalink / raw)
  To: martin rudalics; +Cc: 21895, eric.hanchrow

> Date: Fri, 13 Nov 2015 09:04:37 +0100
> From: martin rudalics <rudalics@gmx.at>
> 
>  > +(defun fringes-p ()
>  > +  "Return t if fringe-columns is bound, and either (fringe-columns 'left)
>  > or (fringe-columns 'right) returns nonzero."
>  > +  (and (fboundp 'fringe-columns)
>  > +       (or (not (zerop (fringe-columns 'right)))
>  > +           (not (zerop (fringe-columns 'left))))))
>  > +
> 
> This is wrong when ‘fringe-columns’ is unbound and a fringe is present.

Why would that happen?  fringe.el is preloaded when GUI frames are
supported, and if not, there are no fringes.  What am I missing?

> The right solution is to
> 
> (require 'fringe)
> 
> in ‘shr-mode’ as you proposed earlier.

What if the user doesn't want fringes in her sessions?





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#21895: [PATCH] shr: don't invoke unbound function (Bug#21895)
  2015-11-13  3:16     ` Glenn Morris
  2015-11-13  3:24       ` Glenn Morris
@ 2015-11-13  9:24       ` Eli Zaretskii
  1 sibling, 0 replies; 11+ messages in thread
From: Eli Zaretskii @ 2015-11-13  9:24 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 21895, eric.hanchrow

> From: Glenn Morris <rgm@gnu.org>
> Date: Thu, 12 Nov 2015 22:16:17 -0500
> Cc: 21895@debbugs.gnu.org
> 
> Eric Hanchrow wrote:
> 
> > * lisp/net/shr.el (fringes-p):
> 
> That should have a shr- prefix, probably shr--.

Fixed.

> Also first line of doc should be a complete sentence.
> Also doc basically just reiterates the code.
> Something like "Return non-nil if there's a fringe." would be more typical.

Fixed.

Thanks.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#21895: [PATCH] shr: don't invoke unbound function (Bug#21895)
  2015-11-13  8:23       ` Eli Zaretskii
@ 2015-11-13 10:01         ` martin rudalics
  0 siblings, 0 replies; 11+ messages in thread
From: martin rudalics @ 2015-11-13 10:01 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 21895, eric.hanchrow

 >> This is wrong when ‘fringe-columns’ is unbound and a fringe is present.
 >
 > Why would that happen?  fringe.el is preloaded when GUI frames are
 > supported, and if not, there are no fringes.  What am I missing?

Nothing.  You are right and I was wrong.

martin






^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2015-11-13 10:01 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-13  0:06 bug#21895: 25.0.50; eww: Lisp error: (void-function fringe-columns) Eric Hanchrow
2015-11-13  0:17 ` bug#21895: easy workaround Eric Hanchrow
2015-11-13  1:29   ` bug#21895: [PATCH] shr: don't invoke unbound function (Bug#21895) Eric Hanchrow
2015-11-13  1:35     ` Eric Hanchrow
2015-11-13  1:48       ` John Wiegley
2015-11-13  3:16     ` Glenn Morris
2015-11-13  3:24       ` Glenn Morris
2015-11-13  9:24       ` Eli Zaretskii
2015-11-13  8:04     ` martin rudalics
2015-11-13  8:23       ` Eli Zaretskii
2015-11-13 10:01         ` martin rudalics

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).