bug#9764: 24.0.90; Stop tracing in Edebug

bug#9764: 24.0.90; Stop tracing in Edebug

[Dani Moncayo]

[This is the first time I try Edebug, so, maybe I'm missing something].

From "emacs -Q":

1. Instrument the function [a] for Edebug ("C-u C-M-x" from the function).
2. Type "(fac 3) C-x C-e" (to begin Edebugging).
3. Type "t" (to start tracing).
4. Before the execution ends, type "S" (to stop tracing).
--> (Observed) Tracing does not stop (SPC, "n" or any other command
doesn't seem to work either).
--> (Expected) Tracing stops, as described in [b].


In GNU Emacs 24.0.90.1 (i386-mingw-nt6.1.7601)
 of 2011-10-13 on DANI-PC
Windowing system distributor `Microsoft Corp.', version 6.1.7601
configured using `configure --with-gcc (4.5)'

--- Footnotes ---

[a]
(defun fac (n)
  (if (< 0 n)
      (* n (fac (1- n)))
    1))

[b] Paragraph from (info "(elisp)Edebug Execution Modes"):
     While executing or tracing, you can interrupt the execution by typing
  any Edebug command.  Edebug stops the program at the next stop point and
  then executes the command you typed.  For example, typing `t' during
  execution switches to trace mode at the next stop point.  You can use
  `S' to stop execution without doing anything else.


-- 
Dani Moncayo

bug#9764: 24.0.90; Stop tracing in Edebug

[Michael Heerdegen]

Dani Moncayo <dmoncayo@gmail.com> writes:

> From "emacs -Q":
>
> 1. Instrument the function [a] for Edebug ("C-u C-M-x" from the function).
> 2. Type "(fac 3) C-x C-e" (to begin Edebugging).
> 3. Type "t" (to start tracing).
> 4. Before the execution ends, type "S" (to stop tracing).
> --> (Observed) Tracing does not stop (SPC, "n" or any other command
> doesn't seem to work either).
> --> (Expected) Tracing stops, as described in [b].

I tried to debug this.  Have a look at `edebug-display'.  The user input
"S" typically happens here:

  ;; not edebug-break
  ((eq edebug-execution-mode 'trace)
   (edebug-sit-for edebug-sit-for-seconds)) ; Force update and pause.

in the `edebug-sit-for'.

The following code doesn't check for pending input.

And at the end of the defun, in the unwind clause of `unwind-protect',
`unread-command-events' gets reset to the value of
`edebug-outside-unread-command-events', canceling the user input.


HTH,

Michael.