* bug#9952: Default value displayed twice in `goto-line' prompt
@ 2011-11-04 16:44 Dani Moncayo
2011-11-04 20:33 ` Juri Linkov
0 siblings, 1 reply; 7+ messages in thread
From: Dani Moncayo @ 2011-11-04 16:44 UTC (permalink / raw)
To: 9952
Hi,
From "emacs -Q":
1. Type "3 M-g g".
Observed minibuffer prompt: "Goto line (3) (default 3): ".
Expected: "Goto line (default 3): ".
I think that the following patch fixes this problem:
=== modified file 'lisp/simple.el'
--- lisp/simple.el 2011-10-27 03:01:40 +0000
+++ lisp/simple.el 2011-11-04 16:36:39 +0000
@@ -924,10 +924,7 @@
(concat " in " (buffer-name buffer))
"")))
;; Read the argument, offering that number (if any) as default.
- (list (read-number (format (if default "Goto line%s (%s): "
- "Goto line%s: ")
- buffer-prompt
- default)
+ (list (read-number (format "Goto line%s: " buffer-prompt)
default)
buffer))))
;; Switch to the desired buffer, one way or another.
In GNU Emacs 24.0.90.1 (i386-mingw-nt6.1.7601)
of 2011-10-27 on DANI-PC
Windowing system distributor `Microsoft Corp.', version 6.1.7601
configured using `configure --with-gcc (4.5)'
--
Dani Moncayo
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#9952: Default value displayed twice in `goto-line' prompt
2011-11-04 16:44 bug#9952: Default value displayed twice in `goto-line' prompt Dani Moncayo
@ 2011-11-04 20:33 ` Juri Linkov
2011-11-04 21:41 ` Dani Moncayo
0 siblings, 1 reply; 7+ messages in thread
From: Juri Linkov @ 2011-11-04 20:33 UTC (permalink / raw)
To: Dani Moncayo; +Cc: 9952
> Observed minibuffer prompt: "Goto line (3) (default 3): ".
> Expected: "Goto line (default 3): ".
Please see bug#9201.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#9952: Default value displayed twice in `goto-line' prompt
2011-11-04 20:33 ` Juri Linkov
@ 2011-11-04 21:41 ` Dani Moncayo
2011-11-05 8:23 ` Dani Moncayo
0 siblings, 1 reply; 7+ messages in thread
From: Dani Moncayo @ 2011-11-04 21:41 UTC (permalink / raw)
To: Juri Linkov; +Cc: 9952
On Fri, Nov 4, 2011 at 21:33, Juri Linkov <juri@jurta.org> wrote:
>> Observed minibuffer prompt: "Goto line (3) (default 3): ".
>> Expected: "Goto line (default 3): ".
>
> Please see bug#9201.
Oops, I'm Sorry, my patch is a subset of yours.
So, may we close this bug report or merge both of them?
--
Dani Moncayo
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#9952: Default value displayed twice in `goto-line' prompt
2011-11-04 21:41 ` Dani Moncayo
@ 2011-11-05 8:23 ` Dani Moncayo
2011-11-06 14:34 ` Juri Linkov
0 siblings, 1 reply; 7+ messages in thread
From: Dani Moncayo @ 2011-11-05 8:23 UTC (permalink / raw)
To: Juri Linkov; +Cc: 9952
forcemerge 9201 9952
stop
>>> Observed minibuffer prompt: "Goto line (3) (default 3): ".
>>> Expected: "Goto line (default 3): ".
>>
>> Please see bug#9201.
>
> Oops, I'm Sorry, my patch is a subset of yours.
>
> So, may we close this bug report or merge both of them?
I'm merging them, although #9952 is actually a subset of #9201.
--
Dani Moncayo
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#9952: Default value displayed twice in `goto-line' prompt
2011-11-05 8:23 ` Dani Moncayo
@ 2011-11-06 14:34 ` Juri Linkov
2012-07-28 18:02 ` Dani Moncayo
0 siblings, 1 reply; 7+ messages in thread
From: Juri Linkov @ 2011-11-06 14:34 UTC (permalink / raw)
To: Dani Moncayo; +Cc: 9952
>>>> Observed minibuffer prompt: "Goto line (3) (default 3): ".
>>>> Expected: "Goto line (default 3): ".
>>>
>>> Please see bug#9201.
>>
>> Oops, I'm Sorry, my patch is a subset of yours.
>>
>> So, may we close this bug report or merge both of them?
>
> I'm merging them, although #9952 is actually a subset of #9201.
Thanks for merging. This is not considered a bug, so will be fixed in 24.2.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#9952: Default value displayed twice in `goto-line' prompt
2011-11-06 14:34 ` Juri Linkov
@ 2012-07-28 18:02 ` Dani Moncayo
2012-07-29 18:12 ` Juri Linkov
0 siblings, 1 reply; 7+ messages in thread
From: Dani Moncayo @ 2012-07-28 18:02 UTC (permalink / raw)
To: Juri Linkov; +Cc: 9952
>> I'm merging them, although #9952 is actually a subset of #9201.
>
> Thanks for merging. This is not considered a bug, so will be fixed in 24.2.
Ping.
--
Dani Moncayo
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#9952: Default value displayed twice in `goto-line' prompt
2012-07-28 18:02 ` Dani Moncayo
@ 2012-07-29 18:12 ` Juri Linkov
0 siblings, 0 replies; 7+ messages in thread
From: Juri Linkov @ 2012-07-29 18:12 UTC (permalink / raw)
To: Dani Moncayo; +Cc: 9952-done
> Ping.
Thanks, installed.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-07-29 18:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-04 16:44 bug#9952: Default value displayed twice in `goto-line' prompt Dani Moncayo
2011-11-04 20:33 ` Juri Linkov
2011-11-04 21:41 ` Dani Moncayo
2011-11-05 8:23 ` Dani Moncayo
2011-11-06 14:34 ` Juri Linkov
2012-07-28 18:02 ` Dani Moncayo
2012-07-29 18:12 ` Juri Linkov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).