unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#23469: Feature request: automatically instrument forms when setting Edebug breakpoint
@ 2016-05-06 17:16 Paul Pogonyshev
  2019-10-20 10:26 ` Lars Ingebrigtsen
  2019-11-01 16:29 ` bug#23469: no change Paul Pogonyshev
  0 siblings, 2 replies; 4+ messages in thread
From: Paul Pogonyshev @ 2016-05-06 17:16 UTC (permalink / raw)
  To: 23469

If you issue M-x edebug-set-breakpoint inside a random function
definition, you will get "Not inside instrumented form" error. So, you
need to C-u C-M-x it first manually. In addition to being annoying, it
can also lead to accidental breakpoint loss, since you can't easily
tell if a form is already instrumented and has breakpoints.

Request: instead of signalling an error, Emacs should just
automatically instrument function if I set a breakpoint in it.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#23469: Feature request: automatically instrument forms when setting Edebug breakpoint
  2016-05-06 17:16 bug#23469: Feature request: automatically instrument forms when setting Edebug breakpoint Paul Pogonyshev
@ 2019-10-20 10:26 ` Lars Ingebrigtsen
  2019-11-01 16:29 ` bug#23469: no change Paul Pogonyshev
  1 sibling, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2019-10-20 10:26 UTC (permalink / raw)
  To: Paul Pogonyshev; +Cc: 23469

Paul Pogonyshev <pogonyshev@gmail.com> writes:

> If you issue M-x edebug-set-breakpoint inside a random function
> definition, you will get "Not inside instrumented form" error. So, you
> need to C-u C-M-x it first manually. In addition to being annoying, it
> can also lead to accidental breakpoint loss, since you can't easily
> tell if a form is already instrumented and has breakpoints.
>
> Request: instead of signalling an error, Emacs should just
> automatically instrument function if I set a breakpoint in it.

Good idea.  I've now done this in Emacs 27.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#23469: no change
  2016-05-06 17:16 bug#23469: Feature request: automatically instrument forms when setting Edebug breakpoint Paul Pogonyshev
  2019-10-20 10:26 ` Lars Ingebrigtsen
@ 2019-11-01 16:29 ` Paul Pogonyshev
  2019-11-01 16:43   ` Lars Ingebrigtsen
  1 sibling, 1 reply; 4+ messages in thread
From: Paul Pogonyshev @ 2019-11-01 16:29 UTC (permalink / raw)
  To: 23469

Your change doesn't seem to do anything at all. E.g. start `emacs -q',
type some defun in the scratch buffer, M-: (require 'edebug) and try
to set a breakpoint within the defun. It fails with the same message
as before. Whether you C-M-x it first or not.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#23469: no change
  2019-11-01 16:29 ` bug#23469: no change Paul Pogonyshev
@ 2019-11-01 16:43   ` Lars Ingebrigtsen
  0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2019-11-01 16:43 UTC (permalink / raw)
  To: Paul Pogonyshev; +Cc: 23469

Paul Pogonyshev <pogonyshev@gmail.com> writes:

> Your change doesn't seem to do anything at all. E.g. start `emacs -q',
> type some defun in the scratch buffer, M-: (require 'edebug) and try
> to set a breakpoint within the defun. It fails with the same message
> as before. Whether you C-M-x it first or not.

Huh.  Yeah, that change didn't work at all -- my test case must have
been all wrong.

I've tweaked it, and now it works from -Q for me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-11-01 16:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-06 17:16 bug#23469: Feature request: automatically instrument forms when setting Edebug breakpoint Paul Pogonyshev
2019-10-20 10:26 ` Lars Ingebrigtsen
2019-11-01 16:29 ` bug#23469: no change Paul Pogonyshev
2019-11-01 16:43   ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).