bug#26177: pcase spams me with useless and cryptic messages intended for internal use

bug#26177: pcase spams me with useless and cryptic messages intended for internal use

[Paul Pogonyshev]

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

To reproduce, evaluate this:

(defmacro kek (&rest more-cases)
  `(pcase it
     (`foo 1)
     ,@more-cases))

(defun lol (x)
  (--each x
    (kek))
  (--each x
    (kek (`baz 3))))

Observe that there is "pcase-memoize: equal first branch, yet
different" gibberish in *Messages* buffer.

Attached patch comments out this debug output.

[-- Attachment #2: silence-pcase.diff --]
[-- Type: text/plain, Size: 783 bytes --]

diff --git a/lisp/emacs-lisp/pcase.el b/lisp/emacs-lisp/pcase.el
index 289265abf2..fc5474ecc4 100644
--- a/lisp/emacs-lisp/pcase.el
+++ b/lisp/emacs-lisp/pcase.el
@@ -175,8 +175,8 @@ Emacs Lisp manual for more information and examples."
       ;; (when (gethash (car cases) pcase--memoize-2)
       ;;   (message "pcase-memoize failed because of eq test on %S"
       ;;            (car cases)))
-      (when data
-        (message "pcase-memoize: equal first branch, yet different"))
+      ;; (when data
+      ;;   (message "pcase-memoize: equal first branch, yet different"))
       (let ((expansion (pcase--expand exp cases)))
         (puthash (car cases) `(,exp ,cases ,@expansion) pcase--memoize)
         ;; (puthash (car cases) `(,exp ,cases ,@expansion) pcase--memoize-1)

bug#26177:

[Paul Pogonyshev]

tags: patch

thanks

bug#26177:

[npostavs]

tags 26177 fixed
close 26177 26.1
quit

Pushed to master [1: 9278d904af].

1: 2017-03-25 19:28:22 -0400 9278d904af13c3c083defdcbf5fa21260d4457c3
  * lisp/emacs-lisp/pcase.el (pcase): Comment debug message (Bug#26177).

Paul Pogonyshev <pogonyshev@gmail.com> writes:

> tags: patch
>
> thanks

You need to send to control@debbugs.gnu.org and the format is a bit
different.  See https://debbugs.gnu.org/server-control.html.