From: "Nicolas Bértolo" <nicolasbertolo@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 41754@debbugs.gnu.org, Andrea Corallo <akrl@sdf.org>
Subject: bug#41754: [feature/native-comp] Fix crash when loading lambdas from dumps with --enable-checking.
Date: Tue, 9 Jun 2020 12:11:15 -0300 [thread overview]
Message-ID: <CAFnS-O=5BNhMVDg2R6dw8-VfpmCWshsy0+LutDS4mMHyhxLtXQ@mail.gmail.com> (raw)
In-Reply-To: <83zh9c5lk6.fsf@gnu.org>
> This conses a string for each extension each time through the loop,
> doesn't it? Is that really necessary?
It does. I thought that keeping the code simple (aka using the FOR_* macros)
more important than saving a few memory allocations, especially when this
function accesses the filesystem, which should be much more expensive.
> AFAIU, you cons the extended_suf list to be able to use the
> FOR_* loops that manipulate lists, is that correct?
Exactly.
> If so, could it be that removing that constraint will lead to a more elegant
> and less expensive code? After all, all this function does is to append STR to
> each directory in PATH, then try finding the resulting file with or without one
> of the extensions in SUFFIXES. Could we produce the file name to probe without
> walking a single list?
I'll come up with a new version taking your suggestions into account.
Thanks, Nico.
next prev parent reply other threads:[~2020-06-09 15:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 19:08 bug#41754: [feature/native-comp] Fix crash when loading lambdas from dumps with --enable-checking Nicolas Bértolo
2020-06-07 19:28 ` Andrea Corallo
2020-06-07 19:48 ` Nicolas Bértolo
2020-06-08 15:42 ` Andrea Corallo
2020-06-08 21:30 ` Andrea Corallo
2020-06-09 11:54 ` Nicolas Bértolo
2020-06-09 14:07 ` Andrea Corallo
2020-06-09 14:30 ` Nicolas Bértolo
2020-06-09 15:02 ` Eli Zaretskii
2020-06-09 15:11 ` Nicolas Bértolo [this message]
2020-06-09 15:53 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFnS-O=5BNhMVDg2R6dw8-VfpmCWshsy0+LutDS4mMHyhxLtXQ@mail.gmail.com' \
--to=nicolasbertolo@gmail.com \
--cc=41754@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).