From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Newsgroups: gmane.emacs.bugs Subject: bug#41754: [feature/native-comp] Fix crash when loading lambdas from dumps with --enable-checking. Date: Tue, 9 Jun 2020 12:11:15 -0300 Message-ID: References: <83zh9c5lk6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="103325"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41754@debbugs.gnu.org, Andrea Corallo To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 09 17:12:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jifvA-000QnI-FF for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jun 2020 17:12:12 +0200 Original-Received: from localhost ([::1]:45532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jifv9-0005BY-GM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jun 2020 11:12:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jifv0-0005BA-Ln for bug-gnu-emacs@gnu.org; Tue, 09 Jun 2020 11:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49048) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jifv0-0002FF-D5 for bug-gnu-emacs@gnu.org; Tue, 09 Jun 2020 11:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jifv0-0003So-6r for bug-gnu-emacs@gnu.org; Tue, 09 Jun 2020 11:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jun 2020 15:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41754 X-GNU-PR-Package: emacs Original-Received: via spool by 41754-submit@debbugs.gnu.org id=B41754.159171549513278 (code B ref 41754); Tue, 09 Jun 2020 15:12:02 +0000 Original-Received: (at 41754) by debbugs.gnu.org; 9 Jun 2020 15:11:35 +0000 Original-Received: from localhost ([127.0.0.1]:60594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jifuZ-0003S6-0e for submit@debbugs.gnu.org; Tue, 09 Jun 2020 11:11:35 -0400 Original-Received: from mail-oi1-f174.google.com ([209.85.167.174]:44116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jifuX-0003Rt-Hb for 41754@debbugs.gnu.org; Tue, 09 Jun 2020 11:11:33 -0400 Original-Received: by mail-oi1-f174.google.com with SMTP id x202so19035434oix.11 for <41754@debbugs.gnu.org>; Tue, 09 Jun 2020 08:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q7I8jWwT4yZT8htsecvbdP8WHv1fA+mba5Y8CHgKmjI=; b=cXZYgVcALBAR0HEw2tOJCXS+NkQ8G3QgIUp7YvJ2coRc10KUp2SkAyD5RdOuG2y62c bt5952wPlnP+TGDlTjr/MQ+4/BKaiw35cGtwjpPrKBv0FR9QSibEyP1glguxdnnNmm2O AxK85C0a4puBOay1gYiURFM/4OZog9xqYhBshHYC0ClstDj2SbcnduNCJWjV9/H4WH4i MbT45/bxooVEkP1Lo6Frvt787z3r3KLp3XFy2+BhbX+YACE4vHHnKJeESIyWt9YgtLOz W5carMU+ga8CfmcubbDUNZiqj8uv9mC5FAgVu294uCUU8A5JGfKamxTDhf6rq+06c9o0 R0CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q7I8jWwT4yZT8htsecvbdP8WHv1fA+mba5Y8CHgKmjI=; b=GID24KezFnXo2mg/H6uM6aO056VSIqUcf+PC+VHlyH/KF723Ck8GWyEZfE44D8fvjK aIHRXweKqL3C6xrUf4TWkHLuY51iSozYQICHu38wBY+qCGTwfjce+TpRF6jbYiGtMTBa TWtMr4pl1kBSCLWOTvLIxrPbSVlBslf/8d4/BPOAJW2aeUeNz8+isFn2bdRoaywfgZ6q JQZHeANhHmGNFt9pBMGFWodUv5Id6g4zAy+wVTzQ/FmOgGW377fBaC8h2atc7Out4Enl VyEgiyYsxOjVeQfY1pBcLwAB7Aou26ul+EFIO9KeEe1aMefJqDRG6EyJmeWwoWcNgBWX PTJA== X-Gm-Message-State: AOAM5318Gm5xZ0A3bueBPDKhMU2kN1I6CYY4HVZp5dX2Iv5h2SenBX6C FgKLPfbyH6rd91Y48Rxcnu2bvxyCjcSXxbqDRLQ= X-Google-Smtp-Source: ABdhPJwKi3C9nb1HdMshjMqADIpZVE6UGvwQxZYOxLELz9n7muZTC/xxfnlda2uYO+fA6ajVcKrbbKM2b/ByST1c6uA= X-Received: by 2002:aca:b742:: with SMTP id h63mr3826109oif.65.1591715487899; Tue, 09 Jun 2020 08:11:27 -0700 (PDT) In-Reply-To: <83zh9c5lk6.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181788 Archived-At: > This conses a string for each extension each time through the loop, > doesn't it? Is that really necessary? It does. I thought that keeping the code simple (aka using the FOR_* macros) more important than saving a few memory allocations, especially when this function accesses the filesystem, which should be much more expensive. > AFAIU, you cons the extended_suf list to be able to use the > FOR_* loops that manipulate lists, is that correct? Exactly. > If so, could it be that removing that constraint will lead to a more elegant > and less expensive code? After all, all this function does is to append STR to > each directory in PATH, then try finding the resulting file with or without one > of the extensions in SUFFIXES. Could we produce the file name to probe without > walking a single list? I'll come up with a new version taking your suggestions into account. Thanks, Nico.