unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#41108: 27.0.91; `register-read-with-preview' delete pre existing window
@ 2020-05-06 11:21 Héctor Enríquez Ramón
  2020-10-22 14:18 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Héctor Enríquez Ramón @ 2020-05-06 11:21 UTC (permalink / raw)
  To: 41108

[-- Attachment #1: Type: text/plain, Size: 1744 bytes --]

 Before `window-configuration-to-register'

 +-------------------+-----------------+
 |                   |                 |
 |                   |                 |
 |                   |                 |
 |                   |                 |
 +-------------------+-----------------+

 After `window-configuration-to-register'

 +-------------------------------------+
 |                                     |
 |                                     |
 |                                     |
 |                                     |
 +-------------------------------------+

 Then last (wrong) window configuration is saved to register.

 ```
 (defun register-read-with-preview (prompt)
 ...
      (let ((w (get-buffer-window buffer)))
        (and (window-live-p w) (delete-window w)))   <=== ### Don't check
 pre existing window ###
      (and (get-buffer buffer) (kill-buffer buffer)))))
 ```

 Thanks. Best regards.


 In GNU Emacs 27.0.91 (build 4, x86_64-pc-linux-gnu, cairo version 1.16.0)
 of 2020-05-06 built on Ubuntu-18
 Repository revision: f8e6cd11b34320999aa72886ece3f32b0a8ad897
 Repository branch: emacs-27
 Windowing system distributor 'The X.Org Foundation', version 11.0.12005000
 System Description: Ubuntu 19.10

 Configured using:
 'configure --with-cairo --with-x-toolkit=no CFLAGS=-O3'

 Configured features:
 XPM JPEG TIFF GIF PNG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY
 ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB OLDXMENU X11 XDBE
 XIM MODULES THREADS PDUMPER GMP

 Important settings:
  value of $LC_ALL:
  value of $LANG: es_ES.UTF-8
  locale-coding-system: utf-8
Date: Wed, 06 May 2020 13:11:21 +0200
Message-ID:
<87zhalgvxi.fsf@Ubuntu-18.i-did-not-set--mail-host-address--so-tickle-me>

[-- Attachment #2: Type: text/html, Size: 2151 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#41108: 27.0.91; `register-read-with-preview' delete pre existing window
  2020-05-06 11:21 bug#41108: 27.0.91; `register-read-with-preview' delete pre existing window Héctor Enríquez Ramón
@ 2020-10-22 14:18 ` Lars Ingebrigtsen
  2020-10-22 17:45   ` Héctor Enríquez Ramón
  0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2020-10-22 14:18 UTC (permalink / raw)
  To: Héctor Enríquez Ramón; +Cc: 41108

Héctor Enríquez Ramón <hector.e.r@gmail.com> writes:

>  Before `window-configuration-to-register'
>
>  +-------------------+-----------------+
>  |                   |                 |
>  |                   |                 |
>  |                   |                 |
>  |                   |                 |
>  +-------------------+-----------------+
>
>  After `window-configuration-to-register'
>
>  +-------------------------------------+
>  |                                     |
>  |                                     |
>  |                                     |
>  |                                     |
>  +-------------------------------------+
>
>  Then last (wrong) window configuration is saved to register.

I'm unable to reproduce this in Emacs 27.2, but I can't see any obvious
changes in this code, either.

Can you give a recipe to reproduce this bug, starting from "emacs -Q"?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#41108: 27.0.91; `register-read-with-preview' delete pre existing window
  2020-10-22 14:18 ` Lars Ingebrigtsen
@ 2020-10-22 17:45   ` Héctor Enríquez Ramón
  2020-10-23 10:50     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Héctor Enríquez Ramón @ 2020-10-22 17:45 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 41108

[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]

Hi Lars.

It works fine in Emacs branch emacs-27 (last commit).

Thank you very much. Best regards.

On Thu, 22 Oct 2020 at 16:18, Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Héctor Enríquez Ramón <hector.e.r@gmail.com> writes:
>
> >  Before `window-configuration-to-register'
> >
> >  +-------------------+-----------------+
> >  |                   |                 |
> >  |                   |                 |
> >  |                   |                 |
> >  |                   |                 |
> >  +-------------------+-----------------+
> >
> >  After `window-configuration-to-register'
> >
> >  +-------------------------------------+
> >  |                                     |
> >  |                                     |
> >  |                                     |
> >  |                                     |
> >  +-------------------------------------+
> >
> >  Then last (wrong) window configuration is saved to register.
>
> I'm unable to reproduce this in Emacs 27.2, but I can't see any obvious
> changes in this code, either.
>
> Can you give a recipe to reproduce this bug, starting from "emacs -Q"?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no
>

[-- Attachment #2: Type: text/html, Size: 2356 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#41108: 27.0.91; `register-read-with-preview' delete pre existing window
  2020-10-22 17:45   ` Héctor Enríquez Ramón
@ 2020-10-23 10:50     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2020-10-23 10:50 UTC (permalink / raw)
  To: Héctor Enríquez Ramón; +Cc: 41108

Héctor Enríquez Ramón <hector.e.r@gmail.com> writes:

> It works fine in Emacs branch emacs-27 (last commit).

Thanks for checking; closing the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-10-23 10:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06 11:21 bug#41108: 27.0.91; `register-read-with-preview' delete pre existing window Héctor Enríquez Ramón
2020-10-22 14:18 ` Lars Ingebrigtsen
2020-10-22 17:45   ` Héctor Enríquez Ramón
2020-10-23 10:50     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).