From: Unknown <unknown@unknown.invalid>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 43195@debbugs.gnu.org
Subject: bug#43195: [PATCH] Remove definitions of UP, BC and PC which should be provided by terminfo
Date: Sat, 12 Sep 2020 00:33:27 -0700 [thread overview]
Message-ID: <CAFP8O3Jtvhn7HCOZrd+TQnHTBFkYCGg-XaQ6wjs_e8=DwjzOYA@mail.gmail.com> (raw)
In-Reply-To: <83lfhfea23.fsf@gnu.org>
On Sat, Sep 12, 2020 at 12:19 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > Date: Fri, 4 Sep 2020 08:38:03 -0700
> > From: Fangrui Song <maskray@google.com>
> > Cc: 43195@debbugs.gnu.org
> >
> > >diff --git a/src/terminfo.c b/src/terminfo.c
> > >index 51fd32e..0765996 100644
> > >--- a/src/terminfo.c
> > >+++ b/src/terminfo.c
> > >@@ -23,9 +23,12 @@
> > >
> > > /* Define these variables that serve as global parameters to termcap,
> > > so that we do not need to conditionalize the places in Emacs
> > >- that set them. */
> > >+ that set them. But don't do that for terminfo, as that could
> > >+ cause link errors when using -fno-common. */
> > >
> > >+#if !TERMINFO
> > > char *UP, *BC, PC;
> > >+#endif
> > >
> > > /* Interface to curses/terminfo library.
> > > Turns out that all of the terminfo-level routines look
> > >
> >
> > Looks great! Thanks!
>
> Thanks, installed for Emacs 27.2.
>
> > One nit,
> >
> > #if !TERMINFO
> >
> > probably should be
> >
> > #ifndef TERMINFO
>
> That's the same thing with modern compilers.
>
> > I don't know whether it is worth mentioning that -fcommon/-fno-common does not
> > cause a linker error when libtinfo.so is linked (a common/regular definition
> > preempts a shared definition).
> >
> > -fno-common + libtinfo.a => multiple definition error
>
> OK, but the change works even in these other cases, right?
Yep! The new code should work in other cases, -fcommon/-fno-common x
libtinfo.a/libtinfo.so
next prev parent reply other threads:[~2020-09-12 7:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 0:57 bug#43195: [PATCH] Remove definitions of UP, BC and PC which should be provided by terminfo Fangrui Song via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-04 7:36 ` Eli Zaretskii
2020-09-04 15:38 ` Fangrui Song via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-12 7:19 ` Eli Zaretskii
2020-09-12 7:33 ` Unknown [this message]
2020-09-12 7:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFP8O3Jtvhn7HCOZrd+TQnHTBFkYCGg-XaQ6wjs_e8=DwjzOYA@mail.gmail.com' \
--to=unknown@unknown.invalid \
--cc=43195@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).