From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Unknown Newsgroups: gmane.emacs.bugs Subject: bug#43195: [PATCH] Remove definitions of UP, BC and PC which should be provided by terminfo Date: Sat, 12 Sep 2020 00:33:27 -0700 Message-ID: References: <20200904005748.1538513-1-maskray@google.com> <83wo1at2lu.fsf@gnu.org> <20200904153803.esenh3j2af4ymyd7@google.com> <83lfhfea23.fsf@gnu.org> Reply-To: =?UTF-8?Q?Reply-to=3A_F=C3=84=C2=81ng-ru=C3=83=C2=AC_S=C3=83=C2=B2ng=0A_?= =?UTF-8?Q?=3Cmaskray=40google=2Ecom=3E=0A?= Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5780"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43195@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 12 09:34:45 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kH03Z-0001Rk-9O for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Sep 2020 09:34:45 +0200 Original-Received: from localhost ([::1]:39660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kH03Y-0004Es-CR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Sep 2020 03:34:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH02s-0003hL-Ov for bug-gnu-emacs@gnu.org; Sat, 12 Sep 2020 03:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kH02s-000460-Dv for bug-gnu-emacs@gnu.org; Sat, 12 Sep 2020 03:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kH02s-0001S0-9J for bug-gnu-emacs@gnu.org; Sat, 12 Sep 2020 03:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?F=C4=81ng-ru=C3=AC_?= =?UTF-8?Q?S=C3=B2ng?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Sep 2020 07:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43195 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43195-submit@debbugs.gnu.org id=B43195.15998960285557 (code B ref 43195); Sat, 12 Sep 2020 07:34:02 +0000 Original-Received: (at 43195) by debbugs.gnu.org; 12 Sep 2020 07:33:48 +0000 Original-Received: from localhost ([127.0.0.1]:46110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kH02e-0001RZ-3d for submit@debbugs.gnu.org; Sat, 12 Sep 2020 03:33:48 -0400 Original-Received: from mail-pg1-f179.google.com ([209.85.215.179]:34007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kH02a-0001RJ-AF for 43195@debbugs.gnu.org; Sat, 12 Sep 2020 03:33:47 -0400 Original-Received: by mail-pg1-f179.google.com with SMTP id u13so8047304pgh.1 for <43195@debbugs.gnu.org>; Sat, 12 Sep 2020 00:33:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jViMqXLFyr8aEyYE6YVQWyIOr6KvRSGGT3T0/FzKCec=; b=i78InrmmhKXzrDT/Kl0YeQJLv0Gk4Zl9Qpn/hnF3BcIJbZorUl/4O8dsdmvhYlEGjy FD/9Qm27uirIY6wNP2mqYYwYZHzJj2uzAxyWy+ymF1PxxaQvKhOlg1+ABj7rsgQMmEwl u1etwf7sM/VrirSV7aBVWnnPzMrpW20mZFCEeCiCNOjELju8C9Jcp7cx9uL7xa8u1tx7 CADkTNwqW+N/5k2XSgxoifPqNHhpOcSlapR8dZvvTpL8WRgVl+LF4Yelm/XCge8gHjwy 9kiz/WCPyPXbxfspdfNfvRp4Dl0Dk9wlCQYJa0m5WErjfxzai7QcUnk97B9RmZK3093F FdWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jViMqXLFyr8aEyYE6YVQWyIOr6KvRSGGT3T0/FzKCec=; b=EP213vUaZ8OzonAkDk2awfYGFpoIFbAMpwTrpnZsDRmlzlRVT5XfItY3Y6ogek9U3V lqpKYJm4wJNQuOHHoGOSJ79yf2X0BPS1XNic0UXGTzUu5Xr9eAKvKxekULVl0RgqI67G jFosP8i26JgOexoXOUuRJ5WXJR/d6HKTIOfWg25Q25GruepXb/pxvmNcph7nzDLc1Gbw QPRPw/h8kR9oe5xju/kVr+i0tmsKTpXVAXmxYU5Y8L/TQAwRGHve3oxJTbglxg+tuX5M aaN4LDvKNcJUDfw5/rgKwTGz3erP5hJcXK5u2JBwUt6oI4VjnAvTZKrLLHYJxXL+QoZh Bjhw== X-Gm-Message-State: AOAM531V5kj5h+vwMkz3fVhjLwhHp1hVwuWnVjuOSFXIgPM2mKIE5z2M pJuNvEFC5hA4YbBztz5LovD64bsfq/hZUqAtcARDOw== X-Google-Smtp-Source: ABdhPJxvNiUwL0APDYycPYxiyJwfQwFZFHiVmZIDdR+cf3rIMGDbzsEhG6x9PLNZut1Z3CKZEsPv6JHxyE70dGhP5K4= X-Received: by 2002:a63:c64d:: with SMTP id x13mr4228798pgg.380.1599896018179; Sat, 12 Sep 2020 00:33:38 -0700 (PDT) In-Reply-To: <83lfhfea23.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Original-From: Xref: news.gmane.io gmane.emacs.bugs:187882 Archived-At: On Sat, Sep 12, 2020 at 12:19 AM Eli Zaretskii wrote: > > > Date: Fri, 4 Sep 2020 08:38:03 -0700 > > From: Fangrui Song > > Cc: 43195@debbugs.gnu.org > > > > >diff --git a/src/terminfo.c b/src/terminfo.c > > >index 51fd32e..0765996 100644 > > >--- a/src/terminfo.c > > >+++ b/src/terminfo.c > > >@@ -23,9 +23,12 @@ > > > > > > /* Define these variables that serve as global parameters to termcap, > > > so that we do not need to conditionalize the places in Emacs > > >- that set them. */ > > >+ that set them. But don't do that for terminfo, as that could > > >+ cause link errors when using -fno-common. */ > > > > > >+#if !TERMINFO > > > char *UP, *BC, PC; > > >+#endif > > > > > > /* Interface to curses/terminfo library. > > > Turns out that all of the terminfo-level routines look > > > > > > > Looks great! Thanks! > > Thanks, installed for Emacs 27.2. > > > One nit, > > > > #if !TERMINFO > > > > probably should be > > > > #ifndef TERMINFO > > That's the same thing with modern compilers. > > > I don't know whether it is worth mentioning that -fcommon/-fno-common does not > > cause a linker error when libtinfo.so is linked (a common/regular definition > > preempts a shared definition). > > > > -fno-common + libtinfo.a => multiple definition error > > OK, but the change works even in these other cases, right? Yep! The new code should work in other cases, -fcommon/-fno-common x libtinfo.a/libtinfo.so