From: Barry OReilly <gundaetiapo@gmail.com>
Cc: 14281@debbugs.gnu.org
Subject: bug#14281: 24.3; replace-match leaves point at wrong place
Date: Wed, 15 May 2013 16:44:03 -0400 [thread overview]
Message-ID: <CAFM41H041EJ7gbaw23n+YotYQ5_T-G2xk7CwpHz-wn2CwEX92w@mail.gmail.com> (raw)
In-Reply-To: <jwvli7gkqcu.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
Because looking_at_1 sets search_regs and last_thing_searched by differing
criteria. This patch makes them consistent in my test case.
diff --git a/src/insdel.c b/src/insdel.c
index 8029291..db2147f 100644
--- a/src/insdel.c
+++ b/src/insdel.c
diff --git a/src/search.c b/src/search.c
index ea36133..60658c8 100644
--- a/src/search.c
+++ b/src/search.c
@@ -336,10 +323,9 @@ looking_at_1 (Lisp_Object string, bool posix)
search_regs.end[i]
= BYTE_TO_CHAR (search_regs.end[i] + BEGV_BYTE);
}
-
- /* Set last_thing_searched only when match data is changed. */
- if (NILP (Vinhibit_changing_match_data))
+ /* Set last_thing_searched only when match data is changed. */
XSETBUFFER (last_thing_searched, current_buffer);
+ }
return val;
}
[-- Attachment #2: Type: text/html, Size: 872 bytes --]
next prev parent reply other threads:[~2013-05-15 20:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-27 1:19 bug#14281: 24.3; replace-match leaves point at wrong place Barry OReilly
2013-05-09 19:07 ` Barry OReilly
2013-05-09 21:27 ` Stefan Monnier
2013-05-10 13:27 ` Barry OReilly
2013-05-10 18:19 ` Barry OReilly
2013-05-10 20:56 ` Stefan Monnier
2013-05-14 17:01 ` Barry OReilly
2013-05-15 15:03 ` Barry OReilly
2013-05-15 19:18 ` Stefan Monnier
2013-05-15 20:44 ` Barry OReilly [this message]
2013-05-15 20:58 ` Barry OReilly
2013-05-21 21:49 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFM41H041EJ7gbaw23n+YotYQ5_T-G2xk7CwpHz-wn2CwEX92w@mail.gmail.com \
--to=gundaetiapo@gmail.com \
--cc=14281@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).