From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Barry OReilly Newsgroups: gmane.emacs.bugs Subject: bug#14281: 24.3; replace-match leaves point at wrong place Date: Wed, 15 May 2013 16:44:03 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c2d1b46b2c4d04dcc7cfe8 X-Trace: ger.gmane.org 1368650776 15122 80.91.229.3 (15 May 2013 20:46:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 May 2013 20:46:16 +0000 (UTC) Cc: 14281@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 15 22:46:15 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UciaU-00046j-ON for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 May 2013 22:46:15 +0200 Original-Received: from localhost ([::1]:42342 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UciaU-0004AN-8A for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 May 2013 16:46:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UciZW-00046G-Nu for bug-gnu-emacs@gnu.org; Wed, 15 May 2013 16:46:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UciZE-0006fR-5e for bug-gnu-emacs@gnu.org; Wed, 15 May 2013 16:45:14 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UciZD-0006fN-St for bug-gnu-emacs@gnu.org; Wed, 15 May 2013 16:44:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UciZJ-0000RQ-VF for bug-gnu-emacs@gnu.org; Wed, 15 May 2013 16:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Barry OReilly Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 May 2013 20:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14281 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14281-submit@debbugs.gnu.org id=B14281.13686506571612 (code B ref 14281); Wed, 15 May 2013 20:45:01 +0000 Original-Received: (at 14281) by debbugs.gnu.org; 15 May 2013 20:44:17 +0000 Original-Received: from localhost ([127.0.0.1]:46474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UciYb-0000Px-15 for submit@debbugs.gnu.org; Wed, 15 May 2013 16:44:17 -0400 Original-Received: from mail-oa0-f43.google.com ([209.85.219.43]:38989) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UciYZ-0000Pj-Ls for 14281@debbugs.gnu.org; Wed, 15 May 2013 16:44:16 -0400 Original-Received: by mail-oa0-f43.google.com with SMTP id o6so2790563oag.30 for <14281@debbugs.gnu.org>; Wed, 15 May 2013 13:44:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:cc:content-type; bh=Pgz2VKxFu+UsAgwzIScfRVPv+ccfbQJMe2pD1GGYSnQ=; b=b6eZVHB7hfthB7flr/ZRdJPG2IJ3nP9ZL71+BLNfIbt1i3CK+nolKgv/XNKPzs0E1B mOEhx0Peljy0sE9aZnHUPrKK3PhoJx0UZTFYCioI0AkuMhCaE4GF4NorY1eWYGTFXLA9 +1lnMG6sK2ppKI4tPDVqtq84fXlHlBK8PbMRgOX1RBDtyMA5YOzK2K/hfn5xaccJckUD JJaKHlY/JyLQ4tn+EAaX77bFS3M9++Dccb1gPwCVg3pTvTC7+5bbMOjMqKr0mAoNM+3u LBwRADhRqRHIgmEDlt7lWhGrGfcalaDgD9xYYEIIRJAmOdcVmbv1RxdFLTSHyETaRRf6 i4fg== X-Received: by 10.182.38.201 with SMTP id i9mr256257obk.55.1368650643350; Wed, 15 May 2013 13:44:03 -0700 (PDT) Original-Received: by 10.76.93.68 with HTTP; Wed, 15 May 2013 13:44:03 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74305 Archived-At: --001a11c2d1b46b2c4d04dcc7cfe8 Content-Type: text/plain; charset=ISO-8859-1 Because looking_at_1 sets search_regs and last_thing_searched by differing criteria. This patch makes them consistent in my test case. diff --git a/src/insdel.c b/src/insdel.c index 8029291..db2147f 100644 --- a/src/insdel.c +++ b/src/insdel.c diff --git a/src/search.c b/src/search.c index ea36133..60658c8 100644 --- a/src/search.c +++ b/src/search.c @@ -336,10 +323,9 @@ looking_at_1 (Lisp_Object string, bool posix) search_regs.end[i] = BYTE_TO_CHAR (search_regs.end[i] + BEGV_BYTE); } - - /* Set last_thing_searched only when match data is changed. */ - if (NILP (Vinhibit_changing_match_data)) + /* Set last_thing_searched only when match data is changed. */ XSETBUFFER (last_thing_searched, current_buffer); + } return val; } --001a11c2d1b46b2c4d04dcc7cfe8 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Because looking_at_1 sets search_regs and last_thing_searched by differing = criteria. This patch makes them consistent in my test case.

diff --g= it a/src/insdel.c b/src/insdel.c
index 8029291..db2147f 100644
--- a/= src/insdel.c
+++ b/src/insdel.c

diff --git a/src/search.c b/src/search.c
index= ea36133..60658c8 100644
--- a/src/search.c
+++ b/src/search.c
@@ = -336,10 +323,9 @@ looking_at_1 (Lisp_Object string, bool posix)
=A0=A0= =A0=A0=A0=A0=A0=A0=A0 search_regs.end[i]
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =3D BYTE_TO_CHAR (search_regs.end[i] + BE= GV_BYTE);
=A0=A0=A0=A0=A0=A0=A0 }
-
-=A0 /* Set last_thing_searche= d only when match data is changed.=A0 */
-=A0 if (NILP (Vinhibit_changin= g_match_data))
+=A0=A0=A0 /* Set last_thing_searched only when match dat= a is changed.=A0 */
=A0=A0=A0=A0 XSETBUFFER (last_thing_searched, current_buffer);
+=A0 }=A0
=A0=A0 return val;
=A0}


--001a11c2d1b46b2c4d04dcc7cfe8--