bug#64406: [PATCH] Improve commands to manage Python imports

[Matthias Meulien <orontee@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]

Sorry Eli for asking such trivial question but I didn't manage to find
hints on the web: Now that this bug is tagged as done, should I create a
new bug for last two patches or is it possible to reopen?

Le dim. 9 juil. 2023 à 08:09, Matthias Meulien <orontee@gmail.com> a écrit :

> Matthias Meulien <orontee@gmail.com> writes:
>
> > Augusto Stoffel <arstoffel@gmail.com> writes:
> >> (...)
> >> This change implies that the "success" branch may run if the exit code
> >> is nonzero (without knowing all the isort internals, it can't be
> >> excluded that an exit code > 2 is used somewhere).  I suggest instead a
> >> (pcase status ...) to construct the " (maybe... ?)" segment of the error
> >> message.
> >
> > Thanks, I'll fix this.
>
> >> We could also take this opportunity to distinguish between random
> >> exceptions happening in the script (which likely leads to exit code 1)
> >> and the ModuleNotFoundError case.
> >
> > Good point, I'll improve this too.
>
> Here are two patches.
>
> The first one revert part of the original patch where I introduced a
> useless detailed check of isort exit status itself.
>
> The second one relates to your remarks: It shift the custom exit status
> of the Python script and make sure that an error is reported assoon as
> exit code >0.
>
>

-- 
Matthias

[-- Attachment #2: Type: text/html, Size: 2021 bytes --]