From: Eli Zaretskii <eliz@gnu.org>
To: Matthias Meulien <orontee@gmail.com>
Cc: arstoffel@gmail.com, 64406@debbugs.gnu.org
Subject: bug#64406: [PATCH] Improve commands to manage Python imports
Date: Thu, 13 Jul 2023 09:07:34 +0300 [thread overview]
Message-ID: <83cz0w5opl.fsf@gnu.org> (raw)
In-Reply-To: <87bkgl39bm.fsf@gmail.com> (message from Matthias Meulien on Sun, 09 Jul 2023 08:09:17 +0200)
> Cc: 64406@debbugs.gnu.org
> From: Matthias Meulien <orontee@gmail.com>
> Date: Sun, 09 Jul 2023 08:09:17 +0200
>
> Here are two patches.
>
> The first one revert part of the original patch where I introduced a
> useless detailed check of isort exit status itself.
>
> The second one relates to your remarks: It shift the custom exit status
> of the Python script and make sure that an error is reported assoon as
> exit code >0.
Thanks. Could you please make a single patch from these two? There's
no need to revert the original one in a separate patch.
> Subject: [PATCH 1/2] Fix "Improve Python imports management commands"
>
> * lisp/progmodes/python.el (python--do-isort): The isort library don't
> check for its version itself!
I don't think I understand this log entry. What does it mean "the
isort library don't check its version"?
> + ((eq 3 status) " (maybe isort version is less than 5.7.0?)")
^^^^^^^
Here, "is older" should be more clear, I think.
next prev parent reply other threads:[~2023-07-13 6:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-01 20:16 bug#64406: [PATCH] Improve commands to manage Python imports Matthias Meulien
2023-07-06 7:28 ` Eli Zaretskii
2023-07-07 17:02 ` Augusto Stoffel
2023-07-07 17:46 ` Matthias Meulien
2023-07-09 6:09 ` Matthias Meulien
2023-07-09 6:32 ` Matthias Meulien
2023-07-09 7:28 ` Eli Zaretskii
2023-07-09 7:54 ` Matthias Meulien
2023-07-13 6:07 ` Eli Zaretskii [this message]
2023-07-13 21:07 ` Matthias Meulien
2023-07-15 8:25 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83cz0w5opl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64406@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=orontee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).