bug#14523: Inconsistency in font-lock/lisp mode for docstrings

bug#14523: Inconsistency in font-lock/lisp mode for docstrings

[Max Rottenkolber]

Greetings everybody,

On "GNU Emacs 24.2.1 (i486-slackware-linux-gnu, GTK+ Version 2.24.10) of
2012-08-31 on hive" using font-lock-mode it conjunction with lisp mode
(and Common Lisp code): If font-lock-doc-face != font-lock-string-face
docstrings are marked up inconsistently. E.g. DEFUN's docstrings use the
first face, but DEVAR docstrings use the latter face.

Cheers,
max

bug#14523: bug#14509: Centerd calendar buffer

[E Sabof]

[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]

A better version:

(defun es-calendar-recenter (&optional all-frames)
  (let (( calendar-width
          (+ (* 7 3 3)
             (* 2 calendar-intermonth-spacing)
             -1)))
    (save-excursion
      (goto-char (point-min))
      (while (search-forward-regexp "^ +" nil t)
        (put-text-property
         (match-beginning 0)
         (match-end 0)
         'display
         `(space :align-to (+ center (,(/ calendar-width -2)
                                      . width))))))))
(defadvice calendar-generate (after center-calendar activate)
  (es-calendar-recenter t))

(eval-after-load 'calendar
  '(defun calendar-update-mode-line ()
     "Update the calendar mode line with the current date and date style."
     (if (bufferp (get-buffer calendar-buffer))
         (with-current-buffer calendar-buffer
           (let* ((start (- calendar-left-margin 2))
                  (date (condition-case nil
                            (calendar-cursor-to-nearest-date)
                          (error (calendar-current-date))))
                  (content-string (calendar-string-spread
                                   (mapcar 'eval calendar-mode-line-format)
                                   ?\s (- calendar-right-margin (1-
start)))))
             (setq mode-line-format
                   (concat (propertize
                            " "
                            'display
                            `(space :align-to (+ center (,(/ (length
content-string) -2) . width))))
                           content-string)))
           (force-mode-line-update)))))

[-- Attachment #2: Type: text/html, Size: 2235 bytes --]

bug#14509: Fwd: bug#14509: Centerd calendar buffer

[E Sabof]

[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]

A better version:

(defun es-calendar-recenter (&optional all-frames)
  (let (( calendar-width
          (+ (* 7 3 3)
             (* 2 calendar-intermonth-spacing)
             -1)))
    (save-excursion
      (goto-char (point-min))
      (while (search-forward-regexp "^ +" nil t)
        (put-text-property
         (match-beginning 0)
         (match-end 0)
         'display
         `(space :align-to (+ center (,(/ calendar-width -2)
                                      . width))))))))
(defadvice calendar-generate (after center-calendar activate)
  (es-calendar-recenter t))

(eval-after-load 'calendar
  '(defun calendar-update-mode-line ()
     "Update the calendar mode line with the current date and date style."
     (if (bufferp (get-buffer calendar-buffer))
         (with-current-buffer calendar-buffer
           (let* ((start (- calendar-left-margin 2))
                  (date (condition-case nil
                            (calendar-cursor-to-nearest-date)
                          (error (calendar-current-date))))
                  (content-string (calendar-string-spread
                                   (mapcar 'eval calendar-mode-line-format)
                                   ?\s (- calendar-right-margin (1-
start)))))
             (setq mode-line-format
                   (concat (propertize
                            " "
                            'display
                            `(space :align-to (+ center (,(/ (length
content-string) -2) . width))))
                           content-string)))
           (force-mode-line-update)))))

[-- Attachment #2: Type: text/html, Size: 2315 bytes --]

bug#14523: Inconsistency in font-lock/lisp mode for docstrings

[Glenn Morris]

Max Rottenkolber wrote:

> On "GNU Emacs 24.2.1 (i486-slackware-linux-gnu, GTK+ Version 2.24.10) of
> 2012-08-31 on hive" using font-lock-mode it conjunction with lisp mode
> (and Common Lisp code): If font-lock-doc-face != font-lock-string-face
> docstrings are marked up inconsistently. E.g. DEFUN's docstrings use the
> first face, but DEVAR docstrings use the latter face.

Please give a complete example starting from emacs -Q.
I cannot reproduce this with:

emacs-24.2 -Q foo.el

where foo.el has contents:

(defun func () "function doc" t)
(defvar var "blah" "var doc")

Both doc-strings are in font-lock-doc-face.

bug#14523: Inconsistency in font-lock/lisp mode for docstrings

[Glenn Morris]

Glenn Morris wrote (on Sat, 1 Jun 2013 at 13:44 -0400):

> Please keep the debbugs address cc'd.

Otherwise when the person you are replying to puts the bug number in
by hand, they might get the wrong one, like I did. Sigh.

Max Rottenkolber wrote (on Sat, 1 Jun 2013 at 10:22 +0200):

> M-x customize-face RET font-lock-doc-face RET
> 
> Find file foo .lisp, enter:
> 
> (defun ()
>   "redish"
>   13)

Surely this defun is missing a name?

> (defvar *x* nil
>   "whatever you set doc-face to.")