unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Fredrik Nyqvist <fredrik.nyqvist94@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 38343@debbugs.gnu.org
Subject: bug#38343: 27.0.50; vc git: Cannot edit outgoing log (like git commit --amend)
Date: Mon, 25 Nov 2019 21:16:02 +0100	[thread overview]
Message-ID: <CAEhcwWaSxg=jJR54+16tB3EDDKF3CoeKhc9TKLyOu1v6oJa6=A@mail.gmail.com> (raw)
In-Reply-To: <a190865c-a1f7-6e7f-96c2-b8299e190944@yandex.ru>

[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]

Yes, I have tried the option you mention to edit the last commit with C-x
C-e and it is working fine.
But It seems that it only allows amending the last commit if I have edited
a file.

As I understand it I need to edit a file and then do vc-next-action to get
to the log-edit buffer
where you can do C-x C-e.

I could not find a way to do this if just the commit message is supposed to
be updated.

Den mån 25 nov. 2019 kl 12:48 skrev Dmitry Gutov <dgutov@yandex.ru>:

> On 23.11.2019 12:01, Fredrik Nyqvist wrote:
>
> > I would like to use vc mode to edit an outgoing commit message.
> >
> > Steps to reproduce:
> > 1. emacs -Q /path/to/git/repo
> > 2. Edit a file and then
> > 3. Run vc-next-action to create a commit: C-x v v
> > 4. Write a commit message and end with C-c C-c
> > 5. Now Open the outgoing log (vc-log-outgoing) : C-x v O
> > 6. Try to edit the commit message (log-view-modify-change-comment): e
> >
> > This message is printed:
> >
> > log-view-current-file: Unable to determine the current file
>
> Yes. This feature seems unfinished, and it was never updated for the
> newer VC systems.
>
> However, we have an option for amending the last commit (press C-x C-e
> in an already open log-edit buffer). It only works with Git and Hg now.
>

It would be good to unify these two features somehow.
>

[-- Attachment #2: Type: text/html, Size: 1938 bytes --]

  reply	other threads:[~2019-11-25 20:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23 10:01 bug#38343: 27.0.50; vc git: Cannot edit outgoing log (like git commit --amend) Fredrik Nyqvist
2019-11-25 11:48 ` Dmitry Gutov
2019-11-25 20:16   ` Fredrik Nyqvist [this message]
2019-11-25 22:49     ` Dmitry Gutov
2019-11-26 20:43       ` Fredrik Nyqvist
2019-11-27  0:10         ` Dmitry Gutov
2019-11-27 20:11           ` Fredrik Nyqvist
2019-11-27 22:08             ` Dmitry Gutov
2019-11-28 20:48               ` Fredrik Nyqvist

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEhcwWaSxg=jJR54+16tB3EDDKF3CoeKhc9TKLyOu1v6oJa6=A@mail.gmail.com' \
    --to=fredrik.nyqvist94@gmail.com \
    --cc=38343@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).