From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Fredrik Nyqvist Newsgroups: gmane.emacs.bugs Subject: bug#38343: 27.0.50; vc git: Cannot edit outgoing log (like git commit --amend) Date: Mon, 25 Nov 2019 21:16:02 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000711b2e0598316f6f" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="77544"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38343@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 25 21:18:41 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZKoj-000K1c-0w for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Nov 2019 21:18:41 +0100 Original-Received: from localhost ([::1]:47854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZKoh-0004W1-DH for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Nov 2019 15:18:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50526) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZKoP-0004VR-TQ for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 15:18:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZKn9-0003nc-BT for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 15:17:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43755) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZKn8-0003nQ-MN for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 15:17:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZKn8-0000Yn-Hm for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 15:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Fredrik Nyqvist Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Nov 2019 20:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38343 X-GNU-PR-Package: emacs Original-Received: via spool by 38343-submit@debbugs.gnu.org id=B38343.15747129812084 (code B ref 38343); Mon, 25 Nov 2019 20:17:02 +0000 Original-Received: (at 38343) by debbugs.gnu.org; 25 Nov 2019 20:16:21 +0000 Original-Received: from localhost ([127.0.0.1]:49727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZKmT-0000XW-Ao for submit@debbugs.gnu.org; Mon, 25 Nov 2019 15:16:21 -0500 Original-Received: from mail-qv1-f42.google.com ([209.85.219.42]:40470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZKmR-0000XK-Ko for 38343@debbugs.gnu.org; Mon, 25 Nov 2019 15:16:20 -0500 Original-Received: by mail-qv1-f42.google.com with SMTP id i3so6310050qvv.7 for <38343@debbugs.gnu.org>; Mon, 25 Nov 2019 12:16:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T3jDzKDf4AXp5OvPnp0Ayf7U/h4uUKDxhF0TXNJLDQw=; b=Mg5oGLWqNpq8AYKaKWrdAHy30dgsm0GXGU4QZw6DVfHBGDes0k8b7aCgu8ak/AZ1rr 4MjYPwwO5dLugo3q0HGz+x+kzbZJ02cbosETx+wR9yUNUqD2wvfCiDxp/woTdVPjz+Ag l8relzzAC5hBTui0Nst1S18vRxejgiB07sD5wG2MGZ9UU0oTCGkynQMzt8Z0DjXtaQ7E zb1lPwK2XedidMBGGKqwbTpR9uEWIc6vG3snpYsD6sMoYS1O6Ux+Nf0xOVyh78ECdynS I9ShNmT/NjrAvkrtq9xkmvhbu2ZsWmtsB9XdZe/diWUOzYnT3EVEKe+AmPULsi6NLZyP E41w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T3jDzKDf4AXp5OvPnp0Ayf7U/h4uUKDxhF0TXNJLDQw=; b=aaLARClrfaYL9itODjw9FXxD0lqeYjstbBh6NV4F6ITNX0qE5er6hgoAU2uhYUhPth UgeadDcarkV+UteJ6gppLt0UvgHzX/pzfVrBZYkPFT81lmvV6irlP19Tmm15a5T/6fvV AvcQ3lJwIFvIak5xb0tyqcrqUYusXDKswHgP8x72XIhQGXPf5qio1shJO2RFvIv4XjEN Wd2RIJklVHS1j/VQlkJmWEDtZdnKjVVCpguw27uLsq3PkeqBq6tvf/v7Iw0i9+ZHHOS8 Nr1IcRYXEEICc9s3QkiyNKWM7PHxkLJnYcGkKfLGqoBuiBIbywXwAmDS+VOte5Mxc6HG lbcQ== X-Gm-Message-State: APjAAAVU4JY0WtnflS6eOcpEIAyEbEfzE2zfyH3c7NoXLSpbT/Cf3Xhk LULAZbnAA63XbqRmovjmplv94dP1oEWT4r/Uv+ngvA== X-Google-Smtp-Source: APXvYqz5EBWyQNx3Ici8ZpYo8pRkY79m+5/c78nue20MxkhH5naOqywjoV5uRG5uLMtS9rirpxkDRHrcnDS1n5P7LwI= X-Received: by 2002:ad4:4106:: with SMTP id i6mr13428048qvp.175.1574712974053; Mon, 25 Nov 2019 12:16:14 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172376 Archived-At: --000000000000711b2e0598316f6f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes, I have tried the option you mention to edit the last commit with C-x C-e and it is working fine. But It seems that it only allows amending the last commit if I have edited a file. As I understand it I need to edit a file and then do vc-next-action to get to the log-edit buffer where you can do C-x C-e. I could not find a way to do this if just the commit message is supposed to be updated. Den m=C3=A5n 25 nov. 2019 kl 12:48 skrev Dmitry Gutov : > On 23.11.2019 12:01, Fredrik Nyqvist wrote: > > > I would like to use vc mode to edit an outgoing commit message. > > > > Steps to reproduce: > > 1. emacs -Q /path/to/git/repo > > 2. Edit a file and then > > 3. Run vc-next-action to create a commit: C-x v v > > 4. Write a commit message and end with C-c C-c > > 5. Now Open the outgoing log (vc-log-outgoing) : C-x v O > > 6. Try to edit the commit message (log-view-modify-change-comment): e > > > > This message is printed: > > > > log-view-current-file: Unable to determine the current file > > Yes. This feature seems unfinished, and it was never updated for the > newer VC systems. > > However, we have an option for amending the last commit (press C-x C-e > in an already open log-edit buffer). It only works with Git and Hg now. > It would be good to unify these two features somehow. > --000000000000711b2e0598316f6f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, I have tried the option you mention to edit the = last commit with C-x C-e and it is working fine.
But It seem= s that it only allows amending the last commit if I have edited a file.

As I understand it I need to edit a file and then do = vc-next-action to get to the log-edit buffer
where you can do C-x= C-e.

I could not find a way to do this if just th= e commit message is supposed to be updated.

Den m=C3=A5n 25 nov.= 2019 kl 12:48 skrev Dmitry Gutov <d= gutov@yandex.ru>:
On 23.11.2019 12:01, Fredrik Nyqvist wrote:

> I would like to use vc mode to edit an outgoing commit message.
>
> Steps to reproduce:
> 1. emacs -Q /path/to/git/repo
> 2. Edit a file and then
> 3. Run vc-next-action to create a commit: C-x v v
> 4. Write a commit message and end with C-c C-c
> 5. Now Open the outgoing log (vc-log-outgoing) : C-x v O
> 6. Try to edit the commit message (log-view-modify-change-comment): e<= br> >
> This message is printed:
>
> log-view-current-file: Unable to determine the current file

Yes. This feature seems unfinished, and it was never updated for the
newer VC systems.

However, we have an option for amending the last commit (press C-x C-e
in an already open log-edit buffer). It only works with Git and Hg now.
=C2=A0
It would be good to unify these two features somehow.
--000000000000711b2e0598316f6f--