bug#63872: [PATCH] `mouse-drag-and-drop-region' sometimes couldn't cut

bug#63872: [PATCH] `mouse-drag-and-drop-region' sometimes couldn't cut

[Shynur Xie]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

The function `mouse-drag-and-drop-region' couldn't cut/move the
selected region when `mark-even-if-inactive' is t.

Say execute `emacs -Q` then evaluate
    (custom-set-variables
     '(mark-even-if-inactive nil)
     '(mouse-drag-and-drop-region t))
When I use mouse to drag and drop a selected region, the region is not
cut and pasted; it is copied and pasted instead.

The attached patch binds `mark-even-if-inactive' to t within the body
of `mouse-drag-and-drop-region'.

--
shynur

[-- Attachment #2: 0001-Fix-bug-that-mouse-drag-and-drop-region-couldn-t-cut.patch --]
[-- Type: application/octet-stream, Size: 885 bytes --]

From e6c6d33b3b4f142d475a50c71b011ea0ef0f1533 Mon Sep 17 00:00:00 2001
From: Shynur <one.last.kiss@outlook.com>
Date: Sat, 3 Jun 2023 21:14:41 +0800
Subject: [PATCH] Fix bug that `mouse-drag-and-drop-region' couldn't cut

* lisp/mouse.el (mouse-drag-and-drop-region): Bind
`mark-even-if-inactive' to t locally.
---
 lisp/mouse.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/mouse.el b/lisp/mouse.el
index 3c30361ad7d..475b3871348 100644
--- a/lisp/mouse.el
+++ b/lisp/mouse.el
@@ -3154,6 +3154,7 @@ is copied instead of being cut."
          ;; System tooltips tend to flicker and in general work
          ;; incorrectly.
          (use-system-tooltips nil)
+         (mark-even-if-inactive t)
          ;; Whether or not some text was ``cut'' from Emacs to another
          ;; program and the cleaanup code should not try modifying the
          ;; region.
-- 
2.39.1

bug#63872: [PATCH] `mouse-drag-and-drop-region' sometimes couldn't cut

[Shynur Xie]

A typo in line 2:

> selected region when `mark-even-if-inactive' is t.
                                                  ^
                                         should be "nil" here

bug#63872: [PATCH] `mouse-drag-and-drop-region' sometimes couldn't cut

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Shynur Xie <one.last.kiss@outlook.com> writes:

> When I use mouse to drag and drop a selected region, the region is not
> cut and pasted; it is copied and pasted instead.

With transient-mark-mode on or off?

bug#63872: [PATCH] `mouse-drag-and-drop-region' sometimes couldn't cut

[Shynur Xie]

> From: Po Lu
> Date: Sun, 04 Jun 2023 08:31:31 +0800
>   To: Shynur
>
>> When I use mouse to drag and drop a selected region, the region is
>> not cut and pasted; it is copied and pasted instead.
>
> With transient-mark-mode on or off?

On, by default.  I used `-Q` to launch Emacs.

(I forgot to CC the last email, my apologies.  I am resending it now.)

bug#63872: [PATCH] `mouse-drag-and-drop-region' sometimes couldn't cut

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Shynur Xie <one.last.kiss@outlook.com> writes:

>> From: Po Lu
>> Date: Sun, 04 Jun 2023 08:31:31 +0800
>>   To: Shynur
>>
>>> When I use mouse to drag and drop a selected region, the region is
>>> not cut and pasted; it is copied and pasted instead.
>>
>> With transient-mark-mode on or off?
>
> On, by default.  I used `-Q` to launch Emacs.

Right.  Have you looked at the option
`mouse-drag-and-drop-region-cut-when-buffers-differ'?  I believe you're
experiencing intentional behavior: by default, text is copied when the
buffer which receives the drop is different from its source.

bug#63872: [PATCH] `mouse-drag-and-drop-region' sometimes couldn't cut

[Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On Jun 4, 2023, at 17:04, Shynur Xie <one.last.kiss@outlook.com> wrote:
> 
> 
>> 
>> From: Po Lu
>> Date: Sun, 04 Jun 2023 16:48:00 +0800
>>  To: Shynur
>> 
>> I believe you're experiencing intentional behavior: by default, text
>> is copied when the buffer which receives the drop is different from
>> its source.
> 
> The destination buffer is the original buffer.  I attached an MP4.
> 
> --
> shynur
> <bug63872-1.mp4>

Next time, please compress your attachments when they are large (> 1MB).  :)

-- 
Best,


RY

bug#63872: [PATCH] `mouse-drag-and-drop-region' sometimes couldn't cut

[Stefan Kangas]

Shynur Xie <one.last.kiss@outlook.com> writes:

>> From: Po Lu
>> Date: Sun, 04 Jun 2023 16:48:00 +0800
>>   To: Shynur
>>
>> I believe you're experiencing intentional behavior: by default, text
>> is copied when the buffer which receives the drop is different from
>> its source.
>
> The destination buffer is the original buffer.  I attached an MP4.

The video shows that text is copied also when the buffer which receives
the drop is the same as the source buffer.

Is that the intended behavior?  It seems off, to me.

bug#63872: [PATCH] `mouse-drag-and-drop-region' sometimes couldn't cut

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Stefan Kangas <stefankangas@gmail.com> writes:

> The video shows that text is copied also when the buffer which receives
> the drop is the same as the source buffer.
>
> Is that the intended behavior?  It seems off, to me.

I can't download that attachment, so would you please summarize its
contents?  The important detail is whether the destination window is the
same as the source.

bug#63872: [PATCH] `mouse-drag-and-drop-region' sometimes couldn't cut

[Stefan Kangas]

Po Lu <luangruo@yahoo.com> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> The video shows that text is copied also when the buffer which receives
>> the drop is the same as the source buffer.
>>
>> Is that the intended behavior?  It seems off, to me.
>
> I can't download that attachment, so would you please summarize its
> contents?  The important detail is whether the destination window is the
> same as the source.

I can reproduce this on current master with the following steps:

0. emacs -Q
1. Evaluate this in *scratch*:

    (custom-set-variables
     '(mark-even-if-inactive nil)
     '(mouse-drag-and-drop-region t))

2. Mark some text with the mouse, and then drag and drop it into the
   same window.

The result is that the text is copied.  This is also what happens in the
video.

In GNU Emacs 30.0.50 (build 12, x86_64-apple-darwin21.6.0, NS
 appkit-2113.60 Version 12.6.8 (Build 21G725)) of 2023-09-06 built on
 MY-MacBook-Pro
Repository revision: c3584bb3ab6f442a837464e191182f713acc3be3
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2113
System Description:  macOS 12.6.8

Configured features:
ACL GIF GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY KQUEUE NS
PDUMPER PNG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP
XIM ZLIB