From: Stefan Kangas <stefankangas@gmail.com>
To: Jonas Bernoulli <jonas@bernoul.li>, 62751@debbugs.gnu.org
Subject: bug#62751: 29.0.90; New libraries that still need to be assigned to packages
Date: Sat, 16 Sep 2023 07:23:23 -0700 [thread overview]
Message-ID: <CADwFkmnhAAez8tGyztYoVe_zYfZLq-xdLgM7X84NKTgYDVAZ5Q@mail.gmail.com> (raw)
In-Reply-To: <87zg7fyjka.fsf@bernoul.li>
fixed 62751 30.1
thanks
Jonas Bernoulli <jonas@bernoul.li> writes:
> Some new libraries still need to be assigned to a package in
> `package--builtins'.
>
> In some cases it seems clear to me, or at least likely, that we forgot
> to declare the package when adding the new library. I.e., that treating
> them as packages in their own right, was not intentional, but the result
> of that being the fallback behavior when no package is explicitly
> specified.
Thanks, I've fixed most of these items now. Note that you need to
make bootstrap before it will take effect.
> 1. ietf-drums-date.el (summary: "parse time/date for ietf-drums.el"),
> should be part of ietf-drums.
Done.
> 3. package-vc.el should probably be treated as a package separate
> from Package, to make it easier to distribute Package on GNU ELPA.
I think this is already the case, but I copied in Philip in case he has
any comments.
> 4. All, or most, of the *-ts-mode.el probably should be treated as
> separate packages.
I might be missing something, but isn't this already the case?
> 5. c-ts-common.el should probably not be a separate package. Maybe it
> should be part of c-ts-mode, or maybe even all the *-ts-mode.el, that
> depend on this library, should be part of a single c-ts-mode?
It seems to me an implementation detail of these packages:
./progmodes/js.el:57:(require 'c-ts-common) ; For comment indent and filling.
./progmodes/java-ts-mode.el:32:(require 'c-ts-common) ; For comment
indent and filling.
./progmodes/csharp-mode.el:37:(require 'c-ts-common) ; For comment
indenting and filling.
./progmodes/c-ts-mode.el:70:(require 'c-ts-common)
./progmodes/typescript-ts-mode.el:33:(require 'c-ts-common) ; For
comment indent and filling.
./progmodes/rust-ts-mode.el:32:(require 'c-ts-common) ; For comment
indent and filling.
I think it makes the most sense to simply make c-ts-common.el a part of
the emacs package, and let the others remain as first-class citizens in
their own packages. So I made that change.
> The following packages are also listed separately in package--builtins,
> but I tend to think that is not intentional.
>
> part of?:
> 6. lisp/keymap.el emacs
> 7. lisp/emacs-lisp/oclosure.el emacs
> 8. lisp/net/tramp-container.el tramp
Michael already fixed (8), and I've now fixed 6 and 7.
> 9. It seems a bit excessive to consider each use-package*.el a separate
> package. Maybe they should all be part of a single use-package
> package. An entry in finder--builtins-alist should be used to
> accomplish that.
Done.
> 10. All the lisp/net/eudc*.el should probably be part of a single eudc
> package.
Done.
> 11. All the lisp/image/image-dired*.el should probably be part of a
> single image-dired package.
Done.
> Maybe we should stop falling though to assign a new library to its own
> separate package, if nothing else is specified explicitly? It is of
> course nice not having to either add a "Package" library header or a
> finder--builtins-alist entry, but it also makes it easy to forget to
> explicitly specify the package when doing that would be necessary.
Hmm, yes that might make more sense. One would have to add package
statements to a ton of libraries, though. So there'll be a lot of
churn.
Maybe it's worth it in the end, I don't know.
> Speaking of finder--builtins-alist, what about adding these entries?:
> ("leim" . emacs)
> ("obsolete" . emacs)
Done.
next prev parent reply other threads:[~2023-09-16 14:23 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 13:04 bug#62751: 29.0.90; New libraries that still need to be assigned to packages Jonas Bernoulli
2023-04-10 13:30 ` Eli Zaretskii
2023-04-11 16:03 ` Michael Albinus
2023-04-11 17:16 ` Jonas Bernoulli
2023-09-05 23:49 ` Stefan Kangas
2023-09-16 9:21 ` Stefan Kangas
2023-09-16 14:23 ` Stefan Kangas [this message]
2023-09-17 22:06 ` Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-18 7:34 ` Stefan Kangas
2023-09-18 11:02 ` Eli Zaretskii
2023-09-18 11:10 ` Stefan Kangas
2023-09-18 11:49 ` Eli Zaretskii
2023-09-21 0:15 ` Stefan Kangas
2023-09-21 2:29 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-21 7:26 ` Stefan Kangas
2023-09-21 14:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-22 12:36 ` Stefan Kangas
2023-09-21 7:15 ` Eli Zaretskii
2023-09-21 7:29 ` Stefan Kangas
2023-09-23 14:42 ` Stefan Kangas
2023-09-24 18:07 ` John Wiegley
2023-09-24 20:22 ` Stefan Kangas
2023-09-24 21:05 ` John Wiegley
2023-09-26 22:37 ` Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-18 11:58 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-21 0:06 ` Stefan Kangas
2023-09-18 15:19 ` Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-20 15:59 ` Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-24 12:29 ` Stefan Kangas
2023-10-01 13:11 ` Stefan Kangas
2023-10-01 13:56 ` Eli Zaretskii
2023-10-01 15:46 ` Stefan Kangas
2023-10-01 16:52 ` Eli Zaretskii
2023-10-01 17:46 ` Stefan Kangas
2023-09-18 15:33 ` Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-21 0:04 ` Stefan Kangas
2023-09-21 21:12 ` Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-22 15:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-23 11:35 ` Stefan Kangas
2023-10-13 23:33 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-14 6:45 ` Eli Zaretskii
2023-10-14 14:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-14 16:21 ` Stefan Kangas
2023-09-19 23:12 ` Richard Stallman
2023-09-20 23:45 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmnhAAez8tGyztYoVe_zYfZLq-xdLgM7X84NKTgYDVAZ5Q@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=62751@debbugs.gnu.org \
--cc=jonas@bernoul.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).