unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 37621@debbugs.gnu.org
Subject: bug#37621: [PATCH] Remove XEmacs compat code from edt.el
Date: Mon, 7 Oct 2019 14:58:39 +0200	[thread overview]
Message-ID: <CADwFkmngH5cyu0XsuXh=dxonN+kNr19vYigUx_Mnq6-OsUAgNA@mail.gmail.com> (raw)
In-Reply-To: <87a7aeq4ko.fsf@tcd.ie>

Basil L. Contovounesios <contovob@tcd.ie> writes:

> Hopefully no-one will complain about these constants disappearing
> without first being made obsolete (I won't). ;)

I thought that it was fine to just remove them when they are only
relevant for XEmacs or backwards compatibility?  I could of course
declare them obsolete instead if that's preferable.

> The calls to (function ...) can be removed, as they are redundant around
> evaluated lambdas.

Indeed, I had missed that.

> Otherwise looks fine to me, FWIW.

Thanks for reviewing.  I intend to push this in a couple of days if no
one raises any objections.

Best regards,
Stefan Kangas





  reply	other threads:[~2019-10-07 12:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-04 14:08 bug#37621: [PATCH] Remove XEmacs compat code from edt.el Stefan Kangas
2019-10-05 21:12 ` Basil L. Contovounesios
2019-10-07 12:58   ` Stefan Kangas [this message]
2019-10-09 18:12     ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmngH5cyu0XsuXh=dxonN+kNr19vYigUx_Mnq6-OsUAgNA@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=37621@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).