From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#37621: [PATCH] Remove XEmacs compat code from edt.el Date: Mon, 7 Oct 2019 14:58:39 +0200 Message-ID: References: <87a7aeq4ko.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="133332"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37621@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 07 14:59:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHSbY-000YX2-GT for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Oct 2019 14:59:12 +0200 Original-Received: from localhost ([::1]:44322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHSbW-00015W-O0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Oct 2019 08:59:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54305) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHSbP-000150-Fd for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 08:59:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHSbO-0005gA-JH for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 08:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38638) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iHSbO-0005g4-GU for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 08:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iHSbO-00089k-Cj for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 08:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Oct 2019 12:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37621 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37621-submit@debbugs.gnu.org id=B37621.157045313831343 (code B ref 37621); Mon, 07 Oct 2019 12:59:02 +0000 Original-Received: (at 37621) by debbugs.gnu.org; 7 Oct 2019 12:58:58 +0000 Original-Received: from localhost ([127.0.0.1]:47459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHSbK-00089S-Ap for submit@debbugs.gnu.org; Mon, 07 Oct 2019 08:58:58 -0400 Original-Received: from mail-pl1-f173.google.com ([209.85.214.173]:34977) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHSbI-00089D-Nu for 37621@debbugs.gnu.org; Mon, 07 Oct 2019 08:58:57 -0400 Original-Received: by mail-pl1-f173.google.com with SMTP id c3so5369936plo.2 for <37621@debbugs.gnu.org>; Mon, 07 Oct 2019 05:58:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bVzevNhPbjrPeSt583iTYiQgYhN6VsrctWIdGESVRDA=; b=BJ0M57YHjFwwB7VxoU5QYlMTs2dhfQOLJVcbmay1+jH/pRSSLuikLaw3jtV3PF46mC QfZ08bqV7Vi2xPRBHBDhx21MpqpJy4alZNGWVMVd3cAk7jphXju6jYHGjYlSznH3FFY4 M2HOKwIOXWuBRhlmOt4EtZYB5Mc11zCgC/MoWJf0pbCzR/4fTsS2saspXLIC8t1pgxZs WFR6Tia1aitykjvTo/aEXl2dH00vlvOPP3Whg3dSAZYUW4uLIilzqK5h3Pw05Itp7cYD yMCEcXjPcSyJfpg7JfYl1I+2qKWgXcJfr/vGhJqAtaaweZg6KDRUyGIYzYFybX2A+KR6 nsvg== X-Gm-Message-State: APjAAAUO1WgAY1khuPfkeXsP4H8Iejac4RYmNG/auN+O0K5/cyyoUc+y zuwRtnVds7U2QYkGB9a1DbhXqMw7aw1gGx3FJZI= X-Google-Smtp-Source: APXvYqwdh+7V0x4rPasaf9LKKtVzZt9c53AVl5GIVtLdpWBDCqX4XvDkhC+i0KGhwXsHUPQ/YxsAJBDWA4WJuBTTRIs= X-Received: by 2002:a17:902:6b88:: with SMTP id p8mr24114807plk.251.1570453130684; Mon, 07 Oct 2019 05:58:50 -0700 (PDT) In-Reply-To: <87a7aeq4ko.fsf@tcd.ie> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168533 Archived-At: Basil L. Contovounesios writes: > Hopefully no-one will complain about these constants disappearing > without first being made obsolete (I won't). ;) I thought that it was fine to just remove them when they are only relevant for XEmacs or backwards compatibility? I could of course declare them obsolete instead if that's preferable. > The calls to (function ...) can be removed, as they are redundant around > evaluated lambdas. Indeed, I had missed that. > Otherwise looks fine to me, FWIW. Thanks for reviewing. I intend to push this in a couple of days if no one raises any objections. Best regards, Stefan Kangas