* bug#10292: following symlinks in byte-recompile-directory
@ 2011-12-13 14:22 Sam Aaron
2019-08-18 5:53 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Sam Aaron @ 2011-12-13 14:22 UTC (permalink / raw)
To: 10292
Hi there,
I noticed that the implementation of byte-recompile-directory has specific code to not allow symlinks to be followed. As I use symlinks to structure my ~/.emacs.d directory, this means this fn doesn't work for me. Is there any specific motivation for not having the following signature:
(byte-recompile-directory-sl DIRECTORY &optional ARG FORCE FOLLOW-SYMLINKS)
Sam
---
http://sam.aaron.name
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#10292: following symlinks in byte-recompile-directory
2011-12-13 14:22 bug#10292: following symlinks in byte-recompile-directory Sam Aaron
@ 2019-08-18 5:53 ` Lars Ingebrigtsen
2020-11-25 10:14 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2019-08-18 5:53 UTC (permalink / raw)
To: Sam Aaron; +Cc: 10292, Richard M. Stallman
Sam Aaron <samaaron@gmail.com> writes:
> I noticed that the implementation of byte-recompile-directory has
> specific code to not allow symlinks to be followed. As I use symlinks
> to structure my ~/.emacs.d directory, this means this fn doesn't work
> for me. Is there any specific motivation for not having the following
> signature:
>
> (byte-recompile-directory-sl DIRECTORY &optional ARG FORCE FOLLOW-SYMLINKS)
(I'm going through old bug reports that unfortunately have gotten no
responses yet.)
Not following symlinks introduced in 1993, but the commit message
doesn't explain why:
commit e9681c45f9ffd2819410b763338ba58b0b892b78
Author: Richard M. Stallman <rms@gnu.org>
Date: Thu Dec 23 03:37:27 1993 +0000
(byte-compile-dest-file): If FILENAME is not recognized, append .elc to it.
(byte-recompile-directory): Don't treat symlinks as dirs.
(batch-byte-recompile-directory): Add autoload cookie.
Adding a parameter to the function to follow symlinks seems pretty
harmless, and seems somewhat useful, so I think it should be added.
Does anybody object to that?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#10292: following symlinks in byte-recompile-directory
2019-08-18 5:53 ` Lars Ingebrigtsen
@ 2020-11-25 10:14 ` Stefan Kangas
2020-11-26 10:00 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2020-11-25 10:14 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Sam Aaron, 10292, Richard M. Stallman
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Sam Aaron <samaaron@gmail.com> writes:
>
>> I noticed that the implementation of byte-recompile-directory has
>> specific code to not allow symlinks to be followed. As I use symlinks
>> to structure my ~/.emacs.d directory, this means this fn doesn't work
>> for me. Is there any specific motivation for not having the following
>> signature:
>>
>> (byte-recompile-directory-sl DIRECTORY &optional ARG FORCE FOLLOW-SYMLINKS)
>
> (I'm going through old bug reports that unfortunately have gotten no
> responses yet.)
>
> Not following symlinks introduced in 1993, but the commit message
> doesn't explain why:
>
> commit e9681c45f9ffd2819410b763338ba58b0b892b78
> Author: Richard M. Stallman <rms@gnu.org>
> Date: Thu Dec 23 03:37:27 1993 +0000
>
> (byte-compile-dest-file): If FILENAME is not recognized, append .elc to it.
>
> (byte-recompile-directory): Don't treat symlinks as dirs.
>
> (batch-byte-recompile-directory): Add autoload cookie.
>
> Adding a parameter to the function to follow symlinks seems pretty
> harmless, and seems somewhat useful, so I think it should be added.
Yes, I agree.
> Does anybody object to that?
Let's assume no, since there has been no replies in the last year. :-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#10292: following symlinks in byte-recompile-directory
2020-11-25 10:14 ` Stefan Kangas
@ 2020-11-26 10:00 ` Lars Ingebrigtsen
0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2020-11-26 10:00 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Sam Aaron, 10292, Richard M. Stallman
Stefan Kangas <stefan@marxist.se> writes:
>> Adding a parameter to the function to follow symlinks seems pretty
>> harmless, and seems somewhat useful, so I think it should be added.
>
> Yes, I agree.
>
>> Does anybody object to that?
>
> Let's assume no, since there has been no replies in the last year. :-)
:-)
Now pushed to Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-26 10:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-13 14:22 bug#10292: following symlinks in byte-recompile-directory Sam Aaron
2019-08-18 5:53 ` Lars Ingebrigtsen
2020-11-25 10:14 ` Stefan Kangas
2020-11-26 10:00 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).