From: Stefan Kangas <stefankangas@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Axel Forsman <axelsfor@gmail.com>, 58007@debbugs.gnu.org
Subject: bug#58007: 28.1; compilation-error-properties skips non-matching FILE indices
Date: Wed, 6 Sep 2023 15:50:25 -0700 [thread overview]
Message-ID: <CADwFkmnYYb4feg7_-sGw=QgEuLg4iE1spti6NR0BMzrEYL1BUQ@mail.gmail.com> (raw)
In-Reply-To: <8735ch12vy.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 24 Sep 2022 12:29:53 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Reading the patch again, you're right -- since most of the changes are
> indentation changes, we can apply the patch without a copyright
> assignment.
>
> However, your patch leads to a test failure -- can you have a look at
> that?
That was one year ago.
Axel, did you have a chance to look into the below test failure?
> Test compile-test-functions backtrace:
> file-name-absolute-p(("my-file"))
> compilation-error-properties((closure (t) nil '("my-file")) (closure
> compilation-parse-errors(1 17)
> (let ((rule (nth 0 test)) (str (nth 1 test)) (pos (nth 2 test)) (col
> (let ((ert--infos (cons (cons "testcase: " (format "%S" test)) ert--
> compile--test-error-line((my-rule "My error message" 1 (39 . 24) (12
> (let ((compilation-num-errors-found 0) (compilation-num-warnings-fou
> (progn (font-lock-mode -1) (let ((compilation-num-errors-found 0) (c
> (unwind-protect (progn (font-lock-mode -1) (let ((compilation-num-er
> (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
> (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
> (let* ((file-fun #'(lambda nil '("my-file"))) (line-start-fun #'(lam
> (closure (t) nil (let* ((file-fun #'(lambda nil '("my-file"))) (line
> ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
> ert-run-test(#s(ert-test :name compile-test-functions :documentation
> ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
> ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
> ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
> ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
> eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
> command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/progmodes/compile-te
> command-line()
> normal-top-level()
> Test compile-test-functions condition:
> testcase: (my-rule "My error message" 1 (39 . 24) (123 . 134) "my-file" 2)
> (wrong-type-argument stringp
> ("my-file"))
> FAILED 2/3 compile-test-functions (0.000089 sec) at lisp/progmodes/compile-tests.el:522
> passed 3/3 compile-test-grep-regexps (0.001284 sec)
>
> Ran 3 tests, 2 results as expected, 1 unexpected (2022-09-24 12:26:55+0200, 0.083845 sec)
>
> 1 unexpected results:
> FAILED compile-test-functions
next prev parent reply other threads:[~2023-09-06 22:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 15:09 bug#58007: 28.1; compilation-error-properties skips non-matching FILE indices Axel Forsman
2022-09-23 16:10 ` Lars Ingebrigtsen
2022-09-23 18:29 ` Axel Forsman
2022-09-24 10:29 ` Lars Ingebrigtsen
2023-09-06 22:50 ` Stefan Kangas [this message]
2024-01-14 6:18 ` Stefan Kangas
2022-09-24 10:53 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmnYYb4feg7_-sGw=QgEuLg4iE1spti6NR0BMzrEYL1BUQ@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=58007@debbugs.gnu.org \
--cc=axelsfor@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).