From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#58007: 28.1; compilation-error-properties skips non-matching FILE indices Date: Wed, 6 Sep 2023 15:50:25 -0700 Message-ID: References: <87edw23wd5.fsf@gnus.org> <8735ch12vy.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2347"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Axel Forsman , 58007@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 07 00:51:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qe1Mf-0000Ns-6i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Sep 2023 00:51:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qe1MV-0002g9-Bs; Wed, 06 Sep 2023 18:51:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qe1MT-0002fw-G4 for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 18:51:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qe1MT-0004O8-7V for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 18:51:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qe1MU-0001u1-GN for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 18:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Sep 2023 22:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58007 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58007-submit@debbugs.gnu.org id=B58007.16940406377278 (code B ref 58007); Wed, 06 Sep 2023 22:51:02 +0000 Original-Received: (at 58007) by debbugs.gnu.org; 6 Sep 2023 22:50:37 +0000 Original-Received: from localhost ([127.0.0.1]:38097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qe1M4-0001tK-Lx for submit@debbugs.gnu.org; Wed, 06 Sep 2023 18:50:37 -0400 Original-Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]:58675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qe1M1-0001t2-Ar for 58007@debbugs.gnu.org; Wed, 06 Sep 2023 18:50:35 -0400 Original-Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2bd6611873aso6127011fa.1 for <58007@debbugs.gnu.org>; Wed, 06 Sep 2023 15:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694040626; x=1694645426; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=KlJu04hGwcKZLbwCqHW/GgCrLLBi5IxDlWZ5wIrZS8Y=; b=LC+TXxxTbc1mmnXWKsL8gJism/RAWjInGJL8N15MIHPeeYjtasCdJ3Cv3Og7sCvsJm NFSJhciAN5BKvRrKJ/DO7ul6/s5xagfEbpuD7j3VThhTFZt0jyJStysIL0TLhXf+9Boc YgP+RMJ358T1/tg+j9yZ4NM05SBS5yZumskBTmOvTzrUpmUjh6g4z4uNRp9PXIOeZ4Gw xt7tbaGjrD5PvYE1FO+JP/GpnZxB8/+xjhKU9gzm0pVsrXLszjkJl+PTD/gy0zuOexSE /4UxPwozEzefBRD027cpEwtpoDFO1pgv5IJgmRDVjCgx1x+zMbNx3XpAfN3zpCexs0Gn 9hJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694040626; x=1694645426; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KlJu04hGwcKZLbwCqHW/GgCrLLBi5IxDlWZ5wIrZS8Y=; b=XwSgZCOTOt2AcP9ydXAuPwGzSG8J+9XB7X1gOVnUbBnFnEsgszuuxTpYq5C7ec3aGJ lKNSUwfDtx26J1cO6p1q6wv9fGm233HEHAb9gtSbzVmgCUUMJz3vWw2kiQLHd3UeMRn2 ZYsFv3feSOMgdBx8gElxX1AZ6GRMfNCRUhASaggNAtiDh866MWBVAF7HCcgF4tNQZQTK EilSaN4mJBd4QvR5HDdQ5EnSMEgufefZFRGiOeRRb/U6NbGcI3k/0oWpfj0NuRb5wNr6 QgzX8XoP5HDRQVuGc/j0XFszq8Ynhz00gE6qIdK+GzsIy25GUrre9azgZKclZGQF1EpX oy0g== X-Gm-Message-State: AOJu0YwNTNbbcy6qnHKxEpKkhz694U6ddT3GcCS9eOmpWhnbU27sllCq T/yGxtjKGWd2O5tR0Yj3TADKA2U4AtqLlg/vWOw= X-Google-Smtp-Source: AGHT+IE8bXM/1Bak9bkydRhocwTsoi3CRMi+r7R8Ui+gfEoaTua7L764gfxAX02QdcxTliEKVglJIBQPtqEimPjg5hc= X-Received: by 2002:a2e:88d4:0:b0:2bc:be3c:9080 with SMTP id a20-20020a2e88d4000000b002bcbe3c9080mr3201415ljk.27.1694040625851; Wed, 06 Sep 2023 15:50:25 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 6 Sep 2023 15:50:25 -0700 In-Reply-To: <8735ch12vy.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 24 Sep 2022 12:29:53 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269595 Archived-At: Lars Ingebrigtsen writes: > Reading the patch again, you're right -- since most of the changes are > indentation changes, we can apply the patch without a copyright > assignment. > > However, your patch leads to a test failure -- can you have a look at > that? That was one year ago. Axel, did you have a chance to look into the below test failure? > Test compile-test-functions backtrace: > file-name-absolute-p(("my-file")) > compilation-error-properties((closure (t) nil '("my-file")) (closure > compilation-parse-errors(1 17) > (let ((rule (nth 0 test)) (str (nth 1 test)) (pos (nth 2 test)) (col > (let ((ert--infos (cons (cons "testcase: " (format "%S" test)) ert-- > compile--test-error-line((my-rule "My error message" 1 (39 . 24) (12 > (let ((compilation-num-errors-found 0) (compilation-num-warnings-fou > (progn (font-lock-mode -1) (let ((compilation-num-errors-found 0) (c > (unwind-protect (progn (font-lock-mode -1) (let ((compilation-num-er > (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn > (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current > (let* ((file-fun #'(lambda nil '("my-file"))) (line-start-fun #'(lam > (closure (t) nil (let* ((file-fun #'(lambda nil '("my-file"))) (line > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name compile-test-functions :documentation > ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m > ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co > ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) > ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un > eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( > command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/progmodes/compile-te > command-line() > normal-top-level() > Test compile-test-functions condition: > testcase: (my-rule "My error message" 1 (39 . 24) (123 . 134) "my-file" 2) > (wrong-type-argument stringp > ("my-file")) > FAILED 2/3 compile-test-functions (0.000089 sec) at lisp/progmodes/compile-tests.el:522 > passed 3/3 compile-test-grep-regexps (0.001284 sec) > > Ran 3 tests, 2 results as expected, 1 unexpected (2022-09-24 12:26:55+0200, 0.083845 sec) > > 1 unexpected results: > FAILED compile-test-functions